From: Vinicius Monego <monego@posteo.net>
To: "Stefan Reichör" <stefan@xsteve.at>, 48427@debbugs.gnu.org
Subject: [bug#48427] [PATCH 3/5] gnu: Add python-aiostream.
Date: Tue, 18 May 2021 22:31:06 +0000 [thread overview]
Message-ID: <43a07625ab314d5a9f75a0e883de06c889d76c1e.camel@posteo.net> (raw)
In-Reply-To: <20210514211746.143145-3-stefan@xsteve.at>
Hi,
Em sex, 2021-05-14 às 23:17 +0200, Stefan Reichör escreveu:
> * gnu/packages/python-xyz.scm (python-aiostream): New variable.
Thank you.
>
> +(define-public python-aiostream
> + (package
> + (name "python-aiostream")
> + (version "0.4.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "aiostream" version))
> + (sha256
> + (base32
> +
> "1k33bxrp24pa7c3hygzkv0lqvjil689aj442hzhgzv8vsbqmwd1n"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f)) ; tests fail, not sure why
Tests are not included in the PyPI tarball. That happens often in the
Python ecosystem, and in those cases we fetch directly from the
upstream repository.
After changing the source and adding #:test-target "pytest" to the
arguments (requires python-pytest-runner which is already there), I
could succesfully build the project with tests:
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/vxgmichel/aiostream")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"1r3x9qwl08yscmzvhafc6gsmq84lr17s6p7a1qxr49cmdvjzsc13"))))
(arguments
`(#:test-target "pytest"))
Note that python-build-system will run "python setup.py test" which is
used for unittest tests. If the project uses Pytest, as many do, we
often have to be explicit in the build either by adding #:test-target
"pytest" to the arguments and python-pytest-runner to native-inputs, or
by replacing the check phase and invoking pytest manually. Since
pytest-runner was deprecated recently, I believe the latter is the
better option from now on. The build could succeed without being
explicit, but you will see a message like "0 tests ran succesfully".
That may have happened in patches 2 and 5 from the series.
> + (home-page
> + "https://github.com/vxgmichel/aiostream")
> + (synopsis
> + "Generator-based operators for asynchronous iteration")
We don't break lines for the arguments of home-page and synopsis. The
pypi importer will add them by default, but they should be removed
while editing.
In the description, I'd replace "aiostream" with "@code{aiostream}".
The LICENSE file states GPL 3, though there are no copyright headers to
say "any later version". setup.py also says "gplv3". I'm guessing the
license should be gpl3 only, though I'm not sure about that one.
LGTM otherwise.
Could you check the rest of the series to see if the tests are running
correctly and then send a v2? I am not a committer and can't apply it
myself, so I have to leave that part for somebody else.
Vinicius
next prev parent reply other threads:[~2021-05-18 22:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 21:17 [bug#48428] [PATCH 1/5] gnu: python-pyte: Update to 0.8.0 Stefan Reichör
2021-05-14 21:17 ` [bug#48426] [PATCH 2/5] gnu: Add python-easy-ansi Stefan Reichör
2021-05-29 20:28 ` [bug#48426] [PATCH] " Stefan Reichör
2021-05-31 19:05 ` bug#48426: " Nicolas Goaziou
2021-05-14 21:17 ` [bug#48427] [PATCH 3/5] gnu: Add python-aiostream Stefan Reichör
2021-05-18 22:31 ` Vinicius Monego [this message]
2021-05-29 20:38 ` [bug#48427] [PATCH] " Stefan Reichör
2023-05-29 11:17 ` bug#48427: [PATCH 3/5] " Jelle Licht
2021-05-14 21:17 ` [bug#48429] [PATCH 4/5] gnu: Add python-aiofiles-0.5.0 Stefan Reichör
2021-05-14 21:17 ` [bug#48430] [PATCH 5/5] gnu: Add python-multiplex Stefan Reichör
2021-05-29 21:10 ` [bug#48430] [PATCH] " Stefan Reichör
2021-11-11 4:52 ` Vinicius Monego
2023-10-12 1:42 ` bug#48428: [PATCH 1/5] gnu: python-pyte: Update to 0.8.0 jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43a07625ab314d5a9f75a0e883de06c889d76c1e.camel@posteo.net \
--to=monego@posteo.net \
--cc=48427@debbugs.gnu.org \
--cc=stefan@xsteve.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).