From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6AQCEWdApGA9JwEAgWs5BA (envelope-from ) for ; Wed, 19 May 2021 00:32:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oQO0DGdApGD+egAAB5/wlQ (envelope-from ) for ; Tue, 18 May 2021 22:32:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E5DFB1BC06 for ; Wed, 19 May 2021 00:32:06 +0200 (CEST) Received: from localhost ([::1]:57974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj8Fy-0004mA-2N for larch@yhetil.org; Tue, 18 May 2021 18:32:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj8Fu-0004ln-Bw for guix-patches@gnu.org; Tue, 18 May 2021 18:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lj8Fu-0000qa-35 for guix-patches@gnu.org; Tue, 18 May 2021 18:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lj8Ft-0007hV-VQ for guix-patches@gnu.org; Tue, 18 May 2021 18:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48427] [PATCH 3/5] gnu: Add python-aiostream. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 May 2021 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan =?UTF-8?Q?Reich=C3=B6r?= , 48427@debbugs.gnu.org Received: via spool by 48427-submit@debbugs.gnu.org id=B48427.162137709129564 (code B ref 48427); Tue, 18 May 2021 22:32:01 +0000 Received: (at 48427) by debbugs.gnu.org; 18 May 2021 22:31:31 +0000 Received: from localhost ([127.0.0.1]:57549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj8FO-0007gm-IG for submit@debbugs.gnu.org; Tue, 18 May 2021 18:31:31 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj8FH-0007gT-2q for 48427@debbugs.gnu.org; Tue, 18 May 2021 18:31:29 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A539C240027 for <48427@debbugs.gnu.org>; Wed, 19 May 2021 00:31:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1621377076; bh=y4H8N5EHj5orogYZ4Ved4Xm4TTK3dHp87PKh065+Zp8=; h=Subject:From:To:Date:From; b=Lkb5wTJFoAMTHeTEBuD3sNO+Ue2I//PA6lrSqT4uQH8Q6Zg9Ehm9OznSZtnWt5yES mq/DJFHr7+EK+P2lu3kqTzgk+9vrrwRXh2pgLE/5D2Qz8f+kAj0qrq/Tdr+3bpFdD+ l17iVJdN1zwm4dW+YYcVQuyPI55J/pAUGq6RdD9tOwQWTANCP71FW3LfEJh6m5TJEQ P6TGrBQf3OFtH/VWtX+UFl6IJWqmFzVdnGGWzSsL8doMl/p4J2V4WvA9CWbmojgNu9 1+kp3v9P+Bvqwt1aIiFearzNXeXFDPNfKDsrPfT97yB07uJjvsKZ2XmyjK/nF9y7tS 4umgMPQQH+I+Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fl9hL6C5Gz9rxM; Wed, 19 May 2021 00:31:14 +0200 (CEST) Message-ID: <43a07625ab314d5a9f75a0e883de06c889d76c1e.camel@posteo.net> From: Vinicius Monego Date: Tue, 18 May 2021 22:31:06 +0000 In-Reply-To: <20210514211746.143145-3-stefan@xsteve.at> References: <20210514211746.143145-1-stefan@xsteve.at> <20210514211746.143145-3-stefan@xsteve.at> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621377127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=88oEUum/3iAFyNAfuqMI627iv0KWYYX0kt+ooIKnpaM=; b=QuZulXmKhzJL1KJN41zDi6nmJ44EksTOfSwJ9bAHyZFgJrNqXhCK6w8olN3D7w5Y0msfIf 6EW+88/gl4Bgdb1L3+nbxDmcAUlivVINrt+V6lCV1gf35nEghypjoBRfaokEvuq+DrVIyi 40Jt6DcWAgJi+1ZgHzlSx/ejn3yrPEoqQPHi/8tBzxQAnsR+YZn4hdSmlIasxAfJ9beYCZ TzvC7yI6RFKwRIZaheNQyN9JIKlPpxW5INWLIxewPqyzj8xkrKXyy7cn4JoPr5sCbu8dGC DrTpkTy5+ECX3t/hKEbedYa3hSfU47mceHVjzvN3qw0QCvIvrACro/GXOeWZhg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621377127; a=rsa-sha256; cv=none; b=lB5sI25GU9tBqb3+QDhLyVXpsmX0ATMsA8piJdgW3ulcwBRVCU/eASPAr7ofhYlcjv9/Pe yCHUPcWiO0TAnX5hqSAipT5oelfp8XXTitH+mLfcLVglCRFpYVDFm9jgN8r7gtudGsUMVl cIrP7ATEdFrsF8QfgqBNnL9YAktpKeGRSQQ00w/6liIiwrWy5kj+19arrQsac21E7+DuZI 7RpprDfhwOkrpz80YDysL6CbA+8S151wedU/tsJHfzPRSXbe9QCZwKVWqwZvp2AmYMSyEB cE59oIELXpb9si0WF/6D1F113NEe27i0Ki+5BQooV8RkzUmosoa0UnVrPUn3ZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Lkb5wTJF; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Lkb5wTJF; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E5DFB1BC06 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: s0Ui6S2ojyYE Hi, Em sex, 2021-05-14 às 23:17 +0200, Stefan Reichör escreveu: > * gnu/packages/python-xyz.scm (python-aiostream): New variable. Thank you. > > +(define-public python-aiostream > +  (package > +    (name "python-aiostream") > +    (version "0.4.3") > +    (source > +      (origin > +        (method url-fetch) > +        (uri (pypi-uri "aiostream" version)) > +        (sha256 > +          (base32 > +            > "1k33bxrp24pa7c3hygzkv0lqvjil689aj442hzhgzv8vsbqmwd1n")))) > +    (build-system python-build-system) > +    (arguments > +     `(#:tests? #f)) ; tests fail, not sure why Tests are not included in the PyPI tarball. That happens often in the Python ecosystem, and in those cases we fetch directly from the upstream repository. After changing the source and adding #:test-target "pytest" to the arguments (requires python-pytest-runner which is already there), I could succesfully build the project with tests: (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/vxgmichel/aiostream") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "1r3x9qwl08yscmzvhafc6gsmq84lr17s6p7a1qxr49cmdvjzsc13")))) (arguments `(#:test-target "pytest")) Note that python-build-system will run "python setup.py test" which is used for unittest tests. If the project uses Pytest, as many do, we often have to be explicit in the build either by adding #:test-target "pytest" to the arguments and python-pytest-runner to native-inputs, or by replacing the check phase and invoking pytest manually. Since pytest-runner was deprecated recently, I believe the latter is the better option from now on. The build could succeed without being explicit, but you will see a message like "0 tests ran succesfully". That may have happened in patches 2 and 5 from the series. > +    (home-page > +      "https://github.com/vxgmichel/aiostream") > +    (synopsis > +      "Generator-based operators for asynchronous iteration") We don't break lines for the arguments of home-page and synopsis. The pypi importer will add them by default, but they should be removed while editing. In the description, I'd replace "aiostream" with "@code{aiostream}". The LICENSE file states GPL 3, though there are no copyright headers to say "any later version". setup.py also says "gplv3". I'm guessing the license should be gpl3 only, though I'm not sure about that one. LGTM otherwise. Could you check the rest of the series to see if the tests are running correctly and then send a v2? I am not a committer and can't apply it myself, so I have to leave that part for somebody else. Vinicius