unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: "Parnikkapore" <poomklao@yahoo.com>, 64732@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>, "Lars-Dominik Braun" <lars@6xq.net>
Subject: [bug#64732] [PATCH v3 1/2] gnu: Add python-ffmpeg-python.
Date: Sat, 22 Jul 2023 13:54:21 +0000	[thread overview]
Message-ID: <40ae688dc99d72f784f2fb1a155e22dc@dismail.de> (raw)
In-Reply-To: <bcae23c779592e17719214ec54c89ba86c2e9aa9.1689922236.git.poomklao@yahoo.com>

Lars,

Should these be patched to refer to our ffmpeg?

https://github.com/kkroening/ffmpeg-python/blob/df129c7ba30aaa9ffffb81a48f53aa7253b0b4e6/ffmpeg/_run.py#L302

And a call to subprocess.check_call in the tests:

https://github.com/kkroening/ffmpeg-python/blob/df129c7ba30aaa9ffffb81a48f53aa7253b0b4e6/ffmpeg/tests/test_ffmpeg.py#L29

WDYT if we document our policy for patching executables. Currently, this practice is tribal knowledge that Guixers receive during patch review but we don't have it officially in writing anywhere (e.g. manual, cookbook, etc)

Ludo WDYT

all best,

jgart




  parent reply	other threads:[~2023-07-22 13:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1689780467.git.poomklao.ref@yahoo.com>
2023-07-19 15:30 ` [bug#64732] [PATCH 0/2] Add r128gain Parnikkapore via Guix-patches via
2023-07-19 15:34   ` [bug#64732] [PATCH 1/2] gnu: Add python-ffmpeg-python Parnikkapore via Guix-patches via
2023-07-19 15:34   ` [bug#64732] [PATCH 2/2] gnu: Add r128gain Parnikkapore via Guix-patches via
2023-07-19 23:40   ` [bug#64732] [PATCH 1/2] gnu: Add python-ffmpeg-python jgart via Guix-patches via
2023-07-20  2:34     ` Parnikkapore via Guix-patches via
2023-07-20  4:08     ` jgart via Guix-patches via
2023-07-20 15:51   ` [bug#64732] [PATCH v2 " Parnikkapore via Guix-patches via
2023-07-20 15:51     ` [bug#64732] [PATCH v2 2/2] gnu: Add r128gain Parnikkapore via Guix-patches via
     [not found]     ` <eb3eaaa0e7f3d610c6ea0bcc8e170c9544397520.1689868307.git.poomklao.ref@yahoo.com>
2023-07-20 17:00       ` [bug#64732] [PATCH v2 1/2] gnu: Add python-ffmpeg-python jgart via Guix-patches via
2023-07-21  6:50         ` [bug#64732] [PATCH v3 " Parnikkapore via Guix-patches via
2023-07-21  6:50           ` [bug#64732] [PATCH v3 2/2] gnu: Add r128gain Parnikkapore via Guix-patches via
     [not found]           ` <bcae23c779592e17719214ec54c89ba86c2e9aa9.1689922236.git.poomklao.ref@yahoo.com>
2023-07-22 13:06             ` [bug#64732] [PATCH v3 1/2] gnu: Add python-ffmpeg-python jgart via Guix-patches via
2023-07-22 13:50               ` Parnikkapore via Guix-patches via
2023-07-22 13:54             ` jgart via Guix-patches via [this message]
2023-07-22 15:59               ` Lars-Dominik Braun
2023-07-22 18:13               ` jgart via Guix-patches via
2023-07-24 19:11               ` jgart via Guix-patches via
2023-08-04 14:56                 ` [bug#64732] [PATCH v4 " Parnikkapore via Guix-patches via
2023-08-04 14:56                   ` [bug#64732] [PATCH v4 2/2] gnu: Add r128gain Parnikkapore via Guix-patches via
2023-08-20 21:08                   ` bug#64732: [PATCH 0/2] " Ludovic Courtès
2023-07-22 14:34             ` [bug#64732] [PATCH v3 1/2] gnu: Add python-ffmpeg-python jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40ae688dc99d72f784f2fb1a155e22dc@dismail.de \
    --to=guix-patches@gnu.org \
    --cc=64732@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=lars@6xq.net \
    --cc=ludo@gnu.org \
    --cc=poomklao@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).