From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SApCJb/fu2S4AAAASxT56A (envelope-from ) for ; Sat, 22 Jul 2023 15:55:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8Ev0JL/fu2RdVAEAauVa8A (envelope-from ) for ; Sat, 22 Jul 2023 15:55:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B64544836 for ; Sat, 22 Jul 2023 15:55:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=EAbt9rBq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690034111; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=whEThap6WYWNGf2XAFehBfucYMvsEcKM7LQZx6B0y90=; b=B+GXUH2rKs2YMAM+j0rYCeogb+HQlswE/a2sDglLYPq4+CYDATKQ3Wj1t21jEJIbM8KP9/ UoJcdnLNr+rLIMJ20fgAmHNzeb5R2/mkRgZxq01RlDmwspTiWz9u+BEAYsAYcWqvBNga87 Ymb90H8RiWy6YluGSJiD1K2hKBUP4GjwGUHQX9cZ8qsHzfizDsamJ1C+JbB70Bxnql8jhh W4jCyQDlGl8iWMzv4gWUh2Rvv/P5xfu8kqvu0NXcZeVAILDRM26++nQnohQuo2AWYq/qpS sm34yXMbk1ULQqRgdykSflc+q3bhaWwt2A8evHTzgxmjWMrtHw95vejODe8NWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690034111; a=rsa-sha256; cv=none; b=C63TmOteyoT2skF/nMRclYKYbu2/YX6btXNcxaI/tYxm6r1MLEfIVDV4asIN9oJmFJWcCG dA381fhN+T/SI87WE/y5stQK+AGbVj2WfHpaKoCycjwDL8PhXlA6EgHBYpF9mCECeFJbnM QWfwTk1JtxH+lRd1rcHltqD7PdGeFjtDFJZMIvNCa2i6ZbUhhv1TmP4z/1i2y1t398SwHe zGDhGZhO4AbX8ZTkmToL8RnXfrXhub12nJ1nIfGe5oEm3xwiBhXPGNQk65vul60OxelMGB lS8hF8leiNgw/RUYUvvpdWvdybFLrCNVN8Ekrjm6EsyvllG8f47BUBh2SyR03Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=EAbt9rBq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qND4a-0007uM-8a; Sat, 22 Jul 2023 09:55:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qND4Y-0007u7-7E for guix-patches@gnu.org; Sat, 22 Jul 2023 09:55:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qND4X-0004gK-V7 for guix-patches@gnu.org; Sat, 22 Jul 2023 09:55:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qND4X-0007NX-RD for guix-patches@gnu.org; Sat, 22 Jul 2023 09:55:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64732] [PATCH v3 1/2] gnu: Add python-ffmpeg-python. Resent-From: "jgart" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Jul 2023 13:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64732 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Parnikkapore" , 64732@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Lars-Dominik Braun Received: via spool by 64732-submit@debbugs.gnu.org id=B64732.169003407528318 (code B ref 64732); Sat, 22 Jul 2023 13:55:01 +0000 Received: (at 64732) by debbugs.gnu.org; 22 Jul 2023 13:54:35 +0000 Received: from localhost ([127.0.0.1]:35719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qND46-0007Mg-SF for submit@debbugs.gnu.org; Sat, 22 Jul 2023 09:54:35 -0400 Received: from mx1.dismail.de ([78.46.223.134]:33547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qND40-0007MM-TL for 64732@debbugs.gnu.org; Sat, 22 Jul 2023 09:54:33 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id dde09972; Sat, 22 Jul 2023 15:54:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:content-transfer-encoding:from :message-id:subject:to:cc:in-reply-to:references; s=20190914; bh=whEThap6WYWNGf2XAFehBfucYMvsEcKM7LQZx6B0y90=; b=EAbt9rBqH/jB y9m6VbyDUbgrR+yzUf+lwKE8SxIrI1EzkX/PXcBu3uJTtwg9+q99SXDmfBrBVwP8 rm4g/gKaXcFo0S9sAeimQ5NiXQXcbJEuILIUxFENWvJZASBNbR498cNV7xJ0jBUP olam0zPs9gXvG5pK+XDkdVGhxKxk4F3rxC5c7mEnkxzVxuMW48UrB7Ye9fhVUdd1 HJIYW2jz8QbO1B/o8tr1GCIyGb8/xtjf+SF8HYfAW4UsvbtEkfCpS/RiFdjMGOg4 iiWSvFObcctLot+P5/MFfoZkyFVwMf0hK+2xuOJvNsamcsfahCQ19SH5OrXoHjJp 8P4vyPbR2A== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id a2ffc67f; Sat, 22 Jul 2023 15:54:22 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id d2e9a4ac; Sat, 22 Jul 2023 15:54:22 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id c666f1c1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 22 Jul 2023 15:54:21 +0200 (CEST) MIME-Version: 1.0 Date: Sat, 22 Jul 2023 13:54:21 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: RainLoop/1.17.0 Message-ID: <40ae688dc99d72f784f2fb1a155e22dc@dismail.de> In-Reply-To: References: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -6.74 X-Spam-Score: -6.74 X-Migadu-Queue-Id: 3B64544836 X-TUID: XYF9K9DFpksw Lars, Should these be patched to refer to our ffmpeg? https://github.com/kkroening/ffmpeg-python/blob/df129c7ba30aaa9ffffb81a48= f53aa7253b0b4e6/ffmpeg/_run.py#L302 And a call to subprocess.check_call in the tests: https://github.com/kkroening/ffmpeg-python/blob/df129c7ba30aaa9ffffb81a48= f53aa7253b0b4e6/ffmpeg/tests/test_ffmpeg.py#L29 WDYT if we document our policy for patching executables. Currently, this = practice is tribal knowledge that Guixers receive during patch review but= we don't have it officially in writing anywhere (e.g. manual, cookbook, = etc) Ludo WDYT all best, jgart