From: Maxime Devos <maximedevos@telenet.be>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: othacehe@gnu.org, Julien Lepiller <julien@lepiller.eu>,
52472@debbugs.gnu.org
Subject: [bug#52472] [PATCH] gnu: Add libtree
Date: Fri, 28 Jan 2022 19:54:16 +0100 [thread overview]
Message-ID: <3c3cc605d110d977d10b0e7ed7d6f17d3af89f29.camel@telenet.be> (raw)
In-Reply-To: <87zgnfg1c2.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
Artyom V. Poptsov schreef op vr 28-01-2022 om 21:30 [+0300]:
> Hello,
>
> sorry for bugging you but are there any problems left with the package
> that I should solve? As far as I understand now the package is fine and
> can be merged to Guix. Am I mistaken?
As I wrote in <https://issues.guix.gnu.org/52472#12>, setting DESTDIR
is unnecessary. I haven't seen a revised patch not setting DESTDIR.
Aside from that, the patch looks reasonable. However, I didn't look at
all the source code (for hash mismatches etc.).
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-01-28 19:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 20:42 [bug#52472] [PATCH] gnu: Add libtree Artyom V. Poptsov
2021-12-18 8:02 ` Artyom V. Poptsov
2021-12-19 9:48 ` Mathieu Othacehe
2021-12-19 12:50 ` Julien Lepiller
2022-01-13 3:30 ` Artyom V. Poptsov
2022-01-13 7:38 ` Maxime Devos
2022-01-13 17:18 ` Artyom V. Poptsov
2022-01-13 17:37 ` Maxime Devos
2022-01-13 17:51 ` Artyom V. Poptsov
2022-01-17 18:09 ` Artyom V. Poptsov
2022-01-17 19:02 ` Maxime Devos
2022-01-17 19:14 ` Artyom V. Poptsov
2022-01-17 19:22 ` Maxime Devos
2022-01-28 18:30 ` Artyom V. Poptsov
2022-01-28 18:54 ` Maxime Devos [this message]
2022-02-04 18:25 ` Artyom V. Poptsov
2022-02-04 19:19 ` Maxime Devos
2022-02-05 5:50 ` Artyom V. Poptsov
2022-02-05 10:56 ` Maxime Devos
2022-02-05 11:34 ` Artyom V. Poptsov
2022-03-09 22:06 ` bug#52472: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c3cc605d110d977d10b0e7ed7d6f17d3af89f29.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=52472@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=othacehe@gnu.org \
--cc=poptsov.artyom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).