unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: poptsov.artyom@gmail.com (Artyom V. Poptsov)
Cc: 52472@debbugs.gnu.org
Subject: [bug#52472] [PATCH] gnu: Add libtree
Date: Sun, 19 Dec 2021 10:48:28 +0100	[thread overview]
Message-ID: <87bl1dsz6b.fsf_-_@gnu.org> (raw)
In-Reply-To: <87pmpu5oi8.fsf@gmail.com> (Artyom V. Poptsov's message of "Sat,  18 Dec 2021 11:02:55 +0300")


Hey Artyom,

>  ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
> +;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
> +

No need for an extra new-line here.

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "Makefile"
> +               (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
> +                (format #f "~a/bin/" (assoc-ref outputs "out")))
> +               (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
> +                (format #f "~a/share/" (assoc-ref outputs "out"))))))

You can now write:

--8<---------------cut here---------------start------------->8---
       ,#~(modify-phases %standard-phases
            (delete 'check)
            (delete 'configure)
            (add-before 'build 'patch
              (lambda* (#:key outputs #:allow-other-keys)
                (substitute* "Makefile"
                  (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
                   (string-append #$output "/bin/"))
                  (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
                   (string-append #$output "/share/")))))
--8<---------------cut here---------------end--------------->8---

> +         (replace 'build
> +           (lambda _
> +             (setenv "CC" "gcc")

That would break cross-compilation. You should use something like:

--8<---------------cut here---------------start------------->8---
(string-append "CC=" ,(cc-for-target)).
--8<---------------cut here---------------end--------------->8---

> +             (setenv "LDFLAGS" "-static")

Why are we building a static version of the program?

There's also this linter warning:

gnu/packages/linux.scm:8649:14: libtree@3.0.1: synopsis should start with an upper-case letter or digit

Thanks,

Mathieu




  reply	other threads:[~2021-12-19  9:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 20:42 [bug#52472] [PATCH] gnu: Add libtree Artyom V. Poptsov
2021-12-18  8:02 ` Artyom V. Poptsov
2021-12-19  9:48   ` Mathieu Othacehe [this message]
2021-12-19 12:50     ` Julien Lepiller
2022-01-13  3:30       ` Artyom V. Poptsov
2022-01-13  7:38         ` Maxime Devos
2022-01-13 17:18           ` Artyom V. Poptsov
2022-01-13 17:37             ` Maxime Devos
2022-01-13 17:51               ` Artyom V. Poptsov
2022-01-17 18:09                 ` Artyom V. Poptsov
2022-01-17 19:02                   ` Maxime Devos
2022-01-17 19:14                     ` Artyom V. Poptsov
2022-01-17 19:22                       ` Maxime Devos
2022-01-28 18:30                         ` Artyom V. Poptsov
2022-01-28 18:54                           ` Maxime Devos
2022-02-04 18:25                             ` Artyom V. Poptsov
2022-02-04 19:19                               ` Maxime Devos
2022-02-05  5:50                                 ` Artyom V. Poptsov
2022-02-05 10:56                                   ` Maxime Devos
2022-02-05 11:34                                     ` Artyom V. Poptsov
2022-03-09 22:06                                       ` bug#52472: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl1dsz6b.fsf_-_@gnu.org \
    --to=othacehe@gnu.org \
    --cc=52472@debbugs.gnu.org \
    --cc=poptsov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).