unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#61825] [PATCH] etc: Default to variables in tempel's git-reference... et al.
@ 2023-02-26 20:56 Liliana Marie Prikler
  2023-03-05  9:03 ` Liliana Marie Prikler
  0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2023-02-26 20:56 UTC (permalink / raw)
  To: 61825

Since we encourage using variables rather than magic hashes in the commit
fields, e.g. (commit version) and (commit commit), the default for
tempel to use quoted strings is rather off.  Thus, let the placeholder reflect
actual usage.

* etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use field name
as placeholder and don't quote value.
(svn-reference..., bzr-reference...)[revision]: Likewise.
(hg-reference...)[changeset]: Likewise.
---
 etc/snippets/tempel/scheme-mode | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/etc/snippets/tempel/scheme-mode b/etc/snippets/tempel/scheme-mode
index 54cb8e40a9..ef73a1e595 100644
--- a/etc/snippets/tempel/scheme-mode
+++ b/etc/snippets/tempel/scheme-mode
@@ -56,12 +56,12 @@ scheme-mode
 (git-reference...
  "(git-reference"
  n> "(url \"" p "\")"
- n> "(commit \"" p "\"))")
+ n> "(commit " (p "commit") "))")
 
 (svn-reference...
  "(svn-reference"
  n> "(url \"" p "\")"
- n> "(revision \"" p "\"))")
+ n> "(revision " (p "revision") "))")
 
 (cvs-reference...
  "(cvs-reference"
@@ -72,12 +72,12 @@ scheme-mode
 (hg-reference...
  "(hg-reference"
  n> "(url \"" p "\")"
- n> "(changeset \"" p "\"))")
+ n> "(changeset " (p "changeset") "))")
 
 (bzr-reference...
  "(bzr-reference"
  n> "(url \"" p "\")"
- n> "(revision \"" p "\"))")
+ n> "(revision " (p "revision") "))")
 
 (:phases\ "#:phases (modify-phases %standard-phases"
           n> p ")")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#61825] [PATCH] etc: Default to variables in tempel's git-reference... et al.
  2023-02-26 20:56 [bug#61825] [PATCH] etc: Default to variables in tempel's git-reference... et al Liliana Marie Prikler
@ 2023-03-05  9:03 ` Liliana Marie Prikler
  2023-06-18  7:00   ` bug#61825: " Liliana Marie Prikler
  0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2023-03-05  9:03 UTC (permalink / raw)
  To: 61825

Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
Prikler:
> Since we encourage using variables rather than magic hashes in the
> commit fields, e.g. (commit version) and (commit commit), the default
> for tempel to use quoted strings is rather off.  Thus, let the
> placeholder reflect actual usage.
> 
> * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> field name
> as placeholder and don't quote value.
> (svn-reference..., bzr-reference...)[revision]: Likewise.
> (hg-reference...)[changeset]: Likewise.
Pushed.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#61825: [PATCH] etc: Default to variables in tempel's git-reference... et al.
  2023-03-05  9:03 ` Liliana Marie Prikler
@ 2023-06-18  7:00   ` Liliana Marie Prikler
  0 siblings, 0 replies; 3+ messages in thread
From: Liliana Marie Prikler @ 2023-06-18  7:00 UTC (permalink / raw)
  To: 61825-done

Am Sonntag, dem 05.03.2023 um 10:03 +0100 schrieb Liliana Marie
Prikler:
> Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
> Prikler:
> > Since we encourage using variables rather than magic hashes in the
> > commit fields, e.g. (commit version) and (commit commit), the
> > default
> > for tempel to use quoted strings is rather off.  Thus, let the
> > placeholder reflect actual usage.
> > 
> > * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> > field name
> > as placeholder and don't quote value.
> > (svn-reference..., bzr-reference...)[revision]: Likewise.
> > (hg-reference...)[changeset]: Likewise.
> Pushed.
Forgot to mark as done.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-18  7:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-26 20:56 [bug#61825] [PATCH] etc: Default to variables in tempel's git-reference... et al Liliana Marie Prikler
2023-03-05  9:03 ` Liliana Marie Prikler
2023-06-18  7:00   ` bug#61825: " Liliana Marie Prikler

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).