* [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme.
@ 2023-07-06 20:51 Ahmad Draidi via Guix-patches via
2023-07-06 22:14 ` Nicolas Goaziou
2023-07-07 4:41 ` [bug#64502] [PATCH v2] " Ahmad Draidi via Guix-patches via
0 siblings, 2 replies; 4+ messages in thread
From: Ahmad Draidi via Guix-patches via @ 2023-07-06 20:51 UTC (permalink / raw)
To: 64502; +Cc: Ahmad Draidi, Andrew Tropin, Liliana Marie Prikler
* gnu/packages/emacs-xyz.scm (emacs-weyland-yutani-theme): New variable.
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 21aa820f0b..e6bd3ba5d4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35614,6 +35614,28 @@ (define-public emacs-nord-theme
syntax highlighting and UI components.")
(license license:expat)))
+(define-public emacs-weyland-yutani-theme
+ (let ((commit "e89a63a62e071180c9cdd9067679fadc3f7bf796")
+ (revision "0"))
+ (package
+ (name "emacs-weyland-yutani-theme")
+ (version (git-version "20210802.2251" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jstaursky/weyland-yutani-theme")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0gxlz9b7fvbjkqxsyb4l75g7jsxyms0i1vpnb6y499hl115akcaz"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/jstaursky/weyland-yutani-theme")
+ (synopsis "Emacs theme based on the Alien movie franchise")
+ (description
+ "Weyland Yutani is a dark Emacs theme based on the Alien movie franchise")
+ (license license:gpl3))))
+
(define-public emacs-janet-mode
(let ((commit "2f5bcabcb6953e1ed1926ba6a2328c453e8b4ac7"))
(package
base-commit: 961ffca1c75141cbb351d143b22b673638e9659d
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme.
2023-07-06 20:51 [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme Ahmad Draidi via Guix-patches via
@ 2023-07-06 22:14 ` Nicolas Goaziou
2023-07-07 4:41 ` [bug#64502] [PATCH v2] " Ahmad Draidi via Guix-patches via
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2023-07-06 22:14 UTC (permalink / raw)
To: 64502; +Cc: a.r.draidi, liliana.prikler, andrew
Hello,
Ahmad Draidi via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-weyland-yutani-theme): New
> variable.
Thank you. Some comments follow.
> +(define-public emacs-weyland-yutani-theme
> + (let ((commit "e89a63a62e071180c9cdd9067679fadc3f7bf796")
> + (revision "0"))
> + (package
> + (name "emacs-weyland-yutani-theme")
> + (version (git-version "20210802.2251" revision commit))
Base version is actually "0.1", not "20210802.2251", per "Version"
keyword in main file.
> + (description
> + "Weyland Yutani is a dark Emacs theme based on the Alien movie franchise")
The final full stop is missing.
> + (license license:gpl3))))
License is actually gpl3+.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#64502] [PATCH v2] gnu: Add emacs-weyland-yutani-theme.
2023-07-06 20:51 [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme Ahmad Draidi via Guix-patches via
2023-07-06 22:14 ` Nicolas Goaziou
@ 2023-07-07 4:41 ` Ahmad Draidi via Guix-patches via
2023-07-16 7:29 ` bug#64502: " Liliana Marie Prikler
1 sibling, 1 reply; 4+ messages in thread
From: Ahmad Draidi via Guix-patches via @ 2023-07-07 4:41 UTC (permalink / raw)
To: 64502; +Cc: Ahmad Draidi, Andrew Tropin, Liliana Marie Prikler
* gnu/packages/emacs-xyz.scm (emacs-weyland-yutani-theme): New variable.
---
Comments fixed.
Thanks for the support!
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 21aa820f0b..94bc9c02ac 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35614,6 +35614,29 @@ (define-public emacs-nord-theme
syntax highlighting and UI components.")
(license license:expat)))
+(define-public emacs-weyland-yutani-theme
+ (let ((commit "e89a63a62e071180c9cdd9067679fadc3f7bf796")
+ (revision "0"))
+ (package
+ (name "emacs-weyland-yutani-theme")
+ (version (git-version "0.1" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jstaursky/weyland-yutani-theme")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0gxlz9b7fvbjkqxsyb4l75g7jsxyms0i1vpnb6y499hl115akcaz"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/jstaursky/weyland-yutani-theme")
+ (synopsis "Emacs theme based on the Alien movie franchise")
+ (description
+ "Weyland Yutani is a dark Emacs theme based on the Alien movie
+franchise.")
+ (license license:gpl3+))))
+
(define-public emacs-janet-mode
(let ((commit "2f5bcabcb6953e1ed1926ba6a2328c453e8b4ac7"))
(package
base-commit: 961ffca1c75141cbb351d143b22b673638e9659d
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#64502: [PATCH v2] gnu: Add emacs-weyland-yutani-theme.
2023-07-07 4:41 ` [bug#64502] [PATCH v2] " Ahmad Draidi via Guix-patches via
@ 2023-07-16 7:29 ` Liliana Marie Prikler
0 siblings, 0 replies; 4+ messages in thread
From: Liliana Marie Prikler @ 2023-07-16 7:29 UTC (permalink / raw)
To: Ahmad Draidi, 64502-done; +Cc: Andrew Tropin
Am Freitag, dem 07.07.2023 um 08:41 +0400 schrieb Ahmad Draidi:
> * gnu/packages/emacs-xyz.scm (emacs-weyland-yutani-theme): New
> variable.
> ---
>
> Comments fixed.
Pushed the updated patch.
Cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-16 7:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-06 20:51 [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme Ahmad Draidi via Guix-patches via
2023-07-06 22:14 ` Nicolas Goaziou
2023-07-07 4:41 ` [bug#64502] [PATCH v2] " Ahmad Draidi via Guix-patches via
2023-07-16 7:29 ` bug#64502: " Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).