From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Raghav Gururajan <rg@raghavgururajan.name>, 45889@debbugs.gnu.org
Subject: [bug#45889] Nextcloud Client (v15)
Date: Tue, 09 Mar 2021 08:03:08 +0100 [thread overview]
Message-ID: <31701971d849e72506ed4105c92b2ad85d3aa6be.camel@student.tugraz.at> (raw)
In-Reply-To: <e6a29632-3161-a559-fc6d-fed0a928ffde@raghavgururajan.name>
Hi Raghav,
> Subject: [PATCH 2/3] gnu: Add qtsolutions.
> + (version
> + (git-version "0" revision commit))
> + (file-name
> + (git-file-name name version))
> + (("qt5")
> + "qt")
> + (("-head")
> + "")
> + (("SUBDIRS\\+=examples")
> + ""))
Try not to arbitrarily use too many new lines. If you break Scheme
code in such a manner for no good reason, it will look odd.
> + (("toAscii")
> + "toLatin1"))
Why not to UTF-8? Is the input already UTF-8 and we want to convert it
to a single-byte character set?
> + (("\\$\\$PWD")
> + (assoc-ref outputs "out")))
You should install the shared libraries in the install phase.
> + (list
> + "qtlockedfile"
> + "qtpropertybrowser"
> + "qtservice"
> + "qtsingleapplication"
> + "qtsoap")
Use '(...) for fixed input.
> Subject: [PATCH 3/3] gnu: Add nextcloud-client.
> + (commit
> + (string-append "v" version)))
> + ((" \\.\\./3rdparty/qtlockedfile/?.*")
> + "")
> + ((" \\.\\./3rdparty/qtsingleapplication/?.*")
> + "")
> + ((" \\.\\./3rdparty/kmessagewidget/?.*")
> + "")
> + ((" list\\(APPEND 3rdparty_SRC
> \\.\\./3rdparty/?.*\\)")
> + "")
I'm starting to grow a little suspicious about matching the leading
spaces. You probably want to lead this (and similar stuff in 0001)
with [ \t]*.
> + (("\\$\\{CMAKE_SOURCE_DIR\\}/src/3rdparty/qtlockedf
> ile")
> + (string-append (assoc-ref inputs "qtsolutions")
> + "/include/qtlockedfile/"))
> + (("\\$\\{CMAKE_SOURCE_DIR\\}/src/3rdparty/qtsinglea
> pplication")
> + (string-append (assoc-ref inputs "qtsolutions")
> + "/include/qtsingleapplication/"))
> + (("\\$\\{CMAKE_SOURCE_DIR\\}/src/3rdparty/kmessagew
> idget")
> + (string-append (assoc-ref inputs "kwidgetsaddons")
> + "/include/KF5/KWidgetsAddons/"))
LGTM, but probably deserves a comment.
Also, you might skip the stuff leading up to /3rdparty, i.e. have
".*/3rdparty/qtlockedfile", etc. Perhaps this gives you enough wiggle
room to do lockedfile and single application on the same line, but it
doesn't hurt if it doesn't.
> + (("\\$\\{synclib_NAME\\}")
> + (string-append "${synclib_NAME} "
> + "QtSolutions_LockedFile "
> + "QtSolutions_SingleApplication "
> + "KF5WidgetsAddons")))
Definitely deserves a comment and perhaps a less broad match?
> + (substitute* '("application.h" "application.cpp")
> + (("SharedTools::QtSingleApplication")
> + "QtSingleApplication")
> + (("slotParseMessage\\(const QString &(msg)?.*\\)")
> + "slotParseMessage(const QString &msg)")))
Also deserves a comment about QtSingleApplication differences.
> + (string-append "set(_install_dir
> \"${CMAKE_INSTALL_PREFIX}"
> + "/share/dbus-1/services\")")))
Would the raw string here exceed a line?
> + ;; All ThirdParty (except QtProgressIndicator)
> + license:lgpl2.1+
This is now just qtokenizer, right?
Regards,
Leo
next prev parent reply other threads:[~2021-03-09 7:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 10:09 [bug#45889] Nextcloud Desktop Raghav Gururajan
2021-01-16 6:40 ` [bug#45889] Nextcloud Desktop (v2) Raghav Gururajan
2021-01-16 8:33 ` [bug#45889] Nextcloud Desktop (v3) Raghav Gururajan
2021-01-16 10:09 ` [bug#45889] Nextcloud Desktop (v4) Raghav Gururajan
2021-01-16 10:48 ` Nicolò Balzarotti
2021-01-16 14:42 ` Raghav Gururajan
2021-01-16 14:34 ` [bug#45889] Nextcloud Desktop (v5) Raghav Gururajan
2021-01-17 14:44 ` [bug#45889] Nextcloud Client (v6) Raghav Gururajan
2021-01-24 18:45 ` david larsson
2021-02-01 15:07 ` Raghav Gururajan
2021-02-01 15:13 ` [bug#45889] Nextcloud Client (v7) Raghav Gururajan
2021-02-09 10:22 ` Leo Prikler
2021-02-13 20:36 ` [bug#45889] Nextcloud Client (v8) Raghav Gururajan
2021-02-13 21:47 ` Leo Prikler
2021-02-13 23:54 ` Raghav Gururajan
2021-02-14 0:47 ` [bug#45889] Nextcloud Client (v9) Raghav Gururajan
2021-02-14 10:53 ` [bug#45889] Nextcloud Client (v8) Leo Prikler
2021-02-18 20:23 ` [bug#45889] Nextcloud Client (v10) Raghav Gururajan via Guix-patches via
2021-02-18 22:26 ` Leo Prikler
2021-02-21 17:04 ` Raghav Gururajan via Guix-patches via
2021-02-21 17:45 ` Leo Prikler
2021-02-21 18:09 ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-21 18:22 ` Leo Prikler
2021-02-21 18:50 ` [bug#45889] Nextcloud Client (v12) Raghav Gururajan via Guix-patches via
2021-02-21 19:37 ` Leo Prikler
2021-02-22 17:29 ` [bug#45889] Nextcloud Client (v13) Raghav Gururajan via Guix-patches via
2021-02-23 14:27 ` [bug#45889] Nextcloud Client (v14) Raghav Gururajan via Guix-patches via
2021-02-23 17:58 ` Leo Prikler
2021-03-09 6:00 ` [bug#45889] Nextcloud Client (v15) Raghav Gururajan via Guix-patches via
2021-03-09 7:03 ` Leo Prikler [this message]
2021-03-09 10:50 ` [bug#45889] Nextcloud Client (v16) Raghav Gururajan via Guix-patches via
2021-03-09 11:39 ` Leo Prikler
2021-03-09 12:29 ` Raghav Gururajan via Guix-patches via
2021-03-09 12:43 ` [bug#45889] Nextcloud Client (v17) Leo Prikler
2021-03-09 15:16 ` [bug#45889] Nextcloud Client (v18) Raghav Gururajan via Guix-patches via
2021-03-09 23:24 ` bug#45889: " Leo Prikler
2021-03-10 3:46 ` [bug#45889] " Raghav Gururajan via Guix-patches via
2021-03-11 6:45 ` Raghav Gururajan via Guix-patches via
2021-03-11 6:49 ` Leo Prikler
2021-03-11 7:44 ` Raghav Gururajan via Guix-patches via
2021-03-12 9:25 ` david larsson
2021-03-12 9:47 ` Raghav Gururajan via Guix-patches via
2021-02-21 18:22 ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-09 12:53 ` [bug#45889] Nextcloud Client (v7) Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31701971d849e72506ed4105c92b2ad85d3aa6be.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=45889@debbugs.gnu.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).