unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Raghav Gururajan <rg@raghavgururajan.name>
To: "Nicolò Balzarotti" <anothersms@gmail.com>, 45889@debbugs.gnu.org
Subject: [bug#45889] Nextcloud Desktop (v4)
Date: Sat, 16 Jan 2021 09:42:10 -0500	[thread overview]
Message-ID: <0ac1a1a7-825a-0737-268f-b41502db0045@raghavgururajan.name> (raw)
In-Reply-To: <87o8hp6tu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>

Hi Nicolò!

> Why is it placed inside a new module?  It should fit nicely in sync.scm

Nextcloud is a big project. There will be other packages like server, 
plugins etc., which can then be added to this module. Concept is similar 
to linphone.scm.

> .git shouldn't be needed

Updated in v5.

> This hash is wrong, I get 022k7b3c30dymrjc1g3ly2cac1c34gkqnvjya6p7w2j3qw2w1dm2

Updated in v5.

> Something along the line of:
> 
> (let ((preserved-3rdparty-files
>                  '("QProgressIndicator" "qtlockedfile" "qtokenizer"
>                    "qtsingleapplication" "kmessagewidget")))
>             (with-directory-excursion "src/3rdparty"
>               (for-each
>                (lambda (directory)
>                  (simple-format #t "deleting: ~A\n" directory)
>                  (delete-file-recursively directory))
>                (lset-difference string=?
>                                 (scandir ".")
>                                 (cons* "." ".." preserved-3rdparty-files))))
>             #t)

The snippet didn't work, but I added comments in v5.

> This line is too long, you can use something like
> ("PKGCONFIG_GETVAR\\(.*") instead.

If I use this, it causes parsing error.

> Other long line, maybe string-append.

Ah, I have been advised before not to break lines like this via 
string-append.

> Why?

Added comments in v5.

> It's missing a comment on why this is needed (like qttest tries to create
> $HOME/.qttest/config/autostart/)
>> +    (license license:gpl2+)))

Added comments in v5.

> Unbundled dependencies have different licenses
> QprogressIndicator is under expat while others lgpl2.1+ if I'm not wrong

Updated in v5.

> Also, I tried removing ruby and python-sphinx from the dependencies and
> it did build fine, so be sure all of them are needed (or are they used
> for some optional feature?).

Ruby is for patch-shebangs phase. Sphinx was looked for during configure 
phase, but doesn't seem to do anything, so I removed it in v5.

Thanks so much for the review. :-)

Regards,
RG.




  reply	other threads:[~2021-01-16 14:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 10:09 [bug#45889] Nextcloud Desktop Raghav Gururajan
2021-01-16  6:40 ` [bug#45889] Nextcloud Desktop (v2) Raghav Gururajan
2021-01-16  8:33 ` [bug#45889] Nextcloud Desktop (v3) Raghav Gururajan
2021-01-16 10:09 ` [bug#45889] Nextcloud Desktop (v4) Raghav Gururajan
2021-01-16 10:48   ` Nicolò Balzarotti
2021-01-16 14:42     ` Raghav Gururajan [this message]
2021-01-16 14:34 ` [bug#45889] Nextcloud Desktop (v5) Raghav Gururajan
2021-01-17 14:44 ` [bug#45889] Nextcloud Client (v6) Raghav Gururajan
2021-01-24 18:45   ` david larsson
2021-02-01 15:07     ` Raghav Gururajan
2021-02-01 15:13 ` [bug#45889] Nextcloud Client (v7) Raghav Gururajan
2021-02-09 10:22   ` Leo Prikler
2021-02-13 20:36     ` [bug#45889] Nextcloud Client (v8) Raghav Gururajan
2021-02-13 21:47       ` Leo Prikler
2021-02-13 23:54         ` Raghav Gururajan
2021-02-14  0:47           ` [bug#45889] Nextcloud Client (v9) Raghav Gururajan
2021-02-14 10:53           ` [bug#45889] Nextcloud Client (v8) Leo Prikler
2021-02-18 20:23             ` [bug#45889] Nextcloud Client (v10) Raghav Gururajan via Guix-patches via
2021-02-18 22:26               ` Leo Prikler
2021-02-21 17:04                 ` Raghav Gururajan via Guix-patches via
2021-02-21 17:45                   ` Leo Prikler
2021-02-21 18:09                     ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-21 18:22                       ` Leo Prikler
2021-02-21 18:50                         ` [bug#45889] Nextcloud Client (v12) Raghav Gururajan via Guix-patches via
2021-02-21 19:37                           ` Leo Prikler
2021-02-22 17:29                             ` [bug#45889] Nextcloud Client (v13) Raghav Gururajan via Guix-patches via
2021-02-23 14:27                               ` [bug#45889] Nextcloud Client (v14) Raghav Gururajan via Guix-patches via
2021-02-23 17:58                                 ` Leo Prikler
2021-03-09  6:00                                   ` [bug#45889] Nextcloud Client (v15) Raghav Gururajan via Guix-patches via
2021-03-09  7:03                                     ` Leo Prikler
2021-03-09 10:50                                       ` [bug#45889] Nextcloud Client (v16) Raghav Gururajan via Guix-patches via
2021-03-09 11:39                                         ` Leo Prikler
2021-03-09 12:29                                           ` Raghav Gururajan via Guix-patches via
2021-03-09 12:43                                             ` [bug#45889] Nextcloud Client (v17) Leo Prikler
2021-03-09 15:16                                               ` [bug#45889] Nextcloud Client (v18) Raghav Gururajan via Guix-patches via
2021-03-09 23:24                                                 ` bug#45889: " Leo Prikler
2021-03-10  3:46                                                   ` [bug#45889] " Raghav Gururajan via Guix-patches via
2021-03-11  6:45                                                     ` Raghav Gururajan via Guix-patches via
2021-03-11  6:49                                                       ` Leo Prikler
2021-03-11  7:44                                                         ` Raghav Gururajan via Guix-patches via
2021-03-12  9:25                                                   ` david larsson
2021-03-12  9:47                                                     ` Raghav Gururajan via Guix-patches via
2021-02-21 18:22                       ` [bug#45889] Nextcloud Client (v11) Raghav Gururajan via Guix-patches via
2021-02-09 12:53   ` [bug#45889] Nextcloud Client (v7) Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ac1a1a7-825a-0737-268f-b41502db0045@raghavgururajan.name \
    --to=rg@raghavgururajan.name \
    --cc=45889@debbugs.gnu.org \
    --cc=anothersms@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).