From: swedebugia <swedebugia@riseup.net>
To: 35312@debbugs.gnu.org
Subject: [bug#35312] core-update: Handle jar-files with patches
Date: Thu, 27 Jun 2019 16:15:50 +0200 [thread overview]
Message-ID: <30fb000b-35d1-f7ab-f5f5-ceb9bc8a4ab9@riseup.net> (raw)
In-Reply-To: <20190418070621.09cd7307@alma-ubu>
On 2019-04-18 07:06, Björn Höfling wrote:
> Please review carefully, this is my first work below the gexp-border.
>
> This patch is the outcome of my question at:
>
> https://lists.gnu.org/archive/html/guix-devel/2019-04/msg00226.html
>
> When a jar-file had patches, it was not recognized and wrongly handled
> with "tar xz".
>
> There is one open question: For patch-and-repack, the flags defaults
> to '("p1"), but for jar-files we would usually need a "p0". That would
> mean for jar-sources with patches, one would need to manually add the
> patch-flags with "p0" to the origin. This is not nice. On the other
> hand, I would not like to override the patch-flags for jar-files to
> always "p0".
>
> WDYT?
>
> Björn
>
This seem to have fallen through the cracks. Can someone with gexp
knowledge review this?
--
Cheers Swedebugia
prev parent reply other threads:[~2019-06-27 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 5:06 [bug#35312] core-update: Handle jar-files with patches Björn Höfling
2019-06-27 14:15 ` swedebugia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30fb000b-35d1-f7ab-f5f5-ceb9bc8a4ab9@riseup.net \
--to=swedebugia@riseup.net \
--cc=35312@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).