From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45886) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgVDz-0003Uw-Vd for guix-patches@gnu.org; Thu, 27 Jun 2019 10:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgVDw-0002ee-FA for guix-patches@gnu.org; Thu, 27 Jun 2019 10:18:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgVDu-0002dW-1G for guix-patches@gnu.org; Thu, 27 Jun 2019 10:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgVDt-0002CE-Sl for guix-patches@gnu.org; Thu, 27 Jun 2019 10:18:01 -0400 Subject: [bug#35312] core-update: Handle jar-files with patches Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:45748) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgVDL-0003BP-P1 for guix-patches@gnu.org; Thu, 27 Jun 2019 10:17:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgVDH-0002LI-SA for guix-patches@gnu.org; Thu, 27 Jun 2019 10:17:26 -0400 Received: from mx1.riseup.net ([198.252.153.129]:44278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgVDD-0001jc-8s for guix-patches@gnu.org; Thu, 27 Jun 2019 10:17:21 -0400 Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 489291B9350 for ; Thu, 27 Jun 2019 07:15:53 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id 800B41203F2 for ; Thu, 27 Jun 2019 07:15:52 -0700 (PDT) References: <20190418070621.09cd7307@alma-ubu> From: swedebugia Message-ID: <30fb000b-35d1-f7ab-f5f5-ceb9bc8a4ab9@riseup.net> Date: Thu, 27 Jun 2019 16:15:50 +0200 MIME-Version: 1.0 In-Reply-To: <20190418070621.09cd7307@alma-ubu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35312@debbugs.gnu.org On 2019-04-18 07:06, Bj=C3=B6rn H=C3=B6fling wrote: > Please review carefully, this is my first work below the gexp-border. >=20 > This patch is the outcome of my question at: >=20 > https://lists.gnu.org/archive/html/guix-devel/2019-04/msg00226.html >=20 > When a jar-file had patches, it was not recognized and wrongly handled > with "tar xz". >=20 > There is one open question: For patch-and-repack, the flags defaults > to '("p1"), but for jar-files we would usually need a "p0". That would > mean for jar-sources with patches, one would need to manually add the > patch-flags with "p0" to the origin. This is not nice. On the other > hand, I would not like to override the patch-flags for jar-files to > always "p0". >=20 > WDYT? >=20 > Bj=C3=B6rn >=20 This seem to have fallen through the cracks. Can someone with gexp=20 knowledge review this? --=20 Cheers Swedebugia