[bug#53008] [PATCH 0/3] Add plugins to Thunar

[bug#53008] [PATCH 0/3] Add plugins to Thunar

[Simon Streit]

Hello,

I've been trying to package some plugins for Thunar.  Unfortunately these
plugins are not loaded, or are not found in Thunar, and so far I can't see
why.  There are no errors to begin with.  A guess would be missing path
declarations from, maybe, pkg-config.  Though the libs are residing in
../lib/thunarx-3, where they should be.

I'd be very happy if someone else wants to have a look at these patches
to see if they can be made workable.


Thank you!
Simon

[bug#53008] [PATCH 1/3] gnu: Add thunar-archive-plugin.

[Simon Streit]

* gnu/packages/xfce.scm (thunar-archive-plugin): New variable.
---
 gnu/packages/xfce.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c08a2349dc..e665dacd61 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -792,6 +792,32 @@ (define-public thunar-volman
 and import the new pictures from your camera.")
     (license gpl2+)))
 
+(define-public thunar-archive-plugin
+  (package
+    (name "thunar-archive-plugin")
+    (version "0.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://archive.xfce.org/src/thunar-plugins/"
+                           name "/" (version-major+minor version)
+                           "/" name "-" version ".tar.bz2"))
+       (sha256
+        (base32 "059ikda4hig1iqk0g5kqc4p95chj0z1ljhl5qjrlw4l8lf3gm0mz"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     (list pkg-config intltool))
+    (inputs
+     (list exo
+           thunar
+           gtk+
+           libxfce4ui))
+    (home-page "https://www.xfce.org/")
+    (synopsis "Adds archive operations to the Thunar file context menus")
+    (description "This plugin allows you to create and extract archive files
+using the file context menus in the Thunar file manager.")
+    (license gpl2+)))
+
 (define-public xfwm4
   (package
     (name "xfwm4")
-- 
2.34.0

[bug#53008] [PATCH 2/3] gnu: Add thunarx-python.

[Simon Streit]

* gnu/packages/xfce.scm (thunarx-python): New variable.
---
 gnu/packages/xfce.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index e665dacd61..9e1f0c2225 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -818,6 +818,34 @@ (define-public thunar-archive-plugin
 using the file context menus in the Thunar file manager.")
     (license gpl2+)))

+(define-public thunarx-python
+  (package
+    (name "thunarx-python")
+    (version "0.5.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://archive.xfce.org/src/bindings/"
+                           name "/" (version-major+minor version)
+                           "/" name "-" version ".tar.bz2"))
+       (sha256
+        (base32 "08lz9pvx006a2fypg2q38p61jbhy0yswz8cizlxpiwfcqsvhpnln"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     (list pkg-config))
+    (inputs
+     (list exo
+           thunar
+           python
+           python-pygobject
+           libxfce4ui
+           gtk+))
+    (home-page "https://gitlab.xfce.org/bindings/thunarx-python")
+    (synopsis "Python Bindings for Thunar")
+    (description "These bindings allow one to create python plugins
+for Thunar.")
+    (license gpl2+)))
+
 (define-public xfwm4
   (package
     (name "xfwm4")
--
2.34.0

[bug#53008] [PATCH 3/3] gnu: Add thunar-shares-plugin.

[Simon Streit]

* gnu/packages/xfce.scm (thunar-shares-plugin): New variable.
---
 gnu/packages/xfce.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 9e1f0c2225..0baecc215a 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -846,6 +846,34 @@ (define-public thunarx-python
 for Thunar.")
     (license gpl2+)))

+(define-public thunar-shares-plugin
+  (package
+    (name "thunar-shares-plugin")
+    (version "0.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://archive.xfce.org/src/thunar-plugins/"
+                           name "/" (version-major+minor version)
+                           "/" name "-" version ".tar.bz2"))
+       (sha256
+        (base32 "182j8jl91735004hbl0i2xxga4r6fk03srfl6g87czkjm9y8q7fw"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     (list pkg-config intltool))
+    (inputs
+     (list exo
+           thunar
+           thunarx-python
+           gtk+
+           libxfce4ui))
+    (home-page "https://www.xfce.org/")
+    (synopsis "Quickly share a folder using Samba from Thunar")
+    (description
+     "The Thunar Shares Plugin allows you to quickly share a folder using
+Samba from Thunar without requiring root access.")
+    (license gpl2+)))
+
 (define-public xfwm4
   (package
     (name "xfwm4")
--
2.34.0

[bug#53008] [PATCH 0/3] Add plugins to Thunar

[Ludovic Courtès]

Hi,

Simon Streit <simon@netpanic.org> skribis:

> I've been trying to package some plugins for Thunar.  Unfortunately these
> plugins are not loaded, or are not found in Thunar, and so far I can't see
> why.  There are no errors to begin with.  A guess would be missing path
> declarations from, maybe, pkg-config.  Though the libs are residing in
> ../lib/thunarx-3, where they should be.

Can you check in Thunar itself how those plugins are searched for and
loaded?

If it’s plain ‘dlopen’, then they’ll have to be in $LD_LIBRARY_PATH.

HTH,
Ludo’.

[bug#53008] Re: bug#53008: [PATCH 0/3] Add plugins to Thunar

[tumashu]

I think it is controled by:  THUNARX_DIRECTORY.

```
./thunarx-provider-factory.c\0158:  dp = g_dir_open (THUNARX_DIRECTORY, 0, NULL);
./thunarx-provider-module.c\0180:  path = g_build_filename (THUNARX_DIRECTORY, type_module->name, NULL);
./Makefile\0699:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
./Makefile.in\0699:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
./Makefile.am\05:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
```

While THUNARX_DIRECTORY is defined in Makefile:

```
AM_CPPFLAGS = \
	-I$(top_srcdir)							\
	-DG_LOG_DOMAIN=\"thunarx\"					\
	-DTHUNARX_COMPILATION						\
	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
	$(PLATFORM_CPPFLAGS)
```

So, I think we should deal with this like xfce-panel-plugins.patch:

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/patches/xfce4-panel-plugins.patch

[bug#53008] Re: Re: bug#53008: [PATCH 0/3] Add plugins to Thunar

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

I do a hack in my own config like below: seem to work when install plugin in system configure :-)



```
(define-public thunar-geeguix
  (package
    (inherit thunar)
    (arguments
     (list
      #:phases
      #~(modify-phases %standard-phases
          (add-after 'unpack 'fix-thunarx-directory
            (lambda _
              (substitute* "thunarx/Makefile.in"
                (("THUNARX_DIRECTORY=.*")
                 (string-append "THUNARX_DIRECTORY="
                                "\\\"/run/current-system/profile/lib/thunarx-3\\\" \\\n"))))))))))

```





















At 2022-03-14 07:57:13, "tumashu" <tumashu@163.com> wrote:
>I think it is controled by:  THUNARX_DIRECTORY.
>
>```
>./thunarx-provider-factory.c\0158:  dp = g_dir_open (THUNARX_DIRECTORY, 0, NULL);
>./thunarx-provider-module.c\0180:  path = g_build_filename (THUNARX_DIRECTORY, type_module->name, NULL);
>./Makefile\0699:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>./Makefile.in\0699:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>./Makefile.am\05:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>```
>
>While THUNARX_DIRECTORY is defined in Makefile:
>
>```
>AM_CPPFLAGS = \
>	-I$(top_srcdir)							\
>	-DG_LOG_DOMAIN=\"thunarx\"					\
>	-DTHUNARX_COMPILATION						\
>	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>	$(PLATFORM_CPPFLAGS)
>```
>
>So, I think we should deal with this like xfce-panel-plugins.patch:
>
>https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/patches/xfce4-panel-plugins.patch

[-- Attachment #2: Type: text/html, Size: 2687 bytes --]

[bug#53008] Re:Re: Re: bug#53008: [PATCH 0/3] Add plugins to Thunar

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]

I have added a issue to xfce:


https://gitlab.xfce.org/xfce/thunar/-/issues/748

















At 2022-03-15 09:14:15, "tumashu" <tumashu@163.com> wrote:

I do a hack in my own config like below: seem to work when install plugin in system configure :-)



```
(define-public thunar-geeguix
  (package
    (inherit thunar)
    (arguments
     (list
      #:phases
      #~(modify-phases %standard-phases
          (add-after 'unpack 'fix-thunarx-directory
            (lambda _
              (substitute* "thunarx/Makefile.in"
                (("THUNARX_DIRECTORY=.*")
                 (string-append "THUNARX_DIRECTORY="
                                "\\\"/run/current-system/profile/lib/thunarx-3\\\" \\\n"))))))))))

```





















At 2022-03-14 07:57:13, "tumashu" <tumashu@163.com> wrote:
>I think it is controled by:  THUNARX_DIRECTORY.
>
>```
>./thunarx-provider-factory.c\0158:  dp = g_dir_open (THUNARX_DIRECTORY, 0, NULL);
>./thunarx-provider-module.c\0180:  path = g_build_filename (THUNARX_DIRECTORY, type_module->name, NULL);
>./Makefile\0699:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>./Makefile.in\0699:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>./Makefile.am\05:	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>```
>
>While THUNARX_DIRECTORY is defined in Makefile:
>
>```
>AM_CPPFLAGS = \
>	-I$(top_srcdir)							\
>	-DG_LOG_DOMAIN=\"thunarx\"					\
>	-DTHUNARX_COMPILATION						\
>	-DTHUNARX_DIRECTORY=\"$(libdir)/thunarx-$(THUNARX_VERSION_API)\"	\
>	$(PLATFORM_CPPFLAGS)
>```
>
>So, I think we should deal with this like xfce-panel-plugins.patch:
>
>https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/patches/xfce4-panel-plugins.patch

[-- Attachment #2: Type: text/html, Size: 3347 bytes --]

bug#53008: [PATCH 0/3] Add plugins to Thunar

[宋文武 via Guix-patches via]

Simon Streit <simon@netpanic.org> writes:

> Hello,
>
> I've been trying to package some plugins for Thunar.  Unfortunately these
> plugins are not loaded, or are not found in Thunar, and so far I can't see
> why.  There are no errors to begin with.  A guess would be missing path
> declarations from, maybe, pkg-config.  Though the libs are residing in
> ../lib/thunarx-3, where they should be.
>
> I'd be very happy if someone else wants to have a look at these patches
> to see if they can be made workable.
>
>
> Thank you!
> Simon


Hello, sorry for the delay..  I applied the thunarx-python patch now, as
other was already added, and it works!

Closing, thanks!