From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Diego Nicola Barbato <dnbarbato@posteo.de>, 51863@debbugs.gnu.org
Cc: Mark H Weaver <mhw@netris.org>, Leo Famulari <leo@famulari.name>
Subject: [bug#51863] [PATCH] gnu: webkitgtk: Really disable SSE2 on i686-linux.
Date: Mon, 15 Nov 2021 20:29:33 +0100 [thread overview]
Message-ID: <26974778c8ed5f0b9796e26d60caf4fa8f223335.camel@gmail.com> (raw)
In-Reply-To: <87a6i5fyi4.fsf@GlaDOS.home>
Hi Diego,
Am Montag, den 15.11.2021, 11:29 +0000 schrieb Diego Nicola Barbato:
> Hey Guix,
>
> Commit d82fd7c2dd542693988f61fb15c020e3209ac7ec (gnu: webkitgtk:
> Disable SSE2 when not on x86_64.) on master breaks webkitgtk on i686-
> linux.
No, it does not. It merely fails to fix it ;)
> (I'm Cc-ing Leo, Liliana, and Mark since you were all involved in
> upgrading webkitgtk to 2.34.1.)
>
> The offending patch attempts to disable SSE2 by conditionally adding
> a phase which removes the call to 'CHECK_FOR_SSE2' from the end of
> 'Source/cmake/DetectSSE2.cmake'. This phase doesn't do anything
> about 'SSE2_SUPPORT_FOUND' being set to 'FALSE' at line 34 in the
> same file, which causes the following snippet starting at line 152 in
> 'Source/cmake/WebKitCompilerFlags.cmake'
>
> --8<---------------cut here---------------start------------->8---
> # Force SSE2 fp on x86 builds.
> if (WTF_CPU_X86 AND NOT CMAKE_CROSSCOMPILING)
> WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-msse2 -mfpmath=sse)
> include(DetectSSE2)
> if (NOT SSE2_SUPPORT_FOUND)
> message(FATAL_ERROR "SSE2 support is required to compile
> WebKit")
> endif ()
> endif ()
> --8<---------------cut here---------------end--------------->8---
>
> to fail with the following error when building for i686.
>
> --8<---------------cut here---------------start------------->8---
> CMake Error at Source/cmake/WebKitCompilerFlags.cmake:157 (message):
> SSE2 support is required to compile WebKit
> --8<---------------cut here---------------end--------------->8---
>
> The attached patch removes the code for adding the broken 'disable-
> sse2' phase. Instead it disables SSE2 using a patch from Debian and
> by setting 'CFLAGS' and 'CXXFLAGS' to '-march=i686' in the
> 'prepare-build-environment' phase when building for i686. The latter
> is necessary because clang, unlike gcc, defaults to '-
> march=pentium4', which enables SSE2.
These two things don't require combination though, right? Like one
thing disables the SSE check whereas the other fixes a mostly unrelated
issue, am I correct?
I'd like the comment about the "-march=whatever" thing to be closer to
the setenvs, also if GCC does not require it there ought to be a TODO
or XXX stating that it should be removed on core-updates-frozen.
Otherwise LGTM, cheers!
next prev parent reply other threads:[~2021-11-15 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 11:29 [bug#51863] [PATCH] gnu: webkitgtk: Really disable SSE2 on i686-linux Diego Nicola Barbato
2021-11-15 19:29 ` Liliana Marie Prikler [this message]
2021-11-26 4:15 ` bug#51863: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26974778c8ed5f0b9796e26d60caf4fa8f223335.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=51863@debbugs.gnu.org \
--cc=dnbarbato@posteo.de \
--cc=leo@famulari.name \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).