From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MJEeFki1kmHBNgEAgWs5BA (envelope-from ) for ; Mon, 15 Nov 2021 20:30:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iC7OEUi1kmFlFgAAB5/wlQ (envelope-from ) for ; Mon, 15 Nov 2021 19:30:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F124F134EB for ; Mon, 15 Nov 2021 20:30:15 +0100 (CET) Received: from localhost ([::1]:57188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmhgE-0001tj-UQ for larch@yhetil.org; Mon, 15 Nov 2021 14:30:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmhg2-0001tP-CW for guix-patches@gnu.org; Mon, 15 Nov 2021 14:30:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmhg2-0004UM-4G for guix-patches@gnu.org; Mon, 15 Nov 2021 14:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmhg1-0006s4-Vi for guix-patches@gnu.org; Mon, 15 Nov 2021 14:30:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51863] [PATCH] gnu: webkitgtk: Really disable SSE2 on i686-linux. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Nov 2021 19:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51863 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Diego Nicola Barbato , 51863@debbugs.gnu.org Cc: Mark H Weaver , Leo Famulari Received: via spool by 51863-submit@debbugs.gnu.org id=B51863.163700458426362 (code B ref 51863); Mon, 15 Nov 2021 19:30:01 +0000 Received: (at 51863) by debbugs.gnu.org; 15 Nov 2021 19:29:44 +0000 Received: from localhost ([127.0.0.1]:56208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmhfk-0006r8-7M for submit@debbugs.gnu.org; Mon, 15 Nov 2021 14:29:44 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmhfi-0006qq-0j for 51863@debbugs.gnu.org; Mon, 15 Nov 2021 14:29:42 -0500 Received: by mail-wr1-f68.google.com with SMTP id r8so32738406wra.7 for <51863@debbugs.gnu.org>; Mon, 15 Nov 2021 11:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=oU9kL9oxQQPrBZ3ALEDO1SIc8qKt+NgWBHBJ1NOUPAI=; b=JyCuYI9MuOkC1ddf+gDT33t02tjCoPooKB3MSniQDczC/I0gTuLbehTH+baiA0ZaWz q+cruRUTicAUTFT0Yp8LPTvaIygc/L/ob8Era7PlMTNY3N7vjpnkyl1XRihXKZrtyCSn sMCmtbjoCScxB/lXHIx+zwb7H4+YWrYUN8gd4MO8TfoOVfu1jjXnWrgRNYDN3aB7RxUF bke1D/4xIZVong6tRFDJoLplezTqsEVHAdn7iFYPpB6tFU1cy5DT7drQvCgYQn8tQzBJ dvxqZrmEcE0PDCoAutE4u60uSArlguQUwIi7RXLxNtctGG/IP0yf4gcHmd+1Lq1PjZTd qEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=oU9kL9oxQQPrBZ3ALEDO1SIc8qKt+NgWBHBJ1NOUPAI=; b=a9ytWZ3XCsh74aRZ0tingj8E3nIH+5xVyRV0VlK9P/a34zyZp5HrquisasSf4B4PDK K7ET7ESFH0gPZxtzdHF9ipHY9n/12rHMivJWJF+ortI1nSozotP7IHw2S24n2xM1ASVP hwTMjHOf2sRdZBSkxNOW7Gt6cChC8495O7FHBwR9tDTzXirB2kLpufSly5/QG4cyR0js 5Unqd7fhfmaB/BB5LdGRZflDhEOYuI3JzdvxgkTHHaZUYlddksoNQ04iZxMKu05RgtZI 3iHTXAcZYrwxSVN4/8k0P2BDNYbrz2CjyvP+H9yajAH1IL3lQDb1qAdrjkseSCu/yBSS IzBg== X-Gm-Message-State: AOAM530pVqx5RJWz8nrljoQFWJIquv1Yy+LMxMAjsRK2CVxTeZoMLmmn 5b42Fpb+3Gz4iwSWAhlW/l4= X-Google-Smtp-Source: ABdhPJwC1zFMCEs0FXUZ9z9ju/sKxxkO7jMlHrDxqtUwfM61BSW26G7vel3tWA6jlZLh0qQXkC8pmA== X-Received: by 2002:a5d:4b82:: with SMTP id b2mr1730069wrt.419.1637004575838; Mon, 15 Nov 2021 11:29:35 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 126sm207301wmz.28.2021.11.15.11.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 11:29:35 -0800 (PST) Message-ID: <26974778c8ed5f0b9796e26d60caf4fa8f223335.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 15 Nov 2021 20:29:33 +0100 In-Reply-To: <87a6i5fyi4.fsf@GlaDOS.home> References: <87a6i5fyi4.fsf@GlaDOS.home> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637004616; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oU9kL9oxQQPrBZ3ALEDO1SIc8qKt+NgWBHBJ1NOUPAI=; b=GnYsoVHO7yaP6o0KRgJrTMvGoHaNwjyrA5ZcM/g9eFdg2HXuBAXGYH4fyeO1NQCr3JswLq DGPjMVjadryaCvBu2Ri+5/mH5k+1lmNbktktWJwhB8JjX5a8xVJnALA/UNm8H6w6JcHPc2 T9NjOKrVtinR3ZuGLuF9D9PC153jKptHDjFRpAGwdMpkZoY0QBZS0NkeMtTj/mk+lXESSd EWzzGRAIVmd26mB7Y8gXCQ+NHNgE2sTVQApIXfOfCH5Fcz6FkgdHWmGANyxClrAivRQdhb GegwocwzA8vx7bj5NGY+XAah3wO2uWiyGvRHPAqtJeDuS8dFdmzzVsgRqIf6Zg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637004616; a=rsa-sha256; cv=none; b=cKqMZ4ppaYqc5skVMY4e0SiwaULLco2lbrawrWaaQ9dDw/7iZJsOJPO0M2oKvz2hX26a2m iT9tAHVei1/8nDbX4Xs+FBuPDL9u4+Btz1wTdjSt/WRyV3ShM3jzo09/76s1ZUJR0+85nu O8Nvq1kgHL/nVFt4oyuUksMa3RR7/8wvvBKm4REvm48oK+uyh1txGidMuWrOG+tVyWJXyJ PMQw+PW4d27urKDivDnSqykZRJn39pPOHzvV8FXJQz2nd4z5mI8B1kzhyCZhRnyqCSnIbI aOrgdsQ3qMyv8OVbTK0g33YH6nfpS1iQcHJl2Wo7H37jLMz+dGEDa3W2MbPwtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JyCuYI9M; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JyCuYI9M; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F124F134EB X-Spam-Score: -1.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: 98JJNLtlzibc Hi Diego, Am Montag, den 15.11.2021, 11:29 +0000 schrieb Diego Nicola Barbato: > Hey Guix, > > Commit d82fd7c2dd542693988f61fb15c020e3209ac7ec (gnu: webkitgtk: > Disable SSE2 when not on x86_64.) on master breaks webkitgtk on i686- > linux. No, it does not. It merely fails to fix it ;) > (I'm Cc-ing Leo, Liliana, and Mark since you were all involved in > upgrading webkitgtk to 2.34.1.) > > The offending patch attempts to disable SSE2 by conditionally adding > a phase which removes the call to 'CHECK_FOR_SSE2' from the end of > 'Source/cmake/DetectSSE2.cmake'. This phase doesn't do anything > about 'SSE2_SUPPORT_FOUND' being set to 'FALSE' at line 34 in the > same file, which causes the following snippet starting at line 152 in > 'Source/cmake/WebKitCompilerFlags.cmake' > > --8<---------------cut here---------------start------------->8--- > # Force SSE2 fp on x86 builds. > if (WTF_CPU_X86 AND NOT CMAKE_CROSSCOMPILING) > WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-msse2 -mfpmath=sse) > include(DetectSSE2) > if (NOT SSE2_SUPPORT_FOUND) > message(FATAL_ERROR "SSE2 support is required to compile > WebKit") > endif () > endif () > --8<---------------cut here---------------end--------------->8--- > > to fail with the following error when building for i686. > > --8<---------------cut here---------------start------------->8--- > CMake Error at Source/cmake/WebKitCompilerFlags.cmake:157 (message): > SSE2 support is required to compile WebKit > --8<---------------cut here---------------end--------------->8--- > > The attached patch removes the code for adding the broken 'disable- > sse2' phase. Instead it disables SSE2 using a patch from Debian and > by setting 'CFLAGS' and 'CXXFLAGS' to '-march=i686' in the > 'prepare-build-environment' phase when building for i686. The latter > is necessary because clang, unlike gcc, defaults to '- > march=pentium4', which enables SSE2. These two things don't require combination though, right? Like one thing disables the SSE check whereas the other fixes a mostly unrelated issue, am I correct? I'd like the comment about the "-march=whatever" thing to be closer to the setenvs, also if GCC does not require it there ought to be a TODO or XXX stating that it should be removed on core-updates-frozen. Otherwise LGTM, cheers!