unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64.
@ 2023-05-06 10:50 Christopher Baines
  2023-05-09  2:45 ` burning2007
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Christopher Baines @ 2023-05-06 10:50 UTC (permalink / raw)
  To: 63327

* gnu/packages/java.scm (openjdk9)[arguments]: Add 'patch-for-aarch64 phase to
remove duplicate line in interp_masm_aarch64.hpp.
---
 gnu/packages/java.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 067284017c..166417a73d 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -884,6 +884,18 @@ (define-public openjdk9
 
        #:phases
        (modify-phases %standard-phases
+         ,@(if (target-aarch64?)
+               `((add-after 'unpack 'patch-for-aarch64
+                   (lambda _
+                     (substitute* "hotspot/src/cpu/aarch64/vm/interp_masm_aarch64.hpp"
+                       ;; This line is duplicated, so remove both occurrences,
+                       ;; then add back one occurrence by substituting a
+                       ;; comment that occurs once.
+                       (("using MacroAssembler::call_VM_leaf_base;") "")
+                       (("Interpreter specific version of call_VM_base")
+                        "Interpreter specific version of call_VM_base
+  using MacroAssembler::call_VM_leaf_base;")))))
+               '())
          (add-after 'patch-source-shebangs 'fix-java-shebangs
            (lambda _
              ;; This file was "fixed" by patch-source-shebangs, but it requires

base-commit: 64086a4fa449a9f6d2f835fcdf5498222b309e3a
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64.
  2023-05-06 10:50 [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64 Christopher Baines
@ 2023-05-09  2:45 ` burning2007
  2023-05-09  3:10 ` Anthony
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: burning2007 @ 2023-05-09  2:45 UTC (permalink / raw)
  To: 63327@debbugs.gnu.org

[-- Attachment #1: Type: text/html, Size: 507 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64.
  2023-05-06 10:50 [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64 Christopher Baines
  2023-05-09  2:45 ` burning2007
@ 2023-05-09  3:10 ` Anthony
  2023-05-22 14:50 ` Ludovic Courtès
  2023-07-26 14:00 ` bug#63327: Close Andreas Enge
  3 siblings, 0 replies; 5+ messages in thread
From: Anthony @ 2023-05-09  3:10 UTC (permalink / raw)
  To: 63327; +Cc: burning2007

From: burning2007@ya.ru

Hello!

I've encountered this issue and tested similar solution (patch). It builds successfully. It even allows openjdk@10 to build as well - mine has same build errors as for openjdk@9.

But, on the other hand, it is not sufficient for building jdk@9 itself - please, take a look at https://issues.guix.gnu.org/issue/63069.

P. S. Sorry for attachment in previous message - my email provider does not even have a plain text option in UI.

--
Best regards,

Anthony




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64.
  2023-05-06 10:50 [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64 Christopher Baines
  2023-05-09  2:45 ` burning2007
  2023-05-09  3:10 ` Anthony
@ 2023-05-22 14:50 ` Ludovic Courtès
  2023-07-26 14:00 ` bug#63327: Close Andreas Enge
  3 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2023-05-22 14:50 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 63327

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/packages/java.scm (openjdk9)[arguments]: Add 'patch-for-aarch64 phase to
> remove duplicate line in interp_masm_aarch64.hpp.

I’d say go for it if it fixes the problem.

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#63327: Close
  2023-05-06 10:50 [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64 Christopher Baines
                   ` (2 preceding siblings ...)
  2023-05-22 14:50 ` Ludovic Courtès
@ 2023-07-26 14:00 ` Andreas Enge
  3 siblings, 0 replies; 5+ messages in thread
From: Andreas Enge @ 2023-07-26 14:00 UTC (permalink / raw)
  To: 63327-done

I just ran the patch, and can confirm that it enables the build of openjdk@9
on aarch64. So I have pushed it and am closing this bug.

More discussion at https://issues.guix.gnu.org/issue/63069 .

Andreas





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-07-26 14:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-06 10:50 [bug#63327] [PATCH] gnu: openjdk9: Fix build on aarch64 Christopher Baines
2023-05-09  2:45 ` burning2007
2023-05-09  3:10 ` Anthony
2023-05-22 14:50 ` Ludovic Courtès
2023-07-26 14:00 ` bug#63327: Close Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).