unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#57845] [PATCH] guix: Clarify what CRC is.
@ 2022-09-16  1:29 jgart via Guix-patches via
  2022-09-16  1:33 ` [bug#57845] [PATCH v2] " jgart via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2022-09-16  1:29 UTC (permalink / raw)
  To: 57845; +Cc: Ludovic Court s, jgart

* guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
redundancy check.
[define-module]: Remove empty line.
---
 guix/build/debug-link.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/build/debug-link.scm b/guix/build/debug-link.scm
index 9167737fb3..8fd90d951d 100644
--- a/guix/build/debug-link.scm
+++ b/guix/build/debug-link.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,7 +29,6 @@ (define-module (guix build debug-link)
   #:export (debuglink-crc32
             elf-debuglink
             set-debuglink-crc
-
             graft-debug-links))
 
 ;;; Commentary:
@@ -38,10 +38,10 @@ (define-module (guix build debug-link)
 ;;; create separate debug files (info "(gdb) Separate Debug Files").
 ;;;
 ;;; The main facility of this module is 'graft-debug-links', which allows us
-;;; to update the CRC that appears in '.gnu_debuglink' sections when grafting,
-;;; such that separate debug files remain usable after grafting.  Failing to
-;;; do that, GDB would complain about CRC mismatch---see
-;;; <https://bugs.gnu.org/19973>.
+;;; to update the cyclic redundancy check (CRC) that appears in
+;;; '.gnu_debuglink' sections when grafting, such that separate debug files
+;;; remain usable after grafting.  Failing to do that, GDB would complain
+;;; about CRC mismatch---see <https://issues.guix.gnu.org/19973>.
 ;;;
 ;;; Code:
 
-- 
2.37.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#57845] [PATCH v2] guix: Clarify what CRC is.
  2022-09-16  1:29 [bug#57845] [PATCH] guix: Clarify what CRC is jgart via Guix-patches via
@ 2022-09-16  1:33 ` jgart via Guix-patches via
  2022-09-26 21:11   ` bug#57845: [PATCH] " Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2022-09-16  1:33 UTC (permalink / raw)
  To: 57845; +Cc: Ludovic Court s, jgart

* guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
redundancy check and fix broken link to issue.
[define-module]: Remove empty line.

Forgot to mention in the commit message that I also fixed the broken
link to the issue.

all best,

jgart
---
 guix/build/debug-link.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/guix/build/debug-link.scm b/guix/build/debug-link.scm
index 9167737fb3..8fd90d951d 100644
--- a/guix/build/debug-link.scm
+++ b/guix/build/debug-link.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,7 +29,6 @@ (define-module (guix build debug-link)
   #:export (debuglink-crc32
             elf-debuglink
             set-debuglink-crc
-
             graft-debug-links))
 
 ;;; Commentary:
@@ -38,10 +38,10 @@ (define-module (guix build debug-link)
 ;;; create separate debug files (info "(gdb) Separate Debug Files").
 ;;;
 ;;; The main facility of this module is 'graft-debug-links', which allows us
-;;; to update the CRC that appears in '.gnu_debuglink' sections when grafting,
-;;; such that separate debug files remain usable after grafting.  Failing to
-;;; do that, GDB would complain about CRC mismatch---see
-;;; <https://bugs.gnu.org/19973>.
+;;; to update the cyclic redundancy check (CRC) that appears in
+;;; '.gnu_debuglink' sections when grafting, such that separate debug files
+;;; remain usable after grafting.  Failing to do that, GDB would complain
+;;; about CRC mismatch---see <https://issues.guix.gnu.org/19973>.
 ;;;
 ;;; Code:
 
-- 
2.37.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#57845: [PATCH] guix: Clarify what CRC is.
  2022-09-16  1:33 ` [bug#57845] [PATCH v2] " jgart via Guix-patches via
@ 2022-09-26 21:11   ` Ludovic Courtès
  2022-09-27 16:02     ` [bug#57845] " jgart via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2022-09-26 21:11 UTC (permalink / raw)
  To: jgart; +Cc: 57845-done

Hi,

jgart <jgart@dismail.de> skribis:

> * guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
> redundancy check and fix broken link to issue.
> [define-module]: Remove empty line.
>
> Forgot to mention in the commit message that I also fixed the broken
> link to the issue.
>
> all best,
>
> jgart

Applied, but without the copyright line (expanding those three letters
is not copyrightable) and without the blank line removal (it’s here on
purpose to separate different levels of the interface).

BTW, the original bug URL is not “broken”: the page is just less
pleasant to the eye.  :-)

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#57845] [PATCH] guix: Clarify what CRC is.
  2022-09-26 21:11   ` bug#57845: [PATCH] " Ludovic Courtès
@ 2022-09-27 16:02     ` jgart via Guix-patches via
  0 siblings, 0 replies; 4+ messages in thread
From: jgart via Guix-patches via @ 2022-09-27 16:02 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 57845-done

On Mon, 26 Sep 2022 23:11:35 +0200 Ludovic Courtès <ludo@gnu.org> wrote:

Thanks! No worries

all best,

jgart




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-27 16:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16  1:29 [bug#57845] [PATCH] guix: Clarify what CRC is jgart via Guix-patches via
2022-09-16  1:33 ` [bug#57845] [PATCH v2] " jgart via Guix-patches via
2022-09-26 21:11   ` bug#57845: [PATCH] " Ludovic Courtès
2022-09-27 16:02     ` [bug#57845] " jgart via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).