[bug#57462] [PATCH 00/15] Don't ask to run tests when cross-compiling.

[bug#57462] [PATCH 00/15] Don't ask to run tests when cross-compiling.

[Maxime Devos]

This statisfies the tests-true linter (except for the fennel package).
This does not cause any rebuilds.

Maxime Devos (15):
  gnu: ghc-statistics: Properly enable tests.
  gnu: julia-arrayinterface: Don't ask to run tests when
    cross-compiling.
  gnu: julia-forwarddiff: Don't ask to run tests when cross-compiling.
  gnu: julia-reversediff: Don't ask to run tests when cross-compiling.
  gnu: julia-interpolations: Don't ask to run tests when
    cross-compiling.
  gnu: proot: Don't ask to run tests when cross-compiling.
  gnu: python-fonttools-full: Don't ask to run tests when
    cross-compiling.
  gnu: python-path: Don't ask to run tests when cross-compiling.
  gnu: python-jaraco-functools: Don't ask to run tests when
    cross-compiling.
  gnu: python-pip-run: Don't ask to run tests when cross-compiling.
  gnu: python-jupyter-client: Don't ask to run tests when
    cross-compiling.
  gnu: python-jaraco-context: Don't ask to run tests when
    cross-compiling.
  gnu: ruby-rubocop: Don't ask to run tests when cross-compiling.
  gnu: rust: Don't ask to run tests when cross-compiling.
  gnu: yt-dlp: Don't ask to run tests when cross-compiling.

 gnu/packages/haskell-xyz.scm |  3 ---
 gnu/packages/julia-xyz.scm   | 12 ++++++++----
 gnu/packages/linux.scm       |  6 +++---
 gnu/packages/python-xyz.scm  | 12 ++++++------
 gnu/packages/ruby.scm        |  3 ++-
 gnu/packages/rust.scm        |  2 +-
 gnu/packages/video.scm       |  2 +-
 7 files changed, 21 insertions(+), 19 deletions(-)

-- 
2.37.1

[bug#57462] [PATCH 01/15] gnu: ghc-statistics: Properly enable tests.

[Maxime Devos]

The comment states there are test failures and hence it is implied that the
intent was to disable tests, not enable them, but tests pass and the code
below enabled tests instead of disabling them.

Remove #:tests? #true to satisfy the tests-true linter.

* gnu/packages/haskell-xyz.scm
(ghc-statistics)[arguments]{#:tests?}: Remove.
---
 gnu/packages/haskell-xyz.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index 0ce47e0902..039f4871f2 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -12000,9 +12000,6 @@ (define-public ghc-statistics
         (base32
          "0j9awbg47fzb58k5z2wgkp6a0042j7hqrl1g6lyflrbsfswdp5n4"))))
     (build-system haskell-build-system)
-    (arguments
-     '(;; Two tests fail: "Discrete CDF is OK" and "Quantile is CDF inverse".
-       #:tests? #t))
     (inputs
      (list ghc-aeson
            ghc-async
-- 
2.37.1

[bug#57462] [PATCH 02/15] gnu: julia-arrayinterface: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/julia-xyz.scm
(julia-arrayinterface)[arguments]{#:tests?}: When cross-compiling,
set to #false.
---
 gnu/packages/julia-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
index e5b159245c..a0adde6435 100644
--- a/gnu/packages/julia-xyz.scm
+++ b/gnu/packages/julia-xyz.scm
@@ -165,7 +165,8 @@ (define-public julia-arrayinterface
      ;; Expression: @inferred(ArrayInterface.size(Rnr)) === (StaticInt(4),)
      ;; Evaluated: (static(2),) === (static(4),)
      ;; Disable as stopgap.
-     (list #:tests? (not (target-x86-32?))))
+     (list #:tests? (not (or (%current-target-system)
+                             (target-x86-32?)))))
     (propagated-inputs
      (list julia-ifelse
            julia-requires
-- 
2.37.1

[bug#57462] [PATCH 03/15] gnu: julia-forwarddiff: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/julia-xyz.scm
(julia-forwarddiff)[arguments]{#:tests?}: When cross-compiling,
set to #false.
---
 gnu/packages/julia-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
index a0adde6435..4fa711b808 100644
--- a/gnu/packages/julia-xyz.scm
+++ b/gnu/packages/julia-xyz.scm
@@ -2049,7 +2049,8 @@ (define-public julia-forwarddiff
      ;; Expression: dual_isapprox(FDNUM ^ PRIMAL, exp(PRIMAL * log(FDNUM)))
      ;; ERROR: LoadError: LoadError: There was an error during testing
      ;; Disable as stopgap.
-     (list #:tests? (not (target-x86-32?))))
+     (list #:tests? (not (or (%current-target-system)
+                             (target-x86-32?)))))
     (inputs                             ;required for tests
      (list julia-calculus
            julia-difftests))
-- 
2.37.1

[bug#57462] [PATCH 04/15] gnu: julia-reversediff: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/julia-xyz.scm
(julia-reversediff)[arguments]{#:tests?}: When cross-compiling,
set to #false.
---
 gnu/packages/julia-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
index 4fa711b808..a4b3fe2a66 100644
--- a/gnu/packages/julia-xyz.scm
+++ b/gnu/packages/julia-xyz.scm
@@ -4660,7 +4660,8 @@ (define-public julia-reversediff
      ;; Expression: hash(tr_float, hash(1)) === hash(v_float, hash(1))
      ;; MethodError: no method matching decompose(::ReverseDiff.TrackedReal{Float64, Float64, Nothing})
      ;; Disable as stopgap.
-     (list #:tests? (not (target-x86-32?))))
+     (list #:tests? (not (or (%current-target-system)
+                             (target-x86-32?)))))
     (propagated-inputs
      (list julia-diffresults
            julia-diffrules
-- 
2.37.1

[bug#57462] [PATCH 05/15] gnu: julia-interpolations: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/julia-xyz.scm
(julia-interpolations)[arguments]{#:tests?}: When cross-compiling,
set to #false.
---
 gnu/packages/julia-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
index a4b3fe2a66..6aa185486b 100644
--- a/gnu/packages/julia-xyz.scm
+++ b/gnu/packages/julia-xyz.scm
@@ -2939,7 +2939,8 @@ (define-public julia-interpolations
       ;; Got exception outside of a @test
       ;; OverflowError: 96908232 * 106943408 overflowed for type Int32
       ;; Disable as stopgap.
-      #:tests? (not (target-x86-32?))))
+      #:tests? (not (or (%current-target-system)
+                        (target-x86-32?)))))
     (propagated-inputs
      (list julia-axisalgorithms
            julia-offsetarrays
-- 
2.37.1

[bug#57462] [PATCH 06/15] gnu: proot: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/linux.scm
(proot)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/linux.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 19ba30aa16..4e472de7c7 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -7685,9 +7685,9 @@ (define-public proot
      ;; Disable the test suite on armhf-linux, as there are too many
      ;; failures to keep track of (see for example:
      ;; https://github.com/proot-me/proot/issues/286).
-     `(#:tests? ,(not (string-prefix? "armhf"
-                                      (or (%current-target-system)
-                                          (%current-system))))
+     `(#:tests? ,(not (or (%current-target-system)
+                          (string-prefix? "armhf"
+                                          (or (%current-system)))))
        #:make-flags '("-C" "src")
        #:phases (modify-phases %standard-phases
                   (add-after 'unpack 'patch-sources
-- 
2.37.1

[bug#57462] [PATCH 07/15] gnu: python-fonttools-full: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/python-xyz.scm
(python-fonttools-full)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7f6bbd55be..4019cc0134 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -11193,7 +11193,7 @@ (define-public python-fonttools-full
     (arguments
      (substitute-keyword-arguments (package-arguments python-fonttools)
        ((#:tests? _ #f)
-        #t)
+        (not (%current-target-system)))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases
            (replace 'check
-- 
2.37.1

[bug#57462] [PATCH 08/15] gnu: python-path: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/python-xyz.scm
(python-path)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4019cc0134..7491b7bb41 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -12270,7 +12270,7 @@ (define-public python-path
      (substitute-keyword-arguments
          (package-arguments python-path-bootstrap)
        ((#:tests? _ #f)
-        #t)
+        (not (%current-target-system)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
             (replace 'check
-- 
2.37.1

[bug#57462] [PATCH 09/15] gnu: python-jaraco-functools: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/python-xyz.scm
(python-jaraco-functools)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7491b7bb41..eeb575af93 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -8232,7 +8232,7 @@ (define-public python-jaraco-functools
      (substitute-keyword-arguments
          (package-arguments python-jaraco-functools-bootstrap)
        ((#:tests? _ #f)
-        #t)
+        (not (%current-target-system)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
             (replace 'check
-- 
2.37.1

[bug#57462] [PATCH 10/15] gnu: python-pip-run: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/python-xyz.scm
(python-pip-run)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index eeb575af93..7d74cfdc15 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -12393,7 +12393,7 @@ (define-public python-pip-run
     (arguments
      (substitute-keyword-arguments (package-arguments python-pip-run-bootstrap)
        ((#:tests? _ #f)
-        #t)
+        (not (%current-target-system)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
             (replace 'check
-- 
2.37.1

[bug#57462] [PATCH 11/15] gnu: python-jupyter-client: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/python-xyz.scm
(python-jupyter-client)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7d74cfdc15..89d9fba9df 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -8629,7 +8629,7 @@ (define-public python-jupyter-client
       (arguments
        (substitute-keyword-arguments (package-arguments base)
          ((#:tests? _ #f)
-          #t)
+          (not (%current-target-system)))
          ((#:phases phases #~%standard-phases)
           #~(modify-phases #$phases
               (replace 'check
-- 
2.37.1

[bug#57462] [PATCH 12/15] gnu: python-jaraco-context: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/python-xyz.scm
(python-jaraco-context)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 89d9fba9df..2c9af9d1c0 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -8181,7 +8181,7 @@ (define-public python-jaraco-context
      (substitute-keyword-arguments
          (package-arguments python-jaraco-context-bootstrap)
        ((#:tests? _ #f)
-        #t)
+        (not (%current-target-system)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
             (replace 'check
-- 
2.37.1

[bug#57462] [PATCH 13/15] gnu: ruby-rubocop: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/ruby.scm
(ruby-rubocop)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/ruby.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index c1e3dca807..9fdb6e7fbb 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -7226,7 +7226,8 @@ (define-public ruby-rubocop
     (arguments
      `(#:test-target "default"
        ;; TODO: Figure out why test hangs.
-       #:tests? ,(not (target-riscv64?))
+       #:tests? ,(not (or (%current-target-system)
+                          (target-riscv64?)))
        #:phases
        (modify-phases %standard-phases
          (add-before 'check 'set-home
-- 
2.37.1

[bug#57462] [PATCH 14/15] gnu: rust: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/rust.scm
(rust-1.57)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/rust.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm
index 67dc5cdaf3..5801a00f2b 100644
--- a/gnu/packages/rust.scm
+++ b/gnu/packages/rust.scm
@@ -654,7 +654,7 @@ (define rust-1.57
       (arguments
        (substitute-keyword-arguments (package-arguments base-rust)
          ((#:tests? _ #f)
-          #t)
+          (not (%current-target-system)))
          ((#:phases phases)
           `(modify-phases ,phases
              (add-after 'unpack 'relax-gdb-auto-load-safe-path
-- 
2.37.1

[bug#57462] [PATCH 15/15] gnu: yt-dlp: Don't ask to run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/video.scm
(yt-dlp)[arguments]{#:tests?}: When cross-compiling, set to #false.
---
 gnu/packages/video.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 7f451a8925..f744f04322 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2495,7 +2495,7 @@ (define-public yt-dlp
                                           "completions/zsh/_yt-dlp"))))))
     (arguments
      (substitute-keyword-arguments (package-arguments youtube-dl)
-       ((#:tests? _) #t)
+       ((#:tests? _) (not (%current-target-system)))
        ((#:phases phases)
         `(modify-phases ,phases
            ;; See the comment for the corresponding phase in youtube-dl.
-- 
2.37.1

bug#57462: [PATCH 00/15] Don't ask to run tests when cross-compiling.

[Mathieu Othacehe]

Hello Maxime,

I pushed the series.

Thanks,

Mathieu