unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#49470] [PATCH] gnu: Add python-beautysh.
@ 2021-07-08 20:48 jgart via Guix-patches via
  2021-07-08 20:50 ` jgart via Guix-patches via
  2022-06-22 19:43 ` Maxim Cournoyer
  0 siblings, 2 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2021-07-08 20:48 UTC (permalink / raw)
  To: 49470

Hi Guix,

Here is a patch for python-beautysh, a bash beautifier.

Pypi release does not include tests and github release does not include a setup.py because it is using poetry instead.

What is the current recommended guix packaging practice for python projects that depend on poetry?

all best,

jgart




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#49470] [PATCH] gnu: Add python-beautysh.
  2021-07-08 20:48 [bug#49470] [PATCH] gnu: Add python-beautysh jgart via Guix-patches via
@ 2021-07-08 20:50 ` jgart via Guix-patches via
  2022-06-22 19:43 ` Maxim Cournoyer
  1 sibling, 0 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2021-07-08 20:50 UTC (permalink / raw)
  To: 49470; +Cc: jgart

* gnu/packages/python-xyz.scm (python-beautysh): New variable.
---
 gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 2bb33dbd63..bde6ba851a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -357,6 +357,32 @@ features of the Python's built-in dict.")
 from a docstring rather than the other way around.")
    (license license:mpl2.0)))
 
+(define-public python-beautysh
+  (package
+    (name "python-beautysh")
+    (version "6.1.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "beautysh" version))
+        (sha256
+          (base32
+            "0i6mnxhl3v48fx4hnd2q03rxy3wg6v444kjjjrm61lvshz5llswn"))))
+    (build-system python-build-system)
+    ;; Pypi release does not include tests and github release does not include
+    ;; setup.py.
+    (arguments
+      `(#:tests? #f))
+    (propagated-inputs
+      `(("python-colorama" ,python-colorama)))
+    (home-page
+      "https://github.com/lovesegfault/beautysh")
+    (synopsis "Bash beautifier for the masses")
+    (description "@command{beautysh} beautifies bash scripts.  @command{beautysh}
+can be called from the command line or used as a module.  In tests with large
+Linux system Bash scripts, its error-free score was ~99%.")
+    (license license:expat)))
+
 (define-public python-cachetools
   (package
     (name "python-cachetools")
-- 
2.31.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#49470] [PATCH] gnu: Add python-beautysh.
  2021-07-08 20:48 [bug#49470] [PATCH] gnu: Add python-beautysh jgart via Guix-patches via
  2021-07-08 20:50 ` jgart via Guix-patches via
@ 2022-06-22 19:43 ` Maxim Cournoyer
  2022-06-22 23:54   ` jgart via Guix-patches via
  2022-06-23  4:12   ` jgart via Guix-patches via
  1 sibling, 2 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2022-06-22 19:43 UTC (permalink / raw)
  To: jgart, GNU Debbugs; +Cc: 49470

tags 49470 moreinfo
thanks

Hi jgart,

"jgart" <jgart@dismail.de> writes:

> Hi Guix,
>
> Here is a patch for python-beautysh, a bash beautifier.
>
> Pypi release does not include tests and github release does not
> include a setup.py because it is using poetry instead.
>
> What is the current recommended guix packaging practice for python projects that depend on poetry?

You can use python-pypa-build with python-poetry-core and override the
build and install phases as done in python-isort.

Could you attempt such a build?  That we could run the test suite.

Thanks,

Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#49470] [PATCH] gnu: Add python-beautysh.
  2022-06-22 19:43 ` Maxim Cournoyer
@ 2022-06-22 23:54   ` jgart via Guix-patches via
  2022-06-23  4:12   ` jgart via Guix-patches via
  1 sibling, 0 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2022-06-22 23:54 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: GNU Debbugs, 49470

On Wed, 22 Jun 2022 15:43:41 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Could you attempt such a build?  That we could run the test suite.

Hi Maxim,

What branch should I try that from?

If master, do you know of another example package that does that that I can use as a reference?

thanks,

jgart




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#49470] [PATCH] gnu: Add python-beautysh.
  2022-06-22 19:43 ` Maxim Cournoyer
  2022-06-22 23:54   ` jgart via Guix-patches via
@ 2022-06-23  4:12   ` jgart via Guix-patches via
  1 sibling, 0 replies; 5+ messages in thread
From: jgart via Guix-patches via @ 2022-06-23  4:12 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: GNU Debbugs, 49470

On Wed, 22 Jun 2022 15:43:41 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> build and install phases as done in python-isort.

oops missed that ;() Thanks, will try!




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-23  4:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 20:48 [bug#49470] [PATCH] gnu: Add python-beautysh jgart via Guix-patches via
2021-07-08 20:50 ` jgart via Guix-patches via
2022-06-22 19:43 ` Maxim Cournoyer
2022-06-22 23:54   ` jgart via Guix-patches via
2022-06-23  4:12   ` jgart via Guix-patches via

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).