unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#55715] [PATCH] gnu: ocaml-ctypes: do not override install headers
@ 2022-05-29 20:42 David Arroyo
  2022-06-02  5:54 ` bug#55715: " Julien Lepiller
  0 siblings, 1 reply; 2+ messages in thread
From: David Arroyo @ 2022-05-29 20:42 UTC (permalink / raw)
  To: 55715; +Cc: David Arroyo

Overriding INSTALL_HEADERS in the build prevents the "ocaml_integers.h"
header from being copied from the ocaml-integers package to ocaml-ctypes.
The header's absence breaks all dune-based projects which build cstubs
using the new (ctypes ...) stanza.

* gnu/packages/ocaml.scm:
  [arguments]: remove INSTALL_HEADERS override.
---
 gnu/packages/ocaml.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e6d6bc7a89..c7da5a2106 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -4333,9 +4333,7 @@ (define-public ocaml-ctypes
                "0ilzq9qzvwv9rc08cc9wchsx636zp870i7qvqmbigaa2qb812m0z"))))
    (build-system ocaml-build-system)
    (arguments
-    `(#:make-flags
-      (list (string-append "INSTALL_HEADERS = $(wildcard $($(PROJECT).dir)/*.h)"))
-      #:phases
+    `(#:phases
       (modify-phases %standard-phases
         (add-after 'unpack 'make-writable
           (lambda _
-- 
2.36.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#55715: [PATCH] gnu: ocaml-ctypes: do not override install headers
  2022-05-29 20:42 [bug#55715] [PATCH] gnu: ocaml-ctypes: do not override install headers David Arroyo
@ 2022-06-02  5:54 ` Julien Lepiller
  0 siblings, 0 replies; 2+ messages in thread
From: Julien Lepiller @ 2022-06-02  5:54 UTC (permalink / raw)
  To: David Arroyo; +Cc: 55715-done

Le Sun, 29 May 2022 16:42:34 -0400,
David Arroyo <david@aqwari.net> a écrit :

> * gnu/packages/ocaml.scm:
>   [arguments]: remove INSTALL_HEADERS override.

Pushed to master as 21800bf8b98871c99c0a91d97690be1df07a2659 with a
small change to the commit message. Thanks for the patch and enjoy!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-02  5:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-29 20:42 [bug#55715] [PATCH] gnu: ocaml-ctypes: do not override install headers David Arroyo
2022-06-02  5:54 ` bug#55715: " Julien Lepiller

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).