* [bug#54845] [PATCH] shepherd: Add #:supplementary-groups.
@ 2022-04-10 22:00 Leo Nikkilä
2022-04-12 21:40 ` bug#54845: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Leo Nikkilä @ 2022-04-10 22:00 UTC (permalink / raw)
To: 54845; +Cc: Leo Nikkilä
To support the argument introduced in Shepherd 0.9.0 when defining
container-bound services.
* gnu/build/shepherd.scm (exec-command*)
(make-forkexec-constructor/container): Add '#:supplementary-groups'.
---
gnu/build/shepherd.scm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gnu/build/shepherd.scm b/gnu/build/shepherd.scm
index 0627bac5b9..384faa55f4 100644
--- a/gnu/build/shepherd.scm
+++ b/gnu/build/shepherd.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2017, 2018, 2019, 2020, 2022 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2020 Mathieu Othacehe <othacehe@gnu.org>
+;;; Copyright © 2022 Leo Nikkilä <hello@lnikki.la>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -119,8 +120,9 @@ (define* (read-pid-file/container pid pid-file #:key (max-delay 5))
;; PID is always 1, but that's not what Shepherd needs to know.
pid)))
-(define* (exec-command* command #:key user group log-file pid-file
- directory (environment-variables (environ)))
+(define* (exec-command* command #:key user group (supplementary-groups '())
+ log-file pid-file directory (environment-variables
+ (environ)))
"Like 'exec-command', but first restore signal handles modified by
shepherd (PID 1)."
;; First restore the default handlers.
@@ -135,6 +137,7 @@ (define* (exec-command* command #:key user group log-file pid-file
(exec-command command
#:user user
#:group group
+ #:supplementary-groups supplementary-groups
#:log-file log-file
#:directory directory
#:environment-variables environment-variables))
@@ -146,6 +149,7 @@ (define* (make-forkexec-constructor/container command
(mappings '())
(user #f)
(group #f)
+ (supplementary-groups '())
(log-file #f)
pid-file
(pid-file-timeout 5)
@@ -192,6 +196,8 @@ (define mounts
(exec-command* command
#:user user
#:group group
+ #:supplementary-groups
+ supplementary-groups
#:pid-file pid-file
#:log-file log-file
#:directory directory
--
2.34.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#54845: [PATCH] shepherd: Add #:supplementary-groups.
2022-04-10 22:00 [bug#54845] [PATCH] shepherd: Add #:supplementary-groups Leo Nikkilä
@ 2022-04-12 21:40 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2022-04-12 21:40 UTC (permalink / raw)
To: Leo Nikkilä; +Cc: 54845-done
Hi,
Leo Nikkilä <hello@lnikki.la> skribis:
> To support the argument introduced in Shepherd 0.9.0 when defining
> container-bound services.
>
> * gnu/build/shepherd.scm (exec-command*)
> (make-forkexec-constructor/container): Add '#:supplementary-groups'.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-12 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-10 22:00 [bug#54845] [PATCH] shepherd: Add #:supplementary-groups Leo Nikkilä
2022-04-12 21:40 ` bug#54845: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).