* [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp.
@ 2022-03-30 18:02 Daniel Meißner via Guix-patches via
2022-03-30 18:44 ` Maxime Devos
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Meißner via Guix-patches via @ 2022-03-30 18:02 UTC (permalink / raw)
To: 54641; +Cc: Daniel Meißner
* gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output instead of
%output and $#(package-name this-package) and $#(package-synopsis
this-package) instead of name and synopsis.
---
gnu/packages/wm.scm | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3de760d7a6..d6e27f0677 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -51,6 +51,7 @@
;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
;;; Copyright © 2022 Gabriel Wicki <gabriel@erlikon.ch>
;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -758,22 +759,24 @@ (define-public xmonad-next
(inputs (list ghc-data-default-class ghc-setlocale ghc-x11))
(native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after
- 'install 'install-xsession
- (lambda _
- (let* ((xsessions (string-append %output "/share/xsessions")))
- (mkdir-p xsessions)
- (call-with-output-file
- (string-append xsessions "/xmonad.desktop")
- (lambda (port)
- (format port "~
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'install 'install-xsession
+ (lambda _
+ (let ((xsessions (string-append #$output "/share/xsessions")))
+ (mkdir-p xsessions)
+ (call-with-output-file (string-append xsessions
+ "/xmonad.desktop")
+ (lambda (port)
+ (format port "~
[Desktop Entry]~@
Name=~a~@
Comment=~a~@
Exec=~a/bin/xmonad~@
- Type=Application~%" ,name ,synopsis %output)))))))))
+ Type=Application~%"
+ #$(package-name this-package)
+ #$(package-synopsis this-package)
+ #$output)))))))))
(home-page "https://xmonad.org")
(description
"Xmonad is a tiling window manager for X. Windows are arranged
--
2.34.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp.
2022-03-30 18:02 [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp Daniel Meißner via Guix-patches via
@ 2022-03-30 18:44 ` Maxime Devos
2022-03-30 20:53 ` [bug#54641] [PATCH v2] " Daniel Meißner via Guix-patches via
2022-04-01 7:57 ` [bug#54641] [PATCH v3] " Daniel Meißner via Guix-patches via
2 siblings, 0 replies; 5+ messages in thread
From: Maxime Devos @ 2022-03-30 18:44 UTC (permalink / raw)
To: Daniel Meißner, 54641
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
Daniel Meißner via Guix-patches via schreef op wo 30-03-2022 om 20:02
[+0200]:
> + #$(package-name this-package)
> + #$(package-synopsis this-package)
These can be simplified to
#$name
#$synopsis
No need to use package-name/package-synopsis here.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#54641] [PATCH v2] gnu: xmonad-next: Change #:phases to gexp.
2022-03-30 18:02 [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp Daniel Meißner via Guix-patches via
2022-03-30 18:44 ` Maxime Devos
@ 2022-03-30 20:53 ` Daniel Meißner via Guix-patches via
2022-04-01 7:57 ` [bug#54641] [PATCH v3] " Daniel Meißner via Guix-patches via
2 siblings, 0 replies; 5+ messages in thread
From: Daniel Meißner via Guix-patches via @ 2022-03-30 20:53 UTC (permalink / raw)
To: 54641; +Cc: Daniel Meißner, maximedevos
* gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output instead of
%output and $#(package-name this-package) and $#(package-synopsis
this-package) instead of name and synopsis.
---
gnu/packages/wm.scm | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
Thanks for your suggestions, Maxime.
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3de760d7a6..036665f7f0 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -51,6 +51,7 @@
;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
;;; Copyright © 2022 Gabriel Wicki <gabriel@erlikon.ch>
;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -758,22 +759,21 @@ (define-public xmonad-next
(inputs (list ghc-data-default-class ghc-setlocale ghc-x11))
(native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after
- 'install 'install-xsession
- (lambda _
- (let* ((xsessions (string-append %output "/share/xsessions")))
- (mkdir-p xsessions)
- (call-with-output-file
- (string-append xsessions "/xmonad.desktop")
- (lambda (port)
- (format port "~
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'install 'install-xsession
+ (lambda _
+ (let ((xsessions (string-append #$output "/share/xsessions")))
+ (mkdir-p xsessions)
+ (call-with-output-file (string-append xsessions
+ "/xmonad.desktop")
+ (lambda (port)
+ (format port "~
[Desktop Entry]~@
Name=~a~@
Comment=~a~@
Exec=~a/bin/xmonad~@
- Type=Application~%" ,name ,synopsis %output)))))))))
+ Type=Application~%" #$name #$synopsis #$output)))))))))
(home-page "https://xmonad.org")
(description
"Xmonad is a tiling window manager for X. Windows are arranged
--
2.34.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#54641] [PATCH v3] gnu: xmonad-next: Change #:phases to gexp.
2022-03-30 18:02 [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp Daniel Meißner via Guix-patches via
2022-03-30 18:44 ` Maxime Devos
2022-03-30 20:53 ` [bug#54641] [PATCH v2] " Daniel Meißner via Guix-patches via
@ 2022-04-01 7:57 ` Daniel Meißner via Guix-patches via
2022-04-05 12:10 ` bug#54641: [PATCH] " Ludovic Courtès
2 siblings, 1 reply; 5+ messages in thread
From: Daniel Meißner via Guix-patches via @ 2022-04-01 7:57 UTC (permalink / raw)
To: 54641; +Cc: Daniel Meißner, Maxime Devos
* gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output, #$name
and #$synopsis instead of %output, name and synopsis.
---
gnu/packages/wm.scm | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
Sorry, I missed to change the commit message also. This one should be
alright.
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 3de760d7a6..036665f7f0 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -51,6 +51,7 @@
;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
;;; Copyright © 2022 Gabriel Wicki <gabriel@erlikon.ch>
;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -758,22 +759,21 @@ (define-public xmonad-next
(inputs (list ghc-data-default-class ghc-setlocale ghc-x11))
(native-inputs (list ghc-quickcheck ghc-quickcheck-classes))
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after
- 'install 'install-xsession
- (lambda _
- (let* ((xsessions (string-append %output "/share/xsessions")))
- (mkdir-p xsessions)
- (call-with-output-file
- (string-append xsessions "/xmonad.desktop")
- (lambda (port)
- (format port "~
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'install 'install-xsession
+ (lambda _
+ (let ((xsessions (string-append #$output "/share/xsessions")))
+ (mkdir-p xsessions)
+ (call-with-output-file (string-append xsessions
+ "/xmonad.desktop")
+ (lambda (port)
+ (format port "~
[Desktop Entry]~@
Name=~a~@
Comment=~a~@
Exec=~a/bin/xmonad~@
- Type=Application~%" ,name ,synopsis %output)))))))))
+ Type=Application~%" #$name #$synopsis #$output)))))))))
(home-page "https://xmonad.org")
(description
"Xmonad is a tiling window manager for X. Windows are arranged
--
2.34.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#54641: [PATCH] gnu: xmonad-next: Change #:phases to gexp.
2022-04-01 7:57 ` [bug#54641] [PATCH v3] " Daniel Meißner via Guix-patches via
@ 2022-04-05 12:10 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2022-04-05 12:10 UTC (permalink / raw)
To: Daniel Meißner; +Cc: Maxime Devos, 54641-done
Hi,
Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de> skribis:
> * gnu/packages/wm.scm (xmonad-next)[arguments]: Use #$output, #$name
> and #$synopsis instead of %output, name and synopsis.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-05 12:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30 18:02 [bug#54641] [PATCH] gnu: xmonad-next: Change #:phases to gexp Daniel Meißner via Guix-patches via
2022-03-30 18:44 ` Maxime Devos
2022-03-30 20:53 ` [bug#54641] [PATCH v2] " Daniel Meißner via Guix-patches via
2022-04-01 7:57 ` [bug#54641] [PATCH v3] " Daniel Meißner via Guix-patches via
2022-04-05 12:10 ` bug#54641: [PATCH] " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).