[bug#53336] [PATCH] qbittorent: Bump 4.2.5 -> 4.4.0

[bug#53336] [PATCH] qbittorent: Bump 4.2.5 -> 4.4.0

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
---
 gnu/packages/bittorrent.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index fa88c91163..ddcfda17f5 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -466,7 +466,7 @@ (define-public libtorrent-rasterbar
 (define-public qbittorrent
   (package
     (name "qbittorrent")
-    (version "4.2.5")
+    (version "4.4.0")
     (source
      (origin
        (method git-fetch)
@@ -475,7 +475,7 @@ (define-public qbittorrent
              (commit (string-append "release-" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1n613ylg6i9gisgk0dbr2kpfasyizrkdjff1r8smd4vri2qrdksn"))))
+        (base32 "0aqrcwxi3s2alila3fa7fjs4hifkq7055wa4xvz17hajchs3l567"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
--
2.34.0


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

[bug#53336] [PATCH] qbittorent: Bump 4.2.5 -> 4.4.0

[Maxime Devos]

[-- Attachment #1.1: Type: text/plain, Size: 437 bytes --]

Jacob Hrbek schreef op di 18-01-2022 om 03:28 [+0000]:
> Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>

FWIW, this isn't what ‘Signed-off-by’ means in Guix.  From ‘17.8.2
Commit policy’:

When pushing a commit on behalf of somebody else, please add a
‘Signed-off-by’ line at the end of the commit log message—e.g., with
‘git am --signoff’. This improves tracking of who did what.

Greetings,
Maxime.

[-- Attachment #1.2: Type: text/html, Size: 828 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#53336] [PATCH] qbittorent: Bump 4.2.5 -> 4.4.0

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

[Please keep debbugs in CC or To]

Jacob Hrbek schreef op wo 19-01-2022 om 09:49 [+0000]:
> I don't have commit access so it's projected to be merged by
> privileged developer on my behalf thus the signed-off-by line so that
> i am not held liable (i am aware that GPLv3 has no liability clause)
> for the changes as GNU Guix lacks sufficient QA for the changes imho.

That's neither what that line means in Guix and neither what it means
in Linux (*) (the project that introduced the original Signed-off-by
IIUC), so I don't see where you got this interpretation about Signed-
off-by and liability from.

(*) See Documentation/process/submitting-patches.rst

In fact, Signed-off-by indicates a measure of ‘approval’ (in Guix
quite a bit more than in Linux IIUC) -- it's not explicitly spelled
out, but Linux' and Guix' contributing documentation seems too imply
this to some degree.

As such, assuming ‘Signed-off-by’ impacts liability somehow,
I would find it more likely that it would increase the chance
of being held liable than decreasing the chance of being held
liable.  Or maybe the inverse holds, who knows, I don't know
how liability and responsibility works legally.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#53336] [PATCH] qbittorrent: Bump 4.2.5 -> 4.4.0

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 2129 bytes --]

---
 gnu/packages/bittorrent.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index fa88c91163..dc2e192c2b 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -466,7 +466,7 @@ (define-public libtorrent-rasterbar
 (define-public qbittorrent
   (package
     (name "qbittorrent")
-    (version "4.2.5")
+    (version "4.4.0")
     (source
      (origin
        (method git-fetch)
@@ -475,7 +475,7 @@ (define-public qbittorrent
              (commit (string-append "release-" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1n613ylg6i9gisgk0dbr2kpfasyizrkdjff1r8smd4vri2qrdksn"))))
+        (base32 "0aqrcwxi3s2alila3fa7fjs4hifkq7055wa4xvz17hajchs3l567"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
@@ -491,6 +491,13 @@ (define-public qbittorrent

   (guix build qt-utils))
        #:phases
        (modify-phases %standard-phases
+         ;; The package is checking for a `python` or `python3` executable in an environment variable `PATH` which causes the search engine to fail with "Missing Python Runtime" this phase substitutes the python executables with full path in the nix store executable -- https://issues.guix.gnu.org/53334
+	 ;; FIXME-QA(Krey): This codeblock depends on upstream's declaration of https://github.com/qbittorrent/qBittorrent/blob/master/src/base/utils/foreignapps.cpp#L277, if the file declaration changes then this phase will be malfunction -> Consider optimizing the upstream code for nix userland
+	 (add-after 'unpack 'python-path-compat
+           (lambda* (#:key inputs #:allow-other-keys)
+	     (substitute* "src/base/utils/foreignapps.cpp"
+	       (("if \\(testPythonInstallation\\(\"python3\", pyInfo\\)\\)")
+		 (string-append "if (testPythonInstallation(\"" (search-input-file inputs "/bin/python"
) "\", pyInfo))")))))
          (add-after 'install 'wrap-qt
            (lambda* (#:key outputs inputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
--
2.34.0


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

[bug#53336] [PATCH] qbittorrent: Bump 4.2.5 -> 4.4.0

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 2350 bytes --]

submitted patch without signed-off-by

On 1/19/22 12:55, Jacob Hrbek wrote:
> ---
>   gnu/packages/bittorrent.scm | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index fa88c91163..dc2e192c2b 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -466,7 +466,7 @@ (define-public libtorrent-rasterbar
>   (define-public qbittorrent
>     (package
>       (name "qbittorrent")
> -    (version "4.2.5")
> +    (version "4.4.0")
>       (source
>        (origin
>          (method git-fetch)
> @@ -475,7 +475,7 @@ (define-public qbittorrent
>                (commit (string-append "release-" version))))
>          (file-name (git-file-name name version))
>          (sha256
> -        (base32 "1n613ylg6i9gisgk0dbr2kpfasyizrkdjff1r8smd4vri2qrdksn"))))
> +        (base32 "0aqrcwxi3s2alila3fa7fjs4hifkq7055wa4xvz17hajchs3l567"))))
>       (build-system
 gnu-build-system)
>       (arguments
>        `(#:configure-flags
> @@ -491,6 +491,13 @@ (define-public qbittorrent
>                              (guix build qt-utils))
>          #:phases
>          (modify-phases %standard-phases
> +         ;; The package is checking for a `python` or `python3` executable in an environment variable `PATH` which causes the search engine to fail with "Missing Python Runtime" this phase substitutes the python executables with full path in the nix store executable -- https://issues.guix.gnu.org/53334
> +	 ;; FIXME-QA(Krey): This codeblock depends on upstream's declaration of https://github.com/qbittorrent/qBittorrent/blob/master/src/base/utils/foreignapps.cpp#L277, if the file declaration changes then this phase will be malfunction -> Consider optimizing the upstream code for nix userland
> +	 (add-after 'unpack 'python-path-compat
> +           (lambda* (#:key inputs #:allow-other-keys)
> +	     (substitute* "src/base/utils/foreignapps.cpp
"
> +	       (("if \\(testPythonInstallation\\(\"python3\", pyInfo\\)\\)")
> +		 (string-append "if (testPythonInstallation(\"" (search-input-file inputs "/bin/python") "\", pyInfo))")))))
>            (add-after 'install 'wrap-qt
>              (lambda* (#:key outputs inputs #:allow-other-keys)
>                (let ((out (assoc-ref outputs "out")))
> --
> 2.34.0
>
--
Jacob Hrbek


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

[bug#53336] [PATCH] qbittorrent: Bump 4.2.5 -> 4.4.0

[Nicolas Goaziou]

Hello,

Jacob Hrbek <kreyren@rixotstudio.cz> writes:

> submitted patch without signed-off-by

Thank you. However, I'm unable to apply it on top of HEAD. Could you
send it again, with a proper commit message, like the following:

--8<---------------cut here---------------start------------->8---
gnu: qbittorrent: Update to 4.4.0.

* gnu/packages/bittorrent.scm (qbittorrent): Update to 4.4.0.
--8<---------------cut here---------------end--------------->8---

Regards,
-- 
Nicolas Goaziou

[bug#53336] [PATCH] gnu: git-annex: Update to 8.20211231.

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 1077 bytes --]

From: Kyle Meyer <kyle@kyleam.com>

* gnu/packages/haskell-apps.scm (git-annex): Update to 8.20211231.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>
---
 gnu/packages/haskell-apps.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/haskell-apps.scm b/gnu/packages/haskell-apps.scm
index ed977f369f..7f777a0873 100644
--- a/gnu/packages/haskell-apps.scm
+++ b/gnu/packages/haskell-apps.scm
@@ -306,14 +306,14 @@ (define-public ghcid
 (define-public git-annex
   (package
     (name "git-annex")
-    (version "8.20211123")
+    (version "8.20211231")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://hackage.haskell.org/package/"
                            "git-annex/git-annex-" version ".tar.gz"))
        (sha256
-        (base32 "0i9dhh601axv0b1i56yzn6jnfp160z530fp9pd557kpq4nbvg5kl"))))
+        (base32 "0cpa3rl8vcm0arima8x9m5q0a9r05z0851ibr1vcria2z0mmwmi7"))))
     (build-system haskell-build-system)
     (arguments
      `(#:configure-flags
-- 
2.34.0


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

[bug#53336] [PATCH] gnu: qbittorrent: Update to 4.4.0

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 964 bytes --]

* gnu/packages/bittorrent.scm (qbittorrent): Update to 4.4.0
---
 gnu/packages/bittorrent.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index fa88c91163..ddcfda17f5 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -466,7 +466,7 @@ (define-public libtorrent-rasterbar
 (define-public qbittorrent
   (package
     (name "qbittorrent")
-    (version "4.2.5")
+    (version "4.4.0")
     (source
      (origin
        (method git-fetch)
@@ -475,7 +475,7 @@ (define-public qbittorrent
              (commit (string-append "release-" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1n613ylg6i9gisgk0dbr2kpfasyizrkdjff1r8smd4vri2qrdksn"))))
+        (base32 "0aqrcwxi3s2alila3fa7fjs4hifkq7055wa4xvz17hajchs3l567"))))
     (build-system gnu-build-system)
     (arguments
      `(#:configure-flags
--
2.34.0


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

[bug#53336] [PATCH] gnu: qbittorrent: Update to 4.4.0

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

used too many `^`, my bad!

On 1/23/22 14:04, Jacob Hrbek wrote:
> * gnu/packages/bittorrent.scm (qbittorrent): Update to 4.4.0
> ---
>   gnu/packages/bittorrent.scm | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index fa88c91163..ddcfda17f5 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -466,7 +466,7 @@ (define-public libtorrent-rasterbar
>   (define-public qbittorrent
>     (package
>       (name "qbittorrent")
> -    (version "4.2.5")
> +    (version "4.4.0")
>       (source
>        (origin
>          (method git-fetch)
> @@ -475,7 +475,7 @@ (define-public qbittorrent
>                (commit (string-append "release-" version))))
>          (file-name (git-file-name name version))
>          (sha256
> -        (base32 "1n613ylg6i9gisgk0dbr2kpfasyizrkdjff1r8smd4vri2qrdksn"))))
> +        (base32 "0aqrcwxi3s2alila3fa7fjs4hifkq7055wa
4xvz17hajchs3l567"))))
>       (build-system gnu-build-system)
>       (arguments
>        `(#:configure-flags
> --
> 2.34.0
>
--
Jacob Hrbek


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

bug#53336: [PATCH] gnu: qbittorrent: Update to 4.4.0

[Nicolas Goaziou]

Hello,

Jacob Hrbek <kreyren@rixotstudio.cz> writes:

> * gnu/packages/bittorrent.scm (qbittorrent): Update to 4.4.0

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

[bug#53336] [PATCH] gnu: qbittorrent: Update to 4.4.0

[Jacob Hrbek]

[-- Attachment #1.1: Type: text/plain, Size: 245 bytes --]

yay

On 1/23/22 17:43, Nicolas Goaziou wrote:
> Hello,
>
> Jacob Hrbek <kreyren@rixotstudio.cz> writes:
>
>> * gnu/packages/bittorrent.scm (qbittorrent): Update to 4.4.0
> Applied. Thank you.
>
> Regards,
> --
> Nicolas Goaziou

--
Jacob Hrbek


[-- Attachment #1.2: publickey - kreyren@rixotstudio.cz - 1677db82.asc --]
[-- Type: application/pgp-keys, Size: 713 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]