unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Felix Gruber <felgru@posteo.net>
To: 52953@debbugs.gnu.org, Leo Famulari <leo@famulari.name>
Cc: Felix Gruber <felgru@posteo.net>
Subject: [bug#52953] [PATCH v2 0/3] Update openmw to 0.47.0.
Date: Mon,  3 Jan 2022 19:37:20 +0000	[thread overview]
Message-ID: <20220103193720.20388-1-felgru@posteo.net> (raw)
In-Reply-To: <YdJ00oOg3/B/fHwv@jasmine.lan>

Hi Leo,

here's the updated patchset incorporating your remarks.

On 1/3/22 4:59 AM, Leo Famulari wrote:
> On Sun, Jan 02, 2022 at 04:02:48PM +0000, Felix Gruber wrote:
>> +      (synopsis "navigation system for games")
> 
> The linter should warn that the "synopsis should start with an
> upper-case letter or digit".

You're right, I should definitely make a habbit of running guix lint
before sending my patches!

>> * gnu/packages/game-development.scm (bullet-double-precision): New
>>   variable.
> 
> I'm curious, did you try making this change in the 'bullet' package
> itself, and then rebuilding the packages that depend on it? It would be
> nice to avoid making another package variant if it's not necessary.

I've incorporated the double precision configure flag in the bullet
package now, and all its dependent packages still seem to build
correctly.

Felix Gruber (3):
  gnu: Add recastnavigation.
  gnu: bullet: Build with double precision arithmetics.
  gnu: openmw: Update to 0.47.0.

 gnu/packages/game-development.scm | 82 ++++++++++++++++++++++++++-----
 1 file changed, 70 insertions(+), 12 deletions(-)

-- 
2.30.2





  reply	other threads:[~2022-01-03 19:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-02 16:01 [bug#52953] [PATCH 0/3] Update openmw to 0.47.0 Felix Gruber
2022-01-02 16:02 ` [bug#52953] [PATCH 1/3] gnu: Add recastnavigation Felix Gruber
2022-01-03  3:59   ` Leo Famulari
2022-01-02 16:02 ` [bug#52953] [PATCH 2/3] gnu: Add bullet-double-precision Felix Gruber
2022-01-03  3:59   ` Leo Famulari
2022-01-02 16:02 ` [bug#52953] [PATCH 3/3] gnu: openmw: Update to 0.47.0 Felix Gruber
2022-01-03  4:00   ` Leo Famulari
2022-01-03 19:37     ` Felix Gruber [this message]
2022-01-03 19:38       ` [bug#52953] [PATCH v2 1/3] gnu: Add recastnavigation Felix Gruber
2022-01-03 19:38       ` [bug#52953] [PATCH v2 2/3] gnu: bullet: Build with double precision arithmetics Felix Gruber
2022-01-03 19:38       ` [bug#52953] [PATCH v2 3/3] gnu: openmw: Update to 0.47.0 Felix Gruber
2022-01-03 20:14       ` bug#52953: [PATCH v2 0/3] Update openmw " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220103193720.20388-1-felgru@posteo.net \
    --to=felgru@posteo.net \
    --cc=52953@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).