unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#52171] [PATCH core-updates-frozen 1/2] gnu: darktable: Build with libsoup 2.
@ 2021-11-28 23:48 Vinicius Monego
  2021-11-28 23:51 ` [bug#52171] [PATCH core-updates-frozen 2/2] gnu: darktable: Build with OpenEXR 3 Vinicius Monego
  2021-11-29  0:04 ` [bug#52171] [PATCH core-updates-frozen v2 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
  0 siblings, 2 replies; 5+ messages in thread
From: Vinicius Monego @ 2021-11-28 23:48 UTC (permalink / raw)
  To: 52171; +Cc: Vinicius Monego

* gnu/packages/photo.scm (darktable)[inputs]: Change libsoup to
libsoup-minimal-2.
---
 gnu/packages/photo.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index da15126af4..8a07f32f3c 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -562,7 +562,7 @@ photographic equipment.")
        ("libpng" ,libpng)
        ("librsvg" ,librsvg)
        ("libsecret" ,libsecret) ;optional, for storing passwords
-       ("libsoup" ,libsoup)
+       ("libsoup" ,libsoup-minimal-2)
        ("libtiff" ,libtiff)
        ("libwebp" ,libwebp) ;optional, for WebP support
        ("libxml2" ,libxml2)

base-commit: e765ad091d861c99eae9fdd402214a2e2e90ed4d
-- 
2.30.2





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#52171] [PATCH core-updates-frozen 2/2] gnu: darktable: Build with OpenEXR 3.
  2021-11-28 23:48 [bug#52171] [PATCH core-updates-frozen 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
@ 2021-11-28 23:51 ` Vinicius Monego
  2021-11-29  0:04 ` [bug#52171] [PATCH core-updates-frozen v2 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
  1 sibling, 0 replies; 5+ messages in thread
From: Vinicius Monego @ 2021-11-28 23:51 UTC (permalink / raw)
  To: 52171; +Cc: Vinicius Monego

* gnu/packages/photo.scm (darktable)[arguments]<#:phases>: Rename
'set-LDFLAGS-and-CPATH to 'set-LDFLAGS. Don't set CPATH.
[inputs]: Remove ilmbase. Add imath. Change openxr-2 to openexr.
---
 gnu/packages/photo.scm | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index 8a07f32f3c..9b60ec2884 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -504,18 +504,12 @@ photographic equipment.")
              (substitute* "CMakeLists.txt"
                (("\\$\\{LLVM_INSTALL_PREFIX\\}")
                 (assoc-ref %build-inputs "clang")))))
-         (add-before 'configure 'set-LDFLAGS-and-CPATH
+         (add-before 'configure 'set-LDFLAGS
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (setenv "LDFLAGS"
                      (string-append
                       "-Wl,-rpath="
-                      (assoc-ref outputs "out") "/lib/darktable"))
-
-             ;; Ensure the OpenEXR headers are found.
-             (setenv "CPATH"
-                     (string-append
-                      (search-input-directory inputs "include/OpenEXR")
-                      ":" (or (getenv "CPATH") "")))))
+                      (assoc-ref outputs "out") "/lib/darktable"))))
          (add-after 'install 'wrap-program
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (wrap-program (string-append (assoc-ref outputs "out")
@@ -550,7 +544,7 @@ photographic equipment.")
        ("graphicsmagick" ,graphicsmagick)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
-       ("ilmbase" ,ilmbase)
+       ("imath" ,imath)
        ("iso-codes" ,iso-codes) ;optional, for language names in the preferences
        ("json-glib" ,json-glib)
        ("lcms" ,lcms)
@@ -569,7 +563,7 @@ photographic equipment.")
        ("libxslt" ,libxslt)
        ("lua" ,lua) ;optional, for plugins
        ("opencl-icd-loader" ,opencl-icd-loader) ;optional, for OpenCL support
-       ("openexr" ,openexr-2) ;optional, for EXR import/export
+       ("openexr" ,openexr) ;optional, for EXR import/export
        ("openjpeg" ,openjpeg) ;optional, for JPEG2000 export
        ("osm-gps-map" ,osm-gps-map) ;optional, for geotagging view
        ("pugixml" ,pugixml)
-- 
2.30.2





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#52171] [PATCH core-updates-frozen v2 1/2] gnu: darktable: Build with libsoup 2.
  2021-11-28 23:48 [bug#52171] [PATCH core-updates-frozen 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
  2021-11-28 23:51 ` [bug#52171] [PATCH core-updates-frozen 2/2] gnu: darktable: Build with OpenEXR 3 Vinicius Monego
@ 2021-11-29  0:04 ` Vinicius Monego
  2021-11-29  0:04   ` [bug#52171] [PATCH core-updates-frozen v2 2/2] gnu: darktable: Build with OpenEXR 3 Vinicius Monego
  1 sibling, 1 reply; 5+ messages in thread
From: Vinicius Monego @ 2021-11-29  0:04 UTC (permalink / raw)
  To: 52171; +Cc: Vinicius Monego

* gnu/packages/photo.scm (darktable)[inputs]: Change libsoup to
libsoup-minimal-2.
---
 gnu/packages/photo.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index da15126af4..8a07f32f3c 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -562,7 +562,7 @@ photographic equipment.")
        ("libpng" ,libpng)
        ("librsvg" ,librsvg)
        ("libsecret" ,libsecret) ;optional, for storing passwords
-       ("libsoup" ,libsoup)
+       ("libsoup" ,libsoup-minimal-2)
        ("libtiff" ,libtiff)
        ("libwebp" ,libwebp) ;optional, for WebP support
        ("libxml2" ,libxml2)

base-commit: e765ad091d861c99eae9fdd402214a2e2e90ed4d
-- 
2.30.2





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#52171] [PATCH core-updates-frozen v2 2/2] gnu: darktable: Build with OpenEXR 3.
  2021-11-29  0:04 ` [bug#52171] [PATCH core-updates-frozen v2 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
@ 2021-11-29  0:04   ` Vinicius Monego
  2021-11-29  2:54     ` bug#52171: " Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Vinicius Monego @ 2021-11-29  0:04 UTC (permalink / raw)
  To: 52171; +Cc: Vinicius Monego

* gnu/packages/photo.scm (darktable)[arguments]<#:phases>: Rename
'set-LDFLAGS-and-CPATH to 'set-LDFLAGS. Don't set CPATH.
[inputs]: Remove ilmbase. Add imath. Replace openxr-2 with openexr.
---
Removed now unused 'inputs' from the lambda. It would be good if someone could test the OpenEXR export because the button doesn't fit in my screen for me to try.

 gnu/packages/photo.scm | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index 8a07f32f3c..34d9cc3dd0 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -504,18 +504,12 @@ photographic equipment.")
              (substitute* "CMakeLists.txt"
                (("\\$\\{LLVM_INSTALL_PREFIX\\}")
                 (assoc-ref %build-inputs "clang")))))
-         (add-before 'configure 'set-LDFLAGS-and-CPATH
-           (lambda* (#:key inputs outputs #:allow-other-keys)
+         (add-before 'configure 'set-LDFLAGS
+           (lambda* (#:key outputs #:allow-other-keys)
              (setenv "LDFLAGS"
                      (string-append
                       "-Wl,-rpath="
-                      (assoc-ref outputs "out") "/lib/darktable"))
-
-             ;; Ensure the OpenEXR headers are found.
-             (setenv "CPATH"
-                     (string-append
-                      (search-input-directory inputs "include/OpenEXR")
-                      ":" (or (getenv "CPATH") "")))))
+                      (assoc-ref outputs "out") "/lib/darktable"))))
          (add-after 'install 'wrap-program
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (wrap-program (string-append (assoc-ref outputs "out")
@@ -550,7 +544,7 @@ photographic equipment.")
        ("graphicsmagick" ,graphicsmagick)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
-       ("ilmbase" ,ilmbase)
+       ("imath" ,imath)
        ("iso-codes" ,iso-codes) ;optional, for language names in the preferences
        ("json-glib" ,json-glib)
        ("lcms" ,lcms)
@@ -569,7 +563,7 @@ photographic equipment.")
        ("libxslt" ,libxslt)
        ("lua" ,lua) ;optional, for plugins
        ("opencl-icd-loader" ,opencl-icd-loader) ;optional, for OpenCL support
-       ("openexr" ,openexr-2) ;optional, for EXR import/export
+       ("openexr" ,openexr) ;optional, for EXR import/export
        ("openjpeg" ,openjpeg) ;optional, for JPEG2000 export
        ("osm-gps-map" ,osm-gps-map) ;optional, for geotagging view
        ("pugixml" ,pugixml)
-- 
2.30.2





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#52171: [PATCH core-updates-frozen v2 2/2] gnu: darktable: Build with OpenEXR 3.
  2021-11-29  0:04   ` [bug#52171] [PATCH core-updates-frozen v2 2/2] gnu: darktable: Build with OpenEXR 3 Vinicius Monego
@ 2021-11-29  2:54     ` Leo Famulari
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2021-11-29  2:54 UTC (permalink / raw)
  To: Vinicius Monego; +Cc: 52171-done

On Mon, Nov 29, 2021 at 12:04:21AM +0000, Vinicius Monego wrote:
> * gnu/packages/photo.scm (darktable)[arguments]<#:phases>: Rename
> 'set-LDFLAGS-and-CPATH to 'set-LDFLAGS. Don't set CPATH.
> [inputs]: Remove ilmbase. Add imath. Replace openxr-2 with openexr.

Thanks! Pushed as 3d54f2415672aed64661bed84a043a7f0cee13dd

> Removed now unused 'inputs' from the lambda. It would be good if someone could test the OpenEXR export because the button doesn't fit in my screen for me to try.

It does successfully export EXR files




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-29  2:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-28 23:48 [bug#52171] [PATCH core-updates-frozen 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
2021-11-28 23:51 ` [bug#52171] [PATCH core-updates-frozen 2/2] gnu: darktable: Build with OpenEXR 3 Vinicius Monego
2021-11-29  0:04 ` [bug#52171] [PATCH core-updates-frozen v2 1/2] gnu: darktable: Build with libsoup 2 Vinicius Monego
2021-11-29  0:04   ` [bug#52171] [PATCH core-updates-frozen v2 2/2] gnu: darktable: Build with OpenEXR 3 Vinicius Monego
2021-11-29  2:54     ` bug#52171: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).