unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#49364] [PATCH 0/2] Use log file for tor and ntp services
@ 2021-07-03 20:35 Brice Waegeneire
  2021-07-03 20:37 ` [bug#49364] [PATCH 1/2] services: tor: Log to file Brice Waegeneire
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Brice Waegeneire @ 2021-07-03 20:35 UTC (permalink / raw)
  To: 49364


Brice Waegeneire (2):
  services: tor: Log to file.
  services: ntp: Log to file.

 gnu/services/networking.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.31.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#49364] [PATCH 1/2] services: tor: Log to file.
  2021-07-03 20:35 [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Brice Waegeneire
@ 2021-07-03 20:37 ` Brice Waegeneire
  2021-07-03 20:37 ` [bug#49364] [PATCH 2/2] services: ntp: " Brice Waegeneire
  2021-07-07 14:39 ` [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Mathieu Othacehe
  2 siblings, 0 replies; 5+ messages in thread
From: Brice Waegeneire @ 2021-07-03 20:37 UTC (permalink / raw)
  To: 49364

* gnu/services/networking.scm (tor-shepherd-service)[start]: Specify log
file.
---
 gnu/services/networking.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 1ae58041d3..0be4a21e7a 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -960,6 +960,7 @@ HiddenServicePort ~a ~a~%"
                 (start #~(make-forkexec-constructor/container
                           (list #$(file-append tor "/bin/tor") "-f" #$torrc)
 
+                          #:log-file "/var/log/tor.log"
                           #:mappings (list (file-system-mapping
                                             (source "/var/lib/tor")
                                             (target source)
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#49364] [PATCH 2/2] services: ntp: Log to file.
  2021-07-03 20:35 [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Brice Waegeneire
  2021-07-03 20:37 ` [bug#49364] [PATCH 1/2] services: tor: Log to file Brice Waegeneire
@ 2021-07-03 20:37 ` Brice Waegeneire
  2021-07-07 14:39 ` [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Mathieu Othacehe
  2 siblings, 0 replies; 5+ messages in thread
From: Brice Waegeneire @ 2021-07-03 20:37 UTC (permalink / raw)
  To: 49364

* gnu/services/networking.scm (ntp-shepherd-service)[start]: Specify log
file.
---
 gnu/services/networking.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 0be4a21e7a..eeb1487116 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -492,7 +492,8 @@ restrict source notrap nomodify noquery\n"))
                                 "-c" #$ntpd.conf "-u" "ntpd"
                                 #$@(if allow-large-adjustment?
                                        '("-g")
-                                       '()))))
+                                       '()))
+                          #:log-file "/var/log/ntpd.log"))
                 (stop #~(make-kill-destructor)))))))))
 
 (define %ntp-accounts
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#49364] [PATCH 0/2] Use log file for tor and ntp services
  2021-07-03 20:35 [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Brice Waegeneire
  2021-07-03 20:37 ` [bug#49364] [PATCH 1/2] services: tor: Log to file Brice Waegeneire
  2021-07-03 20:37 ` [bug#49364] [PATCH 2/2] services: ntp: " Brice Waegeneire
@ 2021-07-07 14:39 ` Mathieu Othacehe
  2021-07-13  5:35   ` bug#49364: " Brice Waegeneire
  2 siblings, 1 reply; 5+ messages in thread
From: Mathieu Othacehe @ 2021-07-07 14:39 UTC (permalink / raw)
  To: Brice Waegeneire; +Cc: 49364


Hey,

> Brice Waegeneire (2):
>   services: tor: Log to file.
>   services: ntp: Log to file.

It could be nice to add those log files to the ntp-configuration and the
tor-configuration records as users may want to have control on logging.

In the meantime, I guess you can proceed with this first implementation.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#49364: [PATCH 0/2] Use log file for tor and ntp services
  2021-07-07 14:39 ` [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Mathieu Othacehe
@ 2021-07-13  5:35   ` Brice Waegeneire
  0 siblings, 0 replies; 5+ messages in thread
From: Brice Waegeneire @ 2021-07-13  5:35 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 49364-done

Mathieu Othacehe <othacehe@gnu.org> writes:

>> Brice Waegeneire (2):
>>   services: tor: Log to file.
>>   services: ntp: Log to file.
>
> It could be nice to add those log files to the ntp-configuration and the
> tor-configuration records as users may want to have control on logging.

ATM I don't have use for specifying the log file path, I can review such
patch when someone write it.  I wrote this one mainly to avoid thoses two
services to write to tty1.

> In the meantime, I guess you can proceed with this first implementation.

Pushed asa5fa05dfc7e5bbe0191938b7824ec264aa842306 and
8bb45504dd9eb441d447e3f1dca174f0231c67d8.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-13  5:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-03 20:35 [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Brice Waegeneire
2021-07-03 20:37 ` [bug#49364] [PATCH 1/2] services: tor: Log to file Brice Waegeneire
2021-07-03 20:37 ` [bug#49364] [PATCH 2/2] services: ntp: " Brice Waegeneire
2021-07-07 14:39 ` [bug#49364] [PATCH 0/2] Use log file for tor and ntp services Mathieu Othacehe
2021-07-13  5:35   ` bug#49364: " Brice Waegeneire

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).