[bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

[bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

[John Doe]

* gnu/packages/freedesktop.scm (udisks):
[inputs]: Add dosfstools.
[arguments]: Modify 'wrap-udisksd phase to add dosfstools in PATH with
wrapper.
---
 gnu/packages/freedesktop.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 3c4ad57a15..1104a07955 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1112,6 +1112,7 @@ Analysis and Reporting Technology) functionality.")
     (inputs
      `(("acl" ,acl)
        ("cryptsetup" ,cryptsetup)
+       ("dosfstools" ,dosfstools)
        ("libatasmart" ,libatasmart)
        ("libblockdev" ,libblockdev)
        ("libgudev" ,libgudev)
@@ -1163,6 +1164,7 @@ Analysis and Reporting Technology) functionality.")
              (let ((out   (assoc-ref outputs "out"))
                    (utils (assoc-ref inputs "util-linux"))
                    (cryptsetup (assoc-ref inputs "cryptsetup"))
+                   (dosfstools (assoc-ref inputs "dosfstools"))
                    (parted (assoc-ref inputs "parted")))
                (wrap-program (string-append out "/libexec/udisks2/udisksd")
                  `("PATH" ":" prefix
@@ -1170,6 +1172,8 @@ Analysis and Reporting Technology) functionality.")
                     ;; cryptsetup is required for setting encrypted
                     ;; partitions, e.g. in gnome-disks
                     ,(string-append cryptsetup "/sbin")
+                    ;; Required to format FAT file systems in gnome-disks
+                    ,(string-append dosfstools "/sbin")
                     "/run/current-system/profile/bin"
                     "/run/current-system/profile/sbin")))
                #t))))))
-- 
2.29.2

[bug#45374] [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

[dftxbs3e]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

Looks like there has already been some discussion about this: 
https://issues.guix.gnu.org/41247

So what do we do?

Patch libblockdev to use full paths or give it to udisksd's
environment?

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

bug#45374: [PATCH] gnu: udisks: Add dosfstools to PATH with wrapper.

[Maxim Cournoyer]

Hi,

dftxbs3e <dftxbs3e@free.fr> writes:

> Looks like there has already been some discussion about this: 
> https://issues.guix.gnu.org/41247
>
> So what do we do?
>
> Patch libblockdev to use full paths or give it to udisksd's
> environment?

I think patching libblockdev is the better solution.  I'm applying
Sarah's patches which added dosfstools as an input and did the patching,
so we should be covered.

Closing.

-- 
Thanks,
Maxim