unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#44260] [PATCH 0/1] knot-resolver: Silence warning re: deprecated option
@ 2020-10-27 18:21 Simon South
  2020-10-27 18:23 ` [bug#44260] [PATCH 1/1] services: knot-resolver: Replace deprecated command-line option Simon South
  0 siblings, 1 reply; 3+ messages in thread
From: Simon South @ 2020-10-27 18:21 UTC (permalink / raw)
  To: 44260; +Cc: simon

This small patch silences this warning from Knot Resolver when it starts:

   deprecation WARNING: use --noninteractive instead of --forks=1

With version 5.0.0 the "-f" option was deprecated[0] in favour of "-n" as a
means of starting the daemon as a non-interactive process.

The patch updates Guix's service definition to match, without any functional
change to the service.

[0] https://gitlab.nic.cz/knot/knot-resolver/issues/529

--
Simon South
simon@simonsouth.net


Simon South (1):
  services: knot-resolver: Replace deprecated command-line option.

 gnu/services/dns.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.28.0





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#44260] [PATCH 1/1] services: knot-resolver: Replace deprecated command-line option.
  2020-10-27 18:21 [bug#44260] [PATCH 0/1] knot-resolver: Silence warning re: deprecated option Simon South
@ 2020-10-27 18:23 ` Simon South
  2020-10-27 22:43   ` bug#44260: " Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Simon South @ 2020-10-27 18:23 UTC (permalink / raw)
  To: 44260; +Cc: simon

This silences a warning from the service at startup.

* gnu/services/dns.scm (knot-resolver-shepherd-services)[start]: Use the "-n"
command-line option to kresd in place of the deprecated "-f 1".
---
 gnu/services/dns.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm
index 572880561c..b339eb0619 100644
--- a/gnu/services/dns.scm
+++ b/gnu/services/dns.scm
@@ -700,7 +700,7 @@ cache.size = 100 * MB
        (documentation "Run the Knot Resolver daemon.")
        (start #~(make-forkexec-constructor
                  '(#$(file-append package "/sbin/kresd")
-                   "-c" #$kresd-config-file "-f" "1"
+                   "-c" #$kresd-config-file "-n"
                    "/var/cache/knot-resolver")))
        (stop #~(make-kill-destructor)))
       (shepherd-service
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#44260: [PATCH 1/1] services: knot-resolver: Replace deprecated command-line option.
  2020-10-27 18:23 ` [bug#44260] [PATCH 1/1] services: knot-resolver: Replace deprecated command-line option Simon South
@ 2020-10-27 22:43   ` Leo Famulari
  0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2020-10-27 22:43 UTC (permalink / raw)
  To: Simon South; +Cc: 44260-done

On Tue, Oct 27, 2020 at 02:23:19PM -0400, Simon South wrote:
> This silences a warning from the service at startup.
> 
> * gnu/services/dns.scm (knot-resolver-shepherd-services)[start]: Use the "-n"
> command-line option to kresd in place of the deprecated "-f 1".

Thanks! Pushed as 5ede2595260d74e2990a8f004298ecf23ea66206




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-27 22:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 18:21 [bug#44260] [PATCH 0/1] knot-resolver: Silence warning re: deprecated option Simon South
2020-10-27 18:23 ` [bug#44260] [PATCH 1/1] services: knot-resolver: Replace deprecated command-line option Simon South
2020-10-27 22:43   ` bug#44260: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).