* [bug#44251] [PATCH] gnu: Add pwclient.
@ 2020-10-27 9:46 Christopher Baines
2020-10-27 23:05 ` Leo Famulari
2020-10-28 13:29 ` [bug#44251] [PATCH v2] " Christopher Baines
0 siblings, 2 replies; 6+ messages in thread
From: Christopher Baines @ 2020-10-27 9:46 UTC (permalink / raw)
To: 44251
* gnu/packages/patchutils.scm (pwclient): New variable.
---
gnu/packages/patchutils.scm | 41 +++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm
index 12dd472c68..e0ed30070b 100644
--- a/gnu/packages/patchutils.scm
+++ b/gnu/packages/patchutils.scm
@@ -468,3 +468,44 @@ patches, and displays the patches along with comments and state information.
Users can login allowing them to change the state of patches.")
(home-page "http://jk.ozlabs.org/projects/patchwork/")
(license gpl2+)))
+
+(define-public pwclient
+ (package
+ (name "pwclient")
+ (version "1.3.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/getpatchwork/pwclient")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1xckwvcqklzpyh3xs4k2zm40ifp0q5fdkj2vmgb8vhfvl1ivs6jv"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch
+ (lambda _
+ (substitute* "test-requirements.txt"
+ (("pytest>=3.0,<5.0;")
+ "pytest>=3.0,<6.0;"))
+ #t))
+ (add-before 'build 'set-PBR_VERSION
+ (lambda _
+ (setenv "PBR_VERSION"
+ ,version)
+ #t)))))
+ (native-inputs
+ `(("npython-pbr" ,python-pbr)
+ ("python-pytest" ,python-pytest)
+ ("python-pytest-cov" ,python-pytest-cov)
+ ("python-mock" ,python-mock)))
+ (home-page
+ "https://github.com/getpatchwork/pwclient")
+ (synopsis "Command-line client for the Patchwork patch tracking tool")
+ (description
+ "pwclient is a VCS-agnostic tool for interacting with Patchwork, the
+web-based patch tracking system.")
+ (license gpl2+)))
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#44251] [PATCH] gnu: Add pwclient.
2020-10-27 9:46 [bug#44251] [PATCH] gnu: Add pwclient Christopher Baines
@ 2020-10-27 23:05 ` Leo Famulari
2020-10-28 13:30 ` Christopher Baines
2020-10-28 13:29 ` [bug#44251] [PATCH v2] " Christopher Baines
1 sibling, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2020-10-27 23:05 UTC (permalink / raw)
To: Christopher Baines; +Cc: 44251
On Tue, Oct 27, 2020 at 09:46:02AM +0000, Christopher Baines wrote:
> * gnu/packages/patchutils.scm (pwclient): New variable.
> + (add-after 'unpack 'patch
> + (lambda _
> + (substitute* "test-requirements.txt"
> + (("pytest>=3.0,<5.0;")
> + "pytest>=3.0,<6.0;"))
> + #t))
I would call the phase 'patch-requirements' or similar and add a brief
comment explaining it.
> + (native-inputs
> + `(("npython-pbr" ,python-pbr)
Typo here --^
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#44251] [PATCH v2] gnu: Add pwclient.
2020-10-27 9:46 [bug#44251] [PATCH] gnu: Add pwclient Christopher Baines
2020-10-27 23:05 ` Leo Famulari
@ 2020-10-28 13:29 ` Christopher Baines
1 sibling, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2020-10-28 13:29 UTC (permalink / raw)
To: 44251
* gnu/packages/patchutils.scm (pwclient): New variable.
---
gnu/packages/patchutils.scm | 54 +++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm
index 12dd472c68..da0f13a01e 100644
--- a/gnu/packages/patchutils.scm
+++ b/gnu/packages/patchutils.scm
@@ -468,3 +468,57 @@ patches, and displays the patches along with comments and state information.
Users can login allowing them to change the state of patches.")
(home-page "http://jk.ozlabs.org/projects/patchwork/")
(license gpl2+)))
+
+(define-public pwclient
+ (package
+ (name "pwclient")
+ (version "1.3.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/getpatchwork/pwclient")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1xckwvcqklzpyh3xs4k2zm40ifp0q5fdkj2vmgb8vhfvl1ivs6jv"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-requirements
+ (lambda _
+ (substitute* "test-requirements.txt"
+ ;; The pytest requirement is unnecessarily strict
+ (("pytest>=3.0,<5.0;")
+ "pytest>=3.0,<6.0;"))
+ #t))
+ (add-before 'build 'set-PBR_VERSION
+ (lambda _
+ (setenv "PBR_VERSION"
+ ,version)
+ #t))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "pytest"))
+ #t))
+ (add-after 'install 'install-man-page
+ (lambda* (#:key outputs #:allow-other-keys)
+ (install-file "man/pwclient.1"
+ (string-append
+ (assoc-ref outputs "out")
+ "/share/man/man1"))
+ #t)))))
+ (native-inputs
+ `(("python-pbr" ,python-pbr)
+ ("python-pytest" ,python-pytest)
+ ("python-pytest-cov" ,python-pytest-cov)
+ ("python-mock" ,python-mock)))
+ (home-page
+ "https://github.com/getpatchwork/pwclient")
+ (synopsis "Command-line client for the Patchwork patch tracking tool")
+ (description
+ "pwclient is a VCS-agnostic tool for interacting with Patchwork, the
+web-based patch tracking system.")
+ (license gpl2+)))
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#44251] [PATCH] gnu: Add pwclient.
2020-10-27 23:05 ` Leo Famulari
@ 2020-10-28 13:30 ` Christopher Baines
2020-10-28 15:36 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Christopher Baines @ 2020-10-28 13:30 UTC (permalink / raw)
To: Leo Famulari; +Cc: 44251
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Tue, Oct 27, 2020 at 09:46:02AM +0000, Christopher Baines wrote:
>> * gnu/packages/patchutils.scm (pwclient): New variable.
>
>> + (add-after 'unpack 'patch
>> + (lambda _
>> + (substitute* "test-requirements.txt"
>> + (("pytest>=3.0,<5.0;")
>> + "pytest>=3.0,<6.0;"))
>> + #t))
>
> I would call the phase 'patch-requirements' or similar and add a brief
> comment explaining it.
I've renamed the phase now, and added a comment.
>> + (native-inputs
>> + `(("npython-pbr" ,python-pbr)
>
> Typo here --^
Indeed, I've removed the rogue n.
I've sent an updated patch, which fixes a few more things as well.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#44251] [PATCH] gnu: Add pwclient.
2020-10-28 13:30 ` Christopher Baines
@ 2020-10-28 15:36 ` Leo Famulari
2020-10-28 16:53 ` bug#44251: " Christopher Baines
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2020-10-28 15:36 UTC (permalink / raw)
To: Christopher Baines; +Cc: 44251
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
On Wed, Oct 28, 2020 at 01:30:46PM +0000, Christopher Baines wrote:
> I've sent an updated patch, which fixes a few more things as well.
Alright, then you can push as you see fit :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#44251: [PATCH] gnu: Add pwclient.
2020-10-28 15:36 ` Leo Famulari
@ 2020-10-28 16:53 ` Christopher Baines
0 siblings, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2020-10-28 16:53 UTC (permalink / raw)
To: Leo Famulari; +Cc: 44251-done
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Wed, Oct 28, 2020 at 01:30:46PM +0000, Christopher Baines wrote:
>> I've sent an updated patch, which fixes a few more things as well.
>
> Alright, then you can push as you see fit :)
Thanks for taking a look! I've pushed this to master as
f6839fed5f2052fd257b4af73effb10dcd9bf35b now.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-28 17:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 9:46 [bug#44251] [PATCH] gnu: Add pwclient Christopher Baines
2020-10-27 23:05 ` Leo Famulari
2020-10-28 13:30 ` Christopher Baines
2020-10-28 15:36 ` Leo Famulari
2020-10-28 16:53 ` bug#44251: " Christopher Baines
2020-10-28 13:29 ` [bug#44251] [PATCH v2] " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).