unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#43975] [PATCH 0/1] gnu: Add ccal [And asking for help on license issue].
@ 2020-10-13  8:09 pengmeiyu
  2020-10-13  8:22 ` [bug#43975] [PATCH 1/1] gnu: Add ccal Peng Mei Yu
  0 siblings, 1 reply; 3+ messages in thread
From: pengmeiyu @ 2020-10-13  8:09 UTC (permalink / raw)
  To: 43975; +Cc: Peng Mei Yu

From: Peng Mei Yu <pengmeiyu@riseup.net>

Hi everyone,

This patch adds ccal, a program for Chinese calendar.  This program has a
weird license issue.

The program's original license was GPL v2+, then the author changed part of
the source code to LGPL under the request of third-party users.  You can find
the email discussion here:
https://github.com/liangqi/kcalendar/blob/c77098a1f3133878743632cdd5788377161610a1/README#L57

The problem is within the LGPL license notice in source code.  The LGPL
license published by FSF can be one of three choices:

- GNU Library General Public License, version 2.0
- GNU Lesser General Public License, version 2.1
- GNU Lesser General Public License, version 3.0

1. In the license notice sections of source code, the author wrote:

mphases.cpp:
--8<---------------cut here---------------start------------->8---
   Distributed under the terms of the GNU Lesser General Public License as
   published by the Free Software Foundation; either version 2 of the
   License, or (at your option) any later version.
--8<---------------cut here---------------end--------------->8---

"GNU Lesser General Public License" and "version 2" is not a valid
combination. "GNU Lesser General Public License" can be either version 2.1 or
version 3.0.

2. In the README file, the author also missspelled "GNU Lesser General Public
License".  "GNU Less General Public License" is not a valid license name.

README:
--8<---------------cut here---------------start------------->8---
Distributed under the terms of the GNU General Public License as
published by the Free Software Foundation; either version 2 of the
License, or (at your option) any later version. Portions related to
computing of Chinese dates are distributed under the terms of the GNU
Less General Public License as published by the Free Software
Foundation; either version 2 of the License, or (at your option)
any later version.
--8<---------------cut here---------------end--------------->8---

3. The COPYING.LESSER file bundled with source code is a copy of LGPL v3.

This is a total mess.

I think the author's intention was to release the code with "GNU Library
General Public License, version 2.0 or any later version".  However what he
wrote in the code is "GNU Lesser General Public License as published by the
Free Software Foundation; either version 2 of the License, or (at your option)
any later version."  I think LGPL v2.1 and v3.0 is compatible with this
sentence.  But I am not sure if "GNU Library General Public License, version
2.0" can be considered compatible.  I am in no way familiar with the western
legal system, so this is only my personal opinion.

The GNU.org webset lists "GNU Library General Public License, version 2.0" as
an old version of "GNU Lesser General Public License":
https://www.gnu.org/licenses/old-licenses/old-licenses.html
Does that mean the FSF thinks "GNU Library General Public License, version
2.0" is equal to "GNU Lesser General Public License, version 2.0"?  Will this
hold in a court?

What's your opinion?

Thanks in advance.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#43975] [PATCH 1/1] gnu: Add ccal.
  2020-10-13  8:09 [bug#43975] [PATCH 0/1] gnu: Add ccal [And asking for help on license issue] pengmeiyu
@ 2020-10-13  8:22 ` Peng Mei Yu
  2020-10-18 21:51   ` bug#43975: " Marius Bakke
  0 siblings, 1 reply; 3+ messages in thread
From: Peng Mei Yu @ 2020-10-13  8:22 UTC (permalink / raw)
  To: 43975; +Cc: Peng Mei Yu

* gnu/packages/calendar.scm (ccal): New variable.
---
 gnu/packages/calendar.scm | 41 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/calendar.scm b/gnu/packages/calendar.scm
index 9987ae1bf8..0123f75c1b 100644
--- a/gnu/packages/calendar.scm
+++ b/gnu/packages/calendar.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com
 ;;; Copyright © 2020 Brendan Tildesley <mail@brendan.scot>
 ;;; Copyright © 2020 Tanguy Le Carrour <tanguy@bioneland.org>
+;;; Copyright © 2020 Peng Mei Yu <pengmeiyu@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -339,3 +340,43 @@ DebConf, FrOSCon, Grazer LinuxTage, and the CCC congresses.
 ConfClerk is targeted at mobile devices but works on any system running Qt.")
     (license (list license:gpl2+
                    license:lgpl3)))) ; or cc-by3.0 for src/icons/*
+
+(define-public ccal
+  (package
+    (name "ccal")
+    (version "2.5.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://ccal.chinesebay.com/ccal/ccal-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "15nza1d1lvk3dp0wcl53wsd32yhbgyzznha092mh5kh5z74vsk1x"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (substitute* "Makefile"
+                 (("/usr/local/bin")
+                  (string-append out "/bin"))
+                 (("/usr/local/man")
+                  (string-append out "/share/man"))))
+             #t))
+         (add-after 'install 'install-manuals
+           (lambda _
+             (invoke "make" "install-man"))))
+       ;; no tests
+       #:tests? #f))
+    (home-page "http://ccal.chinesebay.com/ccal/ccal.htm")
+    (synopsis "Command line program for Chinese calendar")
+    (description "@code{ccal} is a command line program which writes a
+Gregorian calendar together with Chinese calendar to standard output.  Its
+usage is similar to the cal program generally available on Unix platforms.  In
+addition to console output, it can also generate Encapsulated Postscript and
+HTML table outputs for use in do-it-yourself calendars and web pages.  It
+supports both simplified and traditional Chinese characters.")
+    (license (list license:gpl2+
+                   license:lgpl2.1+))))
-- 
2.28.0





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#43975: [PATCH 1/1] gnu: Add ccal.
  2020-10-13  8:22 ` [bug#43975] [PATCH 1/1] gnu: Add ccal Peng Mei Yu
@ 2020-10-18 21:51   ` Marius Bakke
  0 siblings, 0 replies; 3+ messages in thread
From: Marius Bakke @ 2020-10-18 21:51 UTC (permalink / raw)
  To: Peng Mei Yu, 43975-done; +Cc: Peng Mei Yu

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

Peng Mei Yu <pengmeiyu@riseup.net> writes:

> * gnu/packages/calendar.scm (ccal): New variable.

Applied with minor tweaks to the description (@command markup), and
with a comment regarding the licenses.  Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-18 21:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13  8:09 [bug#43975] [PATCH 0/1] gnu: Add ccal [And asking for help on license issue] pengmeiyu
2020-10-13  8:22 ` [bug#43975] [PATCH 1/1] gnu: Add ccal Peng Mei Yu
2020-10-18 21:51   ` bug#43975: " Marius Bakke

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git