* [bug#43825] [PATCH] bioinformatics: htslib: Enable support for custom URI schemes.
@ 2020-10-06 8:48 Roel Janssen
2020-10-06 19:23 ` Efraim Flashner
2020-10-06 20:56 ` Ricardo Wurmus
0 siblings, 2 replies; 4+ messages in thread
From: Roel Janssen @ 2020-10-06 8:48 UTC (permalink / raw)
To: 43825
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
Dear Guix,
I'd like to apply this patch to enable accessing files stored in
certain "cloud" systems. I added "--enable-libcurl" although it is not
strictly necessary. Both "--enable-gcs" and "--enable-s3" require
libcurl to be enabled, so this just seems reassuringly clear to me.
Kind regards,
Roel Janssen
[-- Attachment #2: 0001-bioinformatics-htslib-Enable-support-for-custom-URI-.patch --]
[-- Type: text/x-patch, Size: 1079 bytes --]
From fbec05df4bcc630ac51f59cd27f8e45a6ac41002 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Tue, 6 Oct 2020 10:41:56 +0200
Subject: [PATCH] bioinformatics: htslib: Enable support for custom URI
schemes.
This commit enables the translation of "gs://" and "s3://"
URIs into their equivalent HTTPS variants.
* gnu/packages/bioinformatics.scm (htslib): Enable support for custom URIs.
---
gnu/packages/bioinformatics.scm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index fda7255662..c8bf7cfdad 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -4225,6 +4225,10 @@ performance.")
(base32
"16ljv43sc3fxmv63w7b2ff8m1s7h89xhazwmbm1bicz8axq8fjz0"))))
(build-system gnu-build-system)
+ (arguments
+ `(#:configure-flags '("--enable-gcs"
+ "--enable-libcurl"
+ "--enable-s3")))
(inputs
`(("curl" ,curl)
("openssl" ,openssl)))
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#43825] [PATCH] bioinformatics: htslib: Enable support for custom URI schemes.
2020-10-06 8:48 [bug#43825] [PATCH] bioinformatics: htslib: Enable support for custom URI schemes Roel Janssen
@ 2020-10-06 19:23 ` Efraim Flashner
2020-10-06 20:56 ` Ricardo Wurmus
1 sibling, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2020-10-06 19:23 UTC (permalink / raw)
To: Roel Janssen; +Cc: 43825
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On Tue, Oct 06, 2020 at 10:48:31AM +0200, Roel Janssen wrote:
> Dear Guix,
>
> I'd like to apply this patch to enable accessing files stored in
> certain "cloud" systems. I added "--enable-libcurl" although it is not
> strictly necessary. Both "--enable-gcs" and "--enable-s3" require
> libcurl to be enabled, so this just seems reassuringly clear to me.
>
> Kind regards,
> Roel Janssen
>
That sounds fine to me.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#43825] [PATCH] bioinformatics: htslib: Enable support for custom URI schemes.
2020-10-06 8:48 [bug#43825] [PATCH] bioinformatics: htslib: Enable support for custom URI schemes Roel Janssen
2020-10-06 19:23 ` Efraim Flashner
@ 2020-10-06 20:56 ` Ricardo Wurmus
2020-10-07 13:37 ` bug#43825: " Roel Janssen
1 sibling, 1 reply; 4+ messages in thread
From: Ricardo Wurmus @ 2020-10-06 20:56 UTC (permalink / raw)
To: Roel Janssen; +Cc: 43825
Hi Roel,
> I'd like to apply this patch to enable accessing files stored in
> certain "cloud" systems.
Sounds good to me. Please move the explanation from the commit message
to the code as a comment.
As commit message please use:
* gnu/packages/bioinformatics.scm (htslib)[arguments]: Enable support for custom URIs.
--
Ricardo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#43825: [PATCH] bioinformatics: htslib: Enable support for custom URI schemes.
2020-10-06 20:56 ` Ricardo Wurmus
@ 2020-10-07 13:37 ` Roel Janssen
0 siblings, 0 replies; 4+ messages in thread
From: Roel Janssen @ 2020-10-07 13:37 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 43825-done
On Tue, 2020-10-06 at 22:56 +0200, Ricardo Wurmus wrote:
> Hi Roel,
>
> > I'd like to apply this patch to enable accessing files stored in
> > certain "cloud" systems.
>
> Sounds good to me. Please move the explanation from the commit
> message
> to the code as a comment.
>
> As commit message please use:
>
> * gnu/packages/bioinformatics.scm (htslib)[arguments]: Enable support
> for custom URIs.
>
Thank you! I've committed this patch at fb0037a.
Kind regards,
Roel Janssen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-07 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 8:48 [bug#43825] [PATCH] bioinformatics: htslib: Enable support for custom URI schemes Roel Janssen
2020-10-06 19:23 ` Efraim Flashner
2020-10-06 20:56 ` Ricardo Wurmus
2020-10-07 13:37 ` bug#43825: " Roel Janssen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).