* [bug#43245] [PATCH] gnu: xournalpp: Fix path to addr2line binary
@ 2020-09-06 15:31 Lars-Dominik Braun
2020-09-07 5:49 ` bug#43245: " Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Dominik Braun @ 2020-09-06 15:31 UTC (permalink / raw)
To: 43245
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
Hi,
I noticed xournalpp’s crash reporter depends on binutils’ addr2line
binary. When running `guix environment --pure --ad-hoc xournalpp --
xournalpp` you can see lines like `sh: addr2line: command not found`.
The attached patch replaces the path by the build-time binutil’s
version.
Cheers,
Lars
[-- Attachment #2: 0001-gnu-xournalpp-Fix-path-to-addr2line-binary.patch --]
[-- Type: text/x-diff, Size: 1223 bytes --]
From ab65a639b2af2eb67ab325d2bdf0fab07157d9d3 Mon Sep 17 00:00:00 2001
From: Lars-Dominik Braun <lars@6xq.net>
Date: Sun, 6 Sep 2020 17:27:54 +0200
Subject: [PATCH] gnu: xournalpp: Fix path to addr2line binary
* gnu/packages/pdf.scm [arguments]: Add phase substituting path of
addr2line utility.
---
gnu/packages/pdf.scm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 7649bff695..4c11111323 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -848,6 +848,14 @@ using a stylus.")
(for-each (lambda (po) (chmod po #o666))
(find-files "." "\\.po$"))
#t))
+ ;; Fix path to addr2line utility, which the crash reporter uses.
+ (add-after 'unpack 'fix-paths
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "src/util/Stacktrace.cpp"
+ ;; Match only the commandline.
+ (("\"addr2line ")
+ (string-append "\"" (which "addr2line") " ")))
+ #t))
(add-after 'install 'glib-or-gtk-wrap
(assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
(native-inputs
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#43245: [PATCH] gnu: xournalpp: Fix path to addr2line binary
2020-09-06 15:31 [bug#43245] [PATCH] gnu: xournalpp: Fix path to addr2line binary Lars-Dominik Braun
@ 2020-09-07 5:49 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2020-09-07 5:49 UTC (permalink / raw)
To: Lars-Dominik Braun; +Cc: 43245-done
Hello,
> I noticed xournalpps crash reporter depends on binutils addr2line
> binary. When running `guix environment --pure --ad-hoc xournalpp --
> xournalpp` you can see lines like `sh: addr2line: command not found`.
> The attached patch replaces the path by the build-time binutils
> version.
Pushed, thanks!
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 5:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-06 15:31 [bug#43245] [PATCH] gnu: xournalpp: Fix path to addr2line binary Lars-Dominik Braun
2020-09-07 5:49 ` bug#43245: " Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).