[bug#41324] [PATCH v2] gnu: Add dump.

[bug#41324] [PATCH v2] gnu: Add dump.

[Marcin Karpezo]

* gnu/packages/backup.scm (dump): New variable.
---
 gnu/packages/backup.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 6a5080bcf8..2157b349dd 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2020 Marcin Karpezo <sirmacik@wioo.waw.pl>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1026,6 +1027,44 @@ stored previously can be read back in full at any time.  The program
 is format-agnostic, so you can feed virtually any files to it.")
     (license license:gpl2+)))
 
+(define-public dump
+  (package
+    (name "dump")
+    (version "0.4b46")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://downloads.sourceforge.net/project/" name "/"
+                           name "/" version "/" name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "15rg5y15ak0ppqlhcih78layvg7cwp6hc16p3c58xs8svlkxjqc0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       `("--sysconfdir=/etc"
+         "--disable-readline"
+         "--disable-rmt")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("zlib" ,zlib)
+       ("util-linux" ,util-linux "lib")
+       ("e2fsprogs" ,e2fsprogs)
+       ("automake" ,automake)))
+    (inputs
+     `(("openssl" ,openssl-1.0)))
+    (home-page "https://dump.sourceforge.io/")
+    (synopsis "Linux Ext2/3/4 filesystem dump/restore utilities")
+    (description "Dump examines files in a filesystem, determines which ones
+need to be backed up, and copies those files to a specified disk, tape or
+other storage medium.  Subsequent incremental backups can then be layered on
+top of the full backup.  The restore command performs the inverse function of
+dump; it can restore a full backup of a filesystem.  Single files and
+directory subtrees may also be restored from full or partial backups in
+interractive mode.")
+    (license license:bsd-3)))
+
 (define-public burp
   (package
     (name "burp")
-- 
2.26.2

[bug#41324] [PATCH v2] gnu: Add dump.

[Marcin Karpezo]

* gnu/packages/backup.scm (dump): New variable.
---
 gnu/packages/backup.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 6a5080bcf8..2157b349dd 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2020 Marcin Karpezo <sirmacik@wioo.waw.pl>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1026,6 +1027,44 @@ stored previously can be read back in full at any time.  The program
 is format-agnostic, so you can feed virtually any files to it.")
     (license license:gpl2+)))
 
+(define-public dump
+  (package
+    (name "dump")
+    (version "0.4b46")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://downloads.sourceforge.net/project/" name "/"
+                           name "/" version "/" name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "15rg5y15ak0ppqlhcih78layvg7cwp6hc16p3c58xs8svlkxjqc0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       `("--sysconfdir=/etc"
+         "--disable-readline"
+         "--disable-rmt")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("zlib" ,zlib)
+       ("util-linux" ,util-linux "lib")
+       ("e2fsprogs" ,e2fsprogs)
+       ("automake" ,automake)))
+    (inputs
+     `(("openssl" ,openssl-1.0)))
+    (home-page "https://dump.sourceforge.io/")
+    (synopsis "Linux Ext2/3/4 filesystem dump/restore utilities")
+    (description "Dump examines files in a filesystem, determines which ones
+need to be backed up, and copies those files to a specified disk, tape or
+other storage medium.  Subsequent incremental backups can then be layered on
+top of the full backup.  The restore command performs the inverse function of
+dump; it can restore a full backup of a filesystem.  Single files and
+directory subtrees may also be restored from full or partial backups in
+interractive mode.")
+    (license license:bsd-3)))
+
 (define-public burp
   (package
     (name "burp")
-- 
2.26.2

[bug#41324] [PATCH v2] gnu: Add dump.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

Hi Marcin,

Marcin Karpezo <sirmacik@wioo.waw.pl> writes:

> * gnu/packages/backup.scm (dump): New variable.

Thanks!  Can't believe we've gone without this for so long.

[...]
  
> +(define-public dump
> +  (package
> +    (name "dump")
> +    (version "0.4b46")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://downloads.sourceforge.net/project/" name "/"
> +                           name "/" version "/" name "-" version ".tar.gz"))

Please use "mirror://sourceforge" here.

> +       (sha256
> +        (base32
> +         "15rg5y15ak0ppqlhcih78layvg7cwp6hc16p3c58xs8svlkxjqc0"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       `("--sysconfdir=/etc"
> +         "--disable-readline"
> +         "--disable-rmt")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("zlib" ,zlib)
> +       ("util-linux" ,util-linux "lib")
> +       ("e2fsprogs" ,e2fsprogs)
> +       ("automake" ,automake)))

I ran 'guix size dump' and noticed that the package keeps references to
util-linux, zlib and e2fsprogs.  Probably they should be "inputs"
instead.  Can you confirm and send an updated patch?

Otherwise looks great, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#41324] [PATCH v3] gnu/packages/backup.scm (dump): New variable

[Marcin Karpezo]

Hi Marius,

I'm sending updated patch with the changes you requested. Apart from
one, regarding use of mirror://sourceforge. I've tried it several
times and in several ways I've found in other packages included in
guix, but the one presented is the one that wokred to bild package
relaiably.

---
 gnu/packages/backup.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 0fe6676cc2..1939f3b72c 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2020 Marcin Karpezo <sirmacik@wioo.waw.pl>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1026,6 +1027,44 @@ stored previously can be read back in full at any time.  The program
 is format-agnostic, so you can feed virtually any files to it.")
     (license license:gpl2+)))

+(define-public dump
+  (package
+    (name "dump")
+    (version "0.4b46")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://downloads.sourceforge.net/project/" name "/"
+                           name "/" version "/" name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "15rg5y15ak0ppqlhcih78layvg7cwp6hc16p3c58xs8svlkxjqc0"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       `("--sysconfdir=/etc"
+         "--disable-readline"
+         "--disable-rmt")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    (inputs
+     `(("openssl" ,openssl-1.0)
+       ("zlib" ,zlib)
+       ("util-linux" ,util-linux "lib")
+       ("e2fsprogs" ,e2fsprogs)))
+    (home-page "https://dump.sourceforge.io/")
+    (synopsis "Linux Ext2/3/4 filesystem dump/restore utilities")
+    (description "Dump examines files in a filesystem, determines which ones
+need to be backed up, and copies those files to a specified disk, tape or
+other storage medium.  Subsequent incremental backups can then be layered on
+top of the full backup.  The restore command performs the inverse function of
+dump; it can restore a full backup of a filesystem.  Single files and
+directory subtrees may also be restored from full or partial backups in
+interractive mode.")
+    (license license:bsd-3)))
+
 (define-public burp
   (package
     (name "burp")
--
2.26.2

bug#41324: [PATCH v3] gnu/packages/backup.scm (dump): New variable

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Marcin Karpezo <sirmacik@wioo.waw.pl> writes:

> Hi Marius,
>
> I'm sending updated patch with the changes you requested. Apart from
> one, regarding use of mirror://sourceforge. I've tried it several
> times and in several ways I've found in other packages included in
> guix, but the one presented is the one that wokred to bild package
> relaiably.

Great!  Constructing those mirror://sourceforge URLs can be surprisingly
difficult, I wonder if we could make it easier somehow.

I managed to find a working URL and applied the patch with the unused
'autoconf' and 'automake' inputs removed (missed that in the previous
review).  I also removed 'Linux' from the synopsis as it does not
actually run in kernel-space.  ;-)

Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]