From: Leo Famulari <leo@famulari.name>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 41192@debbugs.gnu.org
Subject: [bug#41192] [PATCH 2/2] gnu: wireguard-tools: Fix wg-quick.
Date: Mon, 11 May 2020 15:58:34 -0400 [thread overview]
Message-ID: <20200511195834.GB15862@jasmine.lan> (raw)
In-Reply-To: <20200511185310.24537-2-brice@waegenei.re>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Mon, May 11, 2020 at 08:53:10PM +0200, Brice Waegeneire wrote:
> + (add-after 'install 'install-contrib
How about calling this phase "install-docs" or "install-contrib-docs"?.
> + (wrap-program (string-append out "/bin/wg-quick")
> + `("PATH" ":" = ,(append inputs-sbin
> + (list coreutils
> + "/run/setuid-programs"))))
> + #t))))))
Setuid Guix only exists on Guix System, so we should drop this wrapper.
It's okay to make users do `sudo wg-quick` or similar.
> + (native-inputs
> + `(("bash" ,bash))) ; for contrib scripts using /dev/tcp
> + (inputs
> + `(("resolvconf" ,openresolv)
> + ("coreutils" ,coreutils)
Is coreutils not already available in the build environment?
> + ("bash" ,bash) ; for contrib scripts using /dev/tcp
IIUC, we don't need to include Bash in both 'native-inputs' and
'inputs'. If this Bash will be used at run-time (e.g. as a script
shebang), we should just use 'inputs'.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-11 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 18:43 [bug#41192] [PATCH 0/2] wireguard-tools: Fix wg-quick Brice Waegeneire
2020-05-11 18:53 ` [bug#41192] [PATCH 1/2] gnu: Add openresolv Brice Waegeneire
2020-05-11 19:52 ` Leo Famulari
2020-05-12 20:34 ` Brice Waegeneire
2020-05-11 18:53 ` [bug#41192] [PATCH 2/2] gnu: wireguard-tools: Fix wg-quick Brice Waegeneire
2020-05-11 19:58 ` Leo Famulari [this message]
2020-05-12 20:57 ` Brice Waegeneire
2020-05-12 21:01 ` [bug#41192] [PATCH v2 0/2] " Brice Waegeneire
2020-05-12 21:01 ` [bug#41192] [PATCH v2 1/2] gnu: Add openresolv Brice Waegeneire
2020-05-12 21:01 ` [bug#41192] [PATCH v2 2/2] gnu: wireguard-tools: Fix wg-quick Brice Waegeneire
2020-05-12 21:28 ` [bug#41192] [PATCH v2 0/2] " Leo Famulari
2020-05-13 9:28 ` bug#41192: " Brice Waegeneire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511195834.GB15862@jasmine.lan \
--to=leo@famulari.name \
--cc=41192@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).