From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id h4DoDYCuuV6vTgAA0tVLHw (envelope-from ) for ; Mon, 11 May 2020 19:58:56 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eFIGEY6uuV6bLAAAB5/wlQ (envelope-from ) for ; Mon, 11 May 2020 19:59:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4876940058 for ; Mon, 11 May 2020 19:59:07 +0000 (UTC) Received: from localhost ([::1]:57604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYEZw-0003nW-8E for larch@yhetil.org; Mon, 11 May 2020 15:59:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYEZq-0003nO-J7 for guix-patches@gnu.org; Mon, 11 May 2020 15:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYEZq-0006L8-9S for guix-patches@gnu.org; Mon, 11 May 2020 15:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYEZq-0007vO-7b for guix-patches@gnu.org; Mon, 11 May 2020 15:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41192] [PATCH 2/2] gnu: wireguard-tools: Fix wg-quick. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 May 2020 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41192 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 41192@debbugs.gnu.org Received: via spool by 41192-submit@debbugs.gnu.org id=B41192.158922712330432 (code B ref 41192); Mon, 11 May 2020 19:59:02 +0000 Received: (at 41192) by debbugs.gnu.org; 11 May 2020 19:58:43 +0000 Received: from localhost ([127.0.0.1]:53373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEZX-0007um-6e for submit@debbugs.gnu.org; Mon, 11 May 2020 15:58:43 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYEZV-0007ua-Ng for 41192@debbugs.gnu.org; Mon, 11 May 2020 15:58:42 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8ED8A5C0134; Mon, 11 May 2020 15:58:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 11 May 2020 15:58:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=hRPzHKYgdtb3ECwh5Fug876e AKgEYTG9KAWfXi4oRjY=; b=TPdAXMLAeD5MQT5iVORM0SL2hbUNPLxA4KMEh3Z/ Al7e51C6X8B3lwlpluDn5hVmp+HPTUNVCuWm7xYxRayNR34xkE0qbz+Bz85BdpNK tExolgy2B8GjbAL6kmFwpYxes+bCOmpsRGszOxqAt5YVnpplZKB1y04g1uf/6wKU jXM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hRPzHK Ygdtb3ECwh5Fug876eAKgEYTG9KAWfXi4oRjY=; b=QUYy9kpRWqYlabab2zKXeA hpE6/cIFE7C0SJAvsBPqYh45jAhkEpbKBiQ8iHUSy29DvtjsMG6EXpLiX3Ii3Hd/ weEsq41O4GxzNy5CxlyKMIc1vo6suJr3PQ4QZSW/yX+Aei8ivQ2a/alFg+ywlZKl oShPZ3+cEpZngMN5+hHsxWskR9XvwlB5Ph6yC5haylYrKYk97n2wHPnRU8WrrJXt D+i+teMxxYHZBYqmexinO1a8cC2yp66egbMVNPwjgYJk8IxC5AU4tgLaZBAEUdBv 1aKqInN0HxGeDK2gYG+hc5QtPyaVTmo4hQO4CJbSLcMPhwFVPXFEnv4F/1obIqYA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledtgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 0F8FD306629B; Mon, 11 May 2020 15:58:36 -0400 (EDT) Date: Mon, 11 May 2020 15:58:34 -0400 From: Leo Famulari Message-ID: <20200511195834.GB15862@jasmine.lan> References: <20200511184312.21587-1-brice@waegenei.re> <20200511185310.24537-2-brice@waegenei.re> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <20200511185310.24537-2-brice@waegenei.re> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -2.11 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=TPdAXMLA; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=QUYy9kpR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-2.11 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.5400410104267]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; R_DKIM_REJECT(1.00)[famulari.name:s=mesmtp,messagingengine.com:s=fm2]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.07), country: US(-0.00), ip: 209.51.188.17(-0.54)]; DKIM_TRACE(0.00)[famulari.name:-,messagingengine.com:-]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[76.124.138.63:received]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[leo@famulari.name,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[famulari.name]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: LVZfP2X9iCs9 --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 11, 2020 at 08:53:10PM +0200, Brice Waegeneire wrote: > + (add-after 'install 'install-contrib How about calling this phase "install-docs" or "install-contrib-docs"?. > + (wrap-program (string-append out "/bin/wg-quick") > + `("PATH" ":" = ,(append inputs-sbin > + (list coreutils > + "/run/setuid-programs")))) > + #t)))))) Setuid Guix only exists on Guix System, so we should drop this wrapper. It's okay to make users do `sudo wg-quick` or similar. > + (native-inputs > + `(("bash" ,bash))) ; for contrib scripts using /dev/tcp > + (inputs > + `(("resolvconf" ,openresolv) > + ("coreutils" ,coreutils) Is coreutils not already available in the build environment? > + ("bash" ,bash) ; for contrib scripts using /dev/tcp IIUC, we don't need to include Bash in both 'native-inputs' and 'inputs'. If this Bash will be used at run-time (e.g. as a script shebang), we should just use 'inputs'. --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl65rmoACgkQJkb6MLrK fwhDJg/9Hlhv3b/FPCc2n7GXxN7iWnlSmRW/onWcDQIdr5wryB0MC5OpjjiC/IeT XFRAc8e9fHyBZ3S21JNumT4JwL9u3xCNS+9cFRFWpOSDp/LsE17V8TCdpJlVAyj0 zQHAqNdfUCL5y1MGms8jhKzqD8RNHUz/KjAZeKglE7jg8rNCozgFQddO2RFNDuqv gt8g1eyoLuu0BdzjaPFSNOLvkVBTx/uyT/Eli36gLocVRL/kc24FnuIV17tHdfa0 6NiX7hspqXudPJ+RNwo847nRodTamRrnUQPLIyMvcFnTw51YxslMojYD1OISfvej ZzpTGwBbVoe2yLsgrQoNXEoGXw78nB/SXqnNYqwW7pQ/yCzp9fuMhIOONv7HxEY9 D0lN/7QHOMJvYa3pGCJavNuc0G1X3ASKWcdP0NKpu5ovGo7a997KcdJFC/P1X6JV EiqQ4KIGTyFlI9GzrkYsgN8wkOEQxpkeu8vl5+jWGktWvvUxpnaJlVB5O6AR/XxX x6z2gfu9Z4TaK2oN0SKAtNQ+0Rt8K9M25bn5e0taR8bZvlfVVloJbsZlNxcqqjPI AZ5kCvwZbUJXvImMyk8G5UZuU7TXCYLiFsMS7Fw+y3sVD78TAXdfuHiLNe2I2bfe rWvvRrbRxHe3EvjZzmp5nsVpFQcVAGmxm8QSPdVOAQvIdcHP8CI= =MDaL -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--