From: Raghav Gururajan <raghavgururajan@disroot.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 40994@debbugs.gnu.org, Brice Waegeneire <brice@waegenei.re>
Subject: [bug#40994] patch#40994 Programs With Movie Titles (PWMT)
Date: Thu, 7 May 2020 23:37:50 -0400 [thread overview]
Message-ID: <20200507233750.0dd05130.raghavgururajan@disroot.org> (raw)
In-Reply-To: <87a72k4zd8.fsf@devup.no>
Hi Marius!
> I know it's a lot to ask, but it would be great if you could split this
> up in multiple patches, one per logical change. I.e. this one patch
> would be better as a series like:
>
> Raghav Gururajan (7):
> gnu: girara: Download tarball instead of git source.
> gnu: girara: Wrap with Glib variables.
> gnu: girara: Add notification support.
> gnu: girara: Build and install documentation.
> gnu: girara: Do not propagate GTK+.
> gnu: girara: Enable more features.
> gnu: girara: Update synopsis & description.
Oh yeah, this is lot and I cannot do at this time. But I have sent updated
patch-set that splits some changes. :-)
Anyway, this suggestion is very useful, so that I can use it moving forward.
> I'm also skeptical about some of these (why is #:glib-or-gtk? necessary
> for this library, why does GTK+ no longer need to be propagated, and
> what are all those new inputs for?). By lumping everything together
> it's difficult to reason about these changes.
>
> Same here, what do these inputs do?
>
> > [inputs]<appstream-glib,cairo,file,girara,glib,json-c,gtk+,libnotify,
> > libseccomp>: New inputs.
>
> And these?
I have used comments in the package definition. :-)
> Why does this plugin package need #:glib-or-gtk?.
That was a mistake. I removed it in the new patch-set.
> > [inputs]<cairo,girara,glib,gtk+,json-c,libnotify>: New inputs.
>
> It's strange that all of these packages require almost the exact same
> set of inputs. Perhaps they should be propagated somewhere?
That's correct. cairo and girara are effect of removing propagation in zathura.
I think it is better not to propagate things, unless it is absolutely
necessary. Other inputs are simply required to generate 'cargs'.
> I think you catch my drift here, can you send an updated series?
I have sent an updated patch-set to the thread, with changes I could do at this
time. :-)
Regards,
RG.
next prev parent reply other threads:[~2020-05-08 3:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 11:52 [bug#40994] Programs With Movie Titles (PWMT) Raghav Gururajan
2020-05-01 13:49 ` [bug#40994] 1-girara-v1 Raghav Gururajan
2020-05-01 13:50 ` [bug#40994] 2-zathura-v1 Raghav Gururajan
2020-05-01 17:48 ` [bug#40994] 3-zathura-ps-v1 Raghav Gururajan
2020-05-02 8:17 ` [bug#40994] 4-zathura-pdf-poppler-v1 Raghav Gururajan
2020-05-02 8:50 ` [bug#40994] 5-zathura-pdf-mupdf-v1 Raghav Gururajan
2020-05-02 9:16 ` [bug#40994] 6-zathura-djvu-v1 Raghav Gururajan
2020-05-02 9:58 ` [bug#40994] 7-zathura-cb-v1 Raghav Gururajan
2020-05-02 13:24 ` [bug#40994] patch#40994 Programs With Movie Titles (PWMT) Brice Waegeneire
2020-05-02 16:09 ` Raghav Gururajan
2020-05-03 4:22 ` Raghav Gururajan
2020-05-06 19:50 ` Marius Bakke
2020-05-08 3:37 ` Raghav Gururajan [this message]
2020-05-06 19:29 ` Marius Bakke
2020-05-08 3:28 ` Raghav Gururajan
2020-05-06 9:41 ` [bug#40994] All patches attached Raghav Gururajan
2020-05-08 3:24 ` [bug#40994] Updated patch-set Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507233750.0dd05130.raghavgururajan@disroot.org \
--to=raghavgururajan@disroot.org \
--cc=40994@debbugs.gnu.org \
--cc=brice@waegenei.re \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).