From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eGc1E23UtF5OSAAA0tVLHw (envelope-from ) for ; Fri, 08 May 2020 03:39:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CAEyLnnUtF5MNAAAB5/wlQ (envelope-from ) for ; Fri, 08 May 2020 03:39:37 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AD5BD94060B for ; Fri, 8 May 2020 03:39:35 +0000 (UTC) Received: from localhost ([::1]:55562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWtrM-0002tX-Bp for larch@yhetil.org; Thu, 07 May 2020 23:39:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWtqo-00027o-Bt for guix-patches@gnu.org; Thu, 07 May 2020 23:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32796) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWtqo-0000wT-0m for guix-patches@gnu.org; Thu, 07 May 2020 23:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWtqn-0001DU-TO for guix-patches@gnu.org; Thu, 07 May 2020 23:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40994] patch#40994 Programs With Movie Titles (PWMT) Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 May 2020 03:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40994 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Marius Bakke Cc: 40994@debbugs.gnu.org, Brice Waegeneire Received: via spool by 40994-submit@debbugs.gnu.org id=B40994.15889091004626 (code B ref 40994); Fri, 08 May 2020 03:39:01 +0000 Received: (at 40994) by debbugs.gnu.org; 8 May 2020 03:38:20 +0000 Received: from localhost ([127.0.0.1]:44342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWtq8-0001CY-E2 for submit@debbugs.gnu.org; Thu, 07 May 2020 23:38:20 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWtq6-0001CP-Vo for 40994@debbugs.gnu.org; Thu, 07 May 2020 23:38:19 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1853435CBD; Fri, 8 May 2020 05:38:17 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UOJxdLf5MUDu; Fri, 8 May 2020 05:38:16 +0200 (CEST) Date: Thu, 7 May 2020 23:37:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1588909096; bh=B8rK4vs3zbaiJSC5EcJ1NHx5uF/kPuPswYqz30rUKVk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=V/NztbNQ13gk2/XD+pxbAQhBUwlhZbLF7c+dvzsDhsSpmVzclRbkGLIU7Q21lSJVH iD3cgL42r6n6yPsUSGpasc4pmpsSE8uPn+hX2JBDPTk84j4WJJjB6ZxarV+784lWvE sVjiCeC06nHoJPQi5R4SB4dRq/5dG++ZRoB8hNbZG0MZoiE4jDw/i4lptcDSjkdQnv 8WizNkfQ07mQ3NOUEZjCdhH2WPyLwkNh4bJOc9y+fLXE9MYfqGMUtf8nxwY4YxxlNu keXcbiMg7qWWwOZYy4v+CUmH+dUx3dTPJBJiIHIWksNQ7z7ZI0VRAAt8oFTcHKpHx1 4vv+fBY0ECaIA== From: Raghav Gururajan Message-ID: <20200507233750.0dd05130.raghavgururajan@disroot.org> In-Reply-To: <87a72k4zd8.fsf@devup.no> References: <76c18088643dcab9d395a0f9760d3a74@waegenei.re> <20200502120901.36d80711.raghavgururajan@disroot.org> <20200503002240.3c2bf6a3.raghavgururajan@disroot.org> <87a72k4zd8.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: 1.59 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=disroot.org header.s=mail header.b=V/NztbNQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=disroot.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [1.59 / 13.00]; GENERIC_REPUTATION(0.00)[-0.49889922855028]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; R_DKIM_REJECT(1.00)[disroot.org:s=mail]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MV_CASE(0.50)[]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.10), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DKIM_TRACE(0.00)[disroot.org:-]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[fastmail.com]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[raghavgururajan@disroot.org,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; MID_CONTAINS_FROM(1.00)[]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[disroot.org : SPF not aligned (relaxed),none] X-TUID: AaXh9cCwo8y5 Hi Marius! > I know it's a lot to ask, but it would be great if you could split this > up in multiple patches, one per logical change. I.e. this one patch > would be better as a series like: > > Raghav Gururajan (7): > gnu: girara: Download tarball instead of git source. > gnu: girara: Wrap with Glib variables. > gnu: girara: Add notification support. > gnu: girara: Build and install documentation. > gnu: girara: Do not propagate GTK+. > gnu: girara: Enable more features. > gnu: girara: Update synopsis & description. Oh yeah, this is lot and I cannot do at this time. But I have sent updated patch-set that splits some changes. :-) Anyway, this suggestion is very useful, so that I can use it moving forward. > I'm also skeptical about some of these (why is #:glib-or-gtk? necessary > for this library, why does GTK+ no longer need to be propagated, and > what are all those new inputs for?). By lumping everything together > it's difficult to reason about these changes. > > Same here, what do these inputs do? > > > [inputs] > libseccomp>: New inputs. > > And these? I have used comments in the package definition. :-) > Why does this plugin package need #:glib-or-gtk?. That was a mistake. I removed it in the new patch-set. > > [inputs]: New inputs. > > It's strange that all of these packages require almost the exact same > set of inputs. Perhaps they should be propagated somewhere? That's correct. cairo and girara are effect of removing propagation in zathura. I think it is better not to propagate things, unless it is absolutely necessary. Other inputs are simply required to generate 'cargs'. > I think you catch my drift here, can you send an updated series? I have sent an updated patch-set to the thread, with changes I could do at this time. :-) Regards, RG.