[bug#40657] gnu: liblinphone: Fix icons for legacy UI.

[bug#40657] gnu: liblinphone: Fix icons for legacy UI.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]

Hello Guix!

Please find the attached patch to fix icons in legacy user-interface of
liblinphone.

Regards,
RG.

[-- Attachment #2: 0001-gnu-liblinphone-Fix-icons-for-legacy-UI.patch --]
[-- Type: text/x-patch, Size: 1074 bytes --]

From 1b250972c7a3f7cb3a7dd6e68cec145286349ec4 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Thu, 16 Apr 2020 08:37:59 -0400
Subject: [PATCH] gnu: liblinphone: Fix icons for legacy UI.

* gnu/packages/linphone.scm (liblinphone): Fix icons for legacy UI.
---
 gnu/packages/linphone.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
index c9959d7d01..839b3bd9c6 100644
--- a/gnu/packages/linphone.scm
+++ b/gnu/packages/linphone.scm
@@ -459,7 +459,8 @@ decoding, and rendering.")
        ("sqlite" ,sqlite)
        ("udev" ,eudev)))
     (propagated-inputs
-     `(("murrine" ,murrine)))           ; Required for GTK UI
+     `(("hicolor-icon-theme" ,hicolor-icon-theme) ; Required for GTK UI
+       ("murrine" ,murrine)))           ; Required for GTK UI
     (synopsis "Belledonne Communications Softphone Library")
     (description "Liblinphone is a high-level SIP library integrating
 all calling and instant messaging features into an unified
-- 
2.26.0

[bug#40657] gnu: liblinphone: Fix icons. (v2)

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-gnu-liblinphone-Fix-icons.patch --]
[-- Type: text/x-patch, Size: 2001 bytes --]

From f9dcbb7c2756f960721cf7194b710de3c4ac22e1 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Mon, 20 Apr 2020 01:47:50 -0400
Subject: [PATCH] gnu: liblinphone: Fix icons.

* gnu/packages/linphone.scm (liblinphone): Fix icons.
---
 gnu/packages/linphone.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
index c9959d7d01..8962f2001e 100644
--- a/gnu/packages/linphone.scm
+++ b/gnu/packages/linphone.scm
@@ -49,6 +49,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu))
 
 (define-public bcunit
@@ -428,8 +429,17 @@ decoding, and rendering.")
                                       "/lib/glib-2.0/include"))
         "-DENABLE_STATIC=NO"            ; Not required
         "-DENABLE_GTK_UI=YES")          ; For Legacy UI
+       #:imported-modules (,@%cmake-build-system-modules
+                           (guix build glib-or-gtk-build-system))
+       #:modules ((guix build cmake-build-system)
+                  ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
+                  (guix build utils))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'install 'glib-or-gtk-compile-schemas
+           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))
+         (add-after 'install 'glib-or-gtk-wrap
+           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
          (add-after 'unpack 'patch
            (lambda _
              (substitute* "gtk/main.c"
@@ -449,6 +459,7 @@ decoding, and rendering.")
        ("belcard" ,belcard)
        ("bellesip" ,belle-sip)
        ("bzrtp", bzrtp)
+       ("hicolor-icon-theme" ,hicolor-icon-theme) ; Hard-coded for GTK UI
        ("glib" ,glib)
        ("gtk2" ,gtk+-2)
        ("mediastreamer2" ,mediastreamer2)
-- 
2.26.1

bug#40657: gnu: liblinphone: Fix icons. (v2)

[Maxim Cournoyer]

Hello Raghav,

Raghav Gururajan <raghavgururajan@disroot.org> writes:

>>From f9dcbb7c2756f960721cf7194b710de3c4ac22e1 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Mon, 20 Apr 2020 01:47:50 -0400
> Subject: [PATCH] gnu: liblinphone: Fix icons.
>
> * gnu/packages/linphone.scm (liblinphone): Fix icons.
> ---
>  gnu/packages/linphone.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index c9959d7d01..8962f2001e 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -49,6 +49,7 @@
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system gnu))
>  
>  (define-public bcunit
> @@ -428,8 +429,17 @@ decoding, and rendering.")
>                                        "/lib/glib-2.0/include"))
>          "-DENABLE_STATIC=NO"            ; Not required
>          "-DENABLE_GTK_UI=YES")          ; For Legacy UI
> +       #:imported-modules (,@%cmake-build-system-modules
> +                           (guix build glib-or-gtk-build-system))
> +       #:modules ((guix build cmake-build-system)
> +                  ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
> +                  (guix build utils))
>         #:phases
>         (modify-phases %standard-phases
> +         (add-after 'install 'glib-or-gtk-compile-schemas
> +           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))
> +         (add-after 'install 'glib-or-gtk-wrap
> +           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))
>           (add-after 'unpack 'patch
>             (lambda _
>               (substitute* "gtk/main.c"
> @@ -449,6 +459,7 @@ decoding, and rendering.")
>         ("belcard" ,belcard)
>         ("bellesip" ,belle-sip)
>         ("bzrtp", bzrtp)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme) ; Hard-coded for GTK UI
>         ("glib" ,glib)
>         ("gtk2" ,gtk+-2)
>         ("mediastreamer2" ,mediastreamer2)

Tested and pushed as commit 41169f21e6.

Thank you,

Maxim