unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40575] [PATCH] gnu: Add python-diceware.
@ 2020-04-12 15:00 Matthew Kraai
  2020-04-13 21:02 ` Leo Famulari
  2020-04-13 21:55 ` Matthew Kraai
  0 siblings, 2 replies; 6+ messages in thread
From: Matthew Kraai @ 2020-04-12 15:00 UTC (permalink / raw)
  To: 40575; +Cc: Matthew Kraai

* gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
variables.
---
 gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 2ecf7115ab..081bc0eb5d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -75,6 +75,7 @@
 ;;; Copyright © 2020 Alexandros Theodotou <alex@zrythm.org>
 ;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org>
 ;;; Copyright © 2020 Alex ter Weele <alex.ter.weele@gmail.com>
+;;; Copyright © 2020 Matthew Kraai <kraai@ftbfs.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -19521,3 +19522,30 @@ there are extensions that allow you to use it with other frameworks.")
 register external CLI commands via setuptools entry-points.")
     (home-page "https://github.com/click-contrib/click-plugins")
     (license license:bsd-3)))
+
+(define-public python-diceware
+  (package
+    (name "python-diceware")
+    (version "0.9.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "diceware" version))
+       (sha256
+        (base32
+         "0klb0ysybzlh2wihvir82hgq62v0jjmlcqklwajyms7c0p529yby"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-runner" ,python-pytest-runner)))
+    (home-page "https://github.com/ulif/diceware/")
+    (synopsis "Generates memorable passphrases")
+    (description "This package generates passphrases by concatenating words
+randomly picked from wordlists.  It supports several sources of
+randomness (including real life dice) and different wordlists (including
+cryptographically signed ones).")
+    (license license:gpl3+)))
+
+(define-public python2-diceware
+  (package-with-python2 python-diceware))
-- 
2.26.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#40575] [PATCH] gnu: Add python-diceware.
  2020-04-12 15:00 [bug#40575] [PATCH] gnu: Add python-diceware Matthew Kraai
@ 2020-04-13 21:02 ` Leo Famulari
  2020-04-13 21:50   ` Matthew Kraai
  2020-04-13 21:55 ` Matthew Kraai
  1 sibling, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2020-04-13 21:02 UTC (permalink / raw)
  To: Matthew Kraai; +Cc: 40575

On Sun, Apr 12, 2020 at 08:00:36AM -0700, Matthew Kraai wrote:
> * gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
> variables.

Thanks! Overall LGTM...

> +(define-public python2-diceware
> +  (package-with-python2 python-diceware))

Do you have a use case for the Python 2 variant? We recently updated our
Python packaging standards to not add these variants unless we need
them:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=39356057bce20f74120b6d227567a943556717cc

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#40575] [PATCH] gnu: Add python-diceware.
  2020-04-13 21:02 ` Leo Famulari
@ 2020-04-13 21:50   ` Matthew Kraai
  0 siblings, 0 replies; 6+ messages in thread
From: Matthew Kraai @ 2020-04-13 21:50 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 40575

Hi Leo,

On Mon, Apr 13, 2020 at 05:02:09PM -0400, Leo Famulari wrote:
> On Sun, Apr 12, 2020 at 08:00:36AM -0700, Matthew Kraai wrote:
> > * gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
> > variables.
> 
> Thanks! Overall LGTM...
> 
> > +(define-public python2-diceware
> > +  (package-with-python2 python-diceware))
> 
> Do you have a use case for the Python 2 variant? We recently updated our
> Python packaging standards to not add these variants unless we need
> them:
> 
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=39356057bce20f74120b6d227567a943556717cc

No, I don't have a use case for the Python 2 variant.  I'll update the
patch.

-- 
Matthew Kraai

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#40575] [PATCH] gnu: Add python-diceware.
  2020-04-12 15:00 [bug#40575] [PATCH] gnu: Add python-diceware Matthew Kraai
  2020-04-13 21:02 ` Leo Famulari
@ 2020-04-13 21:55 ` Matthew Kraai
  2020-04-13 22:47   ` Leo Famulari
  1 sibling, 1 reply; 6+ messages in thread
From: Matthew Kraai @ 2020-04-13 21:55 UTC (permalink / raw)
  To: 40575; +Cc: Matthew Kraai

* gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
variables.
---
 gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 2ecf7115ab..e089d91979 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -75,6 +75,7 @@
 ;;; Copyright © 2020 Alexandros Theodotou <alex@zrythm.org>
 ;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org>
 ;;; Copyright © 2020 Alex ter Weele <alex.ter.weele@gmail.com>
+;;; Copyright © 2020 Matthew Kraai <kraai@ftbfs.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -19521,3 +19522,27 @@ there are extensions that allow you to use it with other frameworks.")
 register external CLI commands via setuptools entry-points.")
     (home-page "https://github.com/click-contrib/click-plugins")
     (license license:bsd-3)))
+
+(define-public python-diceware
+  (package
+    (name "python-diceware")
+    (version "0.9.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "diceware" version))
+       (sha256
+        (base32
+         "0klb0ysybzlh2wihvir82hgq62v0jjmlcqklwajyms7c0p529yby"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-runner" ,python-pytest-runner)))
+    (home-page "https://github.com/ulif/diceware/")
+    (synopsis "Generates memorable passphrases")
+    (description "This package generates passphrases by concatenating words
+randomly picked from wordlists.  It supports several sources of
+randomness (including real life dice) and different wordlists (including
+cryptographically signed ones).")
+    (license license:gpl3+)))
-- 
2.26.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#40575] [PATCH] gnu: Add python-diceware.
  2020-04-13 21:55 ` Matthew Kraai
@ 2020-04-13 22:47   ` Leo Famulari
  2020-04-14 18:50     ` bug#40575: " Christopher Baines
  0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2020-04-13 22:47 UTC (permalink / raw)
  To: Matthew Kraai; +Cc: 40575

On Mon, Apr 13, 2020 at 02:55:50PM -0700, Matthew Kraai wrote:
> * gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
> variables.

Thanks! Pushed as ab3ad88ded0734401667f6fb4c927ce26c39ad2e

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#40575: [PATCH] gnu: Add python-diceware.
  2020-04-13 22:47   ` Leo Famulari
@ 2020-04-14 18:50     ` Christopher Baines
  0 siblings, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2020-04-14 18:50 UTC (permalink / raw)
  To: 40575-done

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]


Leo Famulari <leo@famulari.name> writes:

> On Mon, Apr 13, 2020 at 02:55:50PM -0700, Matthew Kraai wrote:
>> * gnu/packages/python-xyz.scm (python-diceware, python2-diceware): New public
>> variables.
>
> Thanks! Pushed as ab3ad88ded0734401667f6fb4c927ce26c39ad2e

Closing the bug now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-14 18:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-12 15:00 [bug#40575] [PATCH] gnu: Add python-diceware Matthew Kraai
2020-04-13 21:02 ` Leo Famulari
2020-04-13 21:50   ` Matthew Kraai
2020-04-13 21:55 ` Matthew Kraai
2020-04-13 22:47   ` Leo Famulari
2020-04-14 18:50     ` bug#40575: " Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).