unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
@ 2018-04-12 22:40 Tomáš Čech
       [not found] ` <handler.31141.B.152357282812931.ack@debbugs.gnu.org>
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Tomáš Čech @ 2018-04-12 22:40 UTC (permalink / raw)
  To: 31141

* gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
[arguments]: Help configure with locating mit-krb5.
---
 gnu/packages/curl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
index fbf177d9d..38f7195ca 100644
--- a/gnu/packages/curl.scm
+++ b/gnu/packages/curl.scm
@@ -36,6 +36,7 @@
   #:use-module (gnu packages golang)
   #:use-module (gnu packages groff)
   #:use-module (gnu packages gsasl)
+  #:use-module (gnu packages kerberos)
   #:use-module (gnu packages libidn)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages perl)
@@ -60,9 +61,9 @@
    (outputs '("out"
               "doc"))                             ;1.2 MiB of man3 pages
    (inputs `(("gnutls" ,gnutls)
-             ("gss" ,gss)
              ("libidn" ,libidn)
              ("libssh2" ,libssh2)
+             ("mit-krb5" ,mit-krb5)
              ("openldap" ,openldap)
              ("zlib" ,zlib)))
    (native-inputs
@@ -81,7 +82,10 @@
            (separator #f)                         ;single entry
            (files '("etc/ssl/certs/ca-certificates.crt")))))
    (arguments
-    `(#:configure-flags '("--with-gnutls" "--with-gssapi")
+    `(#:configure-flags (list
+                         "--with-gnutls"
+                         (string-append "--with-gssapi="
+                                        (assoc-ref %build-inputs "mit-krb5")))
       ;; Add a phase to patch '/bin/sh' occurances in tests/runtests.pl
       #:phases
       (modify-phases %standard-phases
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#31141] Acknowledgement ([PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.)
       [not found] ` <handler.31141.B.152357282812931.ack@debbugs.gnu.org>
@ 2018-04-21 15:52   ` Tomáš Čech
  0 siblings, 0 replies; 7+ messages in thread
From: Tomáš Čech @ 2018-04-21 15:52 UTC (permalink / raw)
  To: 31141

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

Hi,

did anyone have time to have a look on this change?

Is that problematic for you?


Best regards,

S_W

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
  2018-04-12 22:40 [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation Tomáš Čech
       [not found] ` <handler.31141.B.152357282812931.ack@debbugs.gnu.org>
@ 2018-04-21 16:10 ` Tomáš Čech
  2018-04-23 12:57   ` Ludovic Courtès
  2020-04-09 22:50 ` bug#31141: [PATCH] gnu: curl: Use mit-krb5 as GSSAPI Efraim Flashner
  2 siblings, 1 reply; 7+ messages in thread
From: Tomáš Čech @ 2018-04-21 16:10 UTC (permalink / raw)
  To: 31141

* gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
[arguments]: Help configure with locating mit-krb5.
---
 gnu/packages/curl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
index ae8b9600d..b5e1f52da 100644
--- a/gnu/packages/curl.scm
+++ b/gnu/packages/curl.scm
@@ -38,6 +38,7 @@
   #:use-module (gnu packages groff)
   #:use-module (gnu packages gsasl)
   #:use-module (gnu packages guile)
+  #:use-module (gnu packages kerberos)
   #:use-module (gnu packages libidn)
   #:use-module (gnu packages openldap)
   #:use-module (gnu packages perl)
@@ -62,9 +63,9 @@
    (outputs '("out"
               "doc"))                             ;1.2 MiB of man3 pages
    (inputs `(("gnutls" ,gnutls)
-             ("gss" ,gss)
              ("libidn" ,libidn)
              ("libssh2" ,libssh2)
+             ("mit-krb5" ,mit-krb5)
              ("openldap" ,openldap)
              ("zlib" ,zlib)))
    (native-inputs
@@ -83,7 +84,10 @@
            (separator #f)                         ;single entry
            (files '("etc/ssl/certs/ca-certificates.crt")))))
    (arguments
-    `(#:configure-flags '("--with-gnutls" "--with-gssapi")
+    `(#:configure-flags (list
+                         "--with-gnutls"
+                         (string-append "--with-gssapi="
+                                        (assoc-ref %build-inputs "mit-krb5")))
       ;; Add a phase to patch '/bin/sh' occurances in tests/runtests.pl
       #:phases
       (modify-phases %standard-phases
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
  2018-04-21 16:10 ` [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation Tomáš Čech
@ 2018-04-23 12:57   ` Ludovic Courtès
  2018-04-23 14:53     ` Tomáš Čech
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2018-04-23 12:57 UTC (permalink / raw)
  To: Tomáš Čech; +Cc: 31141

Hello,

Tomáš Čech <sleep_walker@gnu.org> skribis:

> * gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
> [arguments]: Help configure with locating mit-krb5.
> ---
>  gnu/packages/curl.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
> index ae8b9600d..b5e1f52da 100644
> --- a/gnu/packages/curl.scm
> +++ b/gnu/packages/curl.scm
> @@ -38,6 +38,7 @@
>    #:use-module (gnu packages groff)
>    #:use-module (gnu packages gsasl)
>    #:use-module (gnu packages guile)
> +  #:use-module (gnu packages kerberos)
>    #:use-module (gnu packages libidn)
>    #:use-module (gnu packages openldap)
>    #:use-module (gnu packages perl)
> @@ -62,9 +63,9 @@
>     (outputs '("out"
>                "doc"))                             ;1.2 MiB of man3 pages
>     (inputs `(("gnutls" ,gnutls)
> -             ("gss" ,gss)
>               ("libidn" ,libidn)
>               ("libssh2" ,libssh2)
> +             ("mit-krb5" ,mit-krb5)

Could you explain the rationale?  In general, if there’s a choice and no
compelling reason to do otherwise, we try to favor the GNU
implementation (in this case, GNU GSS) by default.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
  2018-04-23 12:57   ` Ludovic Courtès
@ 2018-04-23 14:53     ` Tomáš Čech
  2018-04-23 15:24       ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Tomáš Čech @ 2018-04-23 14:53 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 31141

[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]

Hello,

On Mon, Apr 23, 2018 at 02:57:34PM +0200, Ludovic Courtès wrote:
>Hello,
>
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> * gnu/packages/curl.scm (curl)[inputs]: Replace gss with mit-krb5.
>> [arguments]: Help configure with locating mit-krb5.
>> ---
>>  gnu/packages/curl.scm | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm
>> index ae8b9600d..b5e1f52da 100644
>> --- a/gnu/packages/curl.scm
>> +++ b/gnu/packages/curl.scm
>> @@ -38,6 +38,7 @@
>>    #:use-module (gnu packages groff)
>>    #:use-module (gnu packages gsasl)
>>    #:use-module (gnu packages guile)
>> +  #:use-module (gnu packages kerberos)
>>    #:use-module (gnu packages libidn)
>>    #:use-module (gnu packages openldap)
>>    #:use-module (gnu packages perl)
>> @@ -62,9 +63,9 @@
>>     (outputs '("out"
>>                "doc"))                             ;1.2 MiB of man3 pages
>>     (inputs `(("gnutls" ,gnutls)
>> -             ("gss" ,gss)
>>               ("libidn" ,libidn)
>>               ("libssh2" ,libssh2)
>> +             ("mit-krb5" ,mit-krb5)
>
>Could you explain the rationale?  In general, if there’s a choice and no
>compelling reason to do otherwise, we try to favor the GNU
>implementation (in this case, GNU GSS) by default.

I am using curl against services with Kerberos authentication. Login
against authority server and obtain ticket proving that I am who I
am. I can use that ticket against services.

I'm not able to do the same with GNU GSS implementation. I might be
wrong but it didn't seem to allow me to do the same at least in the
shape we have it.

After this change it works for me as expected.

Best regards,

S_W

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.
  2018-04-23 14:53     ` Tomáš Čech
@ 2018-04-23 15:24       ` Ludovic Courtès
  0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2018-04-23 15:24 UTC (permalink / raw)
  To: Tomáš Čech; +Cc: 31141

Hello,

Tomáš Čech <sleep_walker@gnu.org> skribis:

> I am using curl against services with Kerberos authentication. Login
> against authority server and obtain ticket proving that I am who I
> am. I can use that ticket against services.
>
> I'm not able to do the same with GNU GSS implementation. I might be
> wrong but it didn't seem to allow me to do the same at least in the
> shape we have it.

I just realized that the equivalent of mit-krb5 would be GNU Shishi, not
GNU GSS.  Does that one work for you?  (Perhaps GSS is still needed in
addition to Shishi though, dunno.)

If not, I have nothing against switching to mit-krb5 if that doesn’t
work either, with a comment explaining it.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#31141: [PATCH] gnu: curl: Use mit-krb5 as GSSAPI
  2018-04-12 22:40 [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation Tomáš Čech
       [not found] ` <handler.31141.B.152357282812931.ack@debbugs.gnu.org>
  2018-04-21 16:10 ` [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation Tomáš Čech
@ 2020-04-09 22:50 ` Efraim Flashner
  2 siblings, 0 replies; 7+ messages in thread
From: Efraim Flashner @ 2020-04-09 22:50 UTC (permalink / raw)
  To: 31141-done

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

This seems to have been applied with commit
828d3765a71ce1b74d1ab122c84d5c16eabf98b9 in May 2019.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-04-09 22:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 22:40 [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation Tomáš Čech
     [not found] ` <handler.31141.B.152357282812931.ack@debbugs.gnu.org>
2018-04-21 15:52   ` [bug#31141] Acknowledgement ([PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation.) Tomáš Čech
2018-04-21 16:10 ` [bug#31141] [PATCH] gnu: curl: Use mit-krb5 as GSSAPI implementation Tomáš Čech
2018-04-23 12:57   ` Ludovic Courtès
2018-04-23 14:53     ` Tomáš Čech
2018-04-23 15:24       ` Ludovic Courtès
2020-04-09 22:50 ` bug#31141: [PATCH] gnu: curl: Use mit-krb5 as GSSAPI Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).