From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 40227-done@debbugs.gnu.org
Subject: bug#40227: [PATCH] gnu: icu4c: Fix CVE-2020-10531.
Date: Wed, 25 Mar 2020 17:54:27 -0400 [thread overview]
Message-ID: <20200325215427.GA29579@jasmine.lan> (raw)
In-Reply-To: <87v9msyyii.fsf@devup.no>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Wed, Mar 25, 2020 at 09:23:33PM +0100, Marius Bakke wrote:
> I'm not sure if the new test case as well as this git commit header is
> necessary. IMO it mostly adds noise to the patch. I.e. the whole file
> could be shortened to 6 lines + your comments at the top.
>
> But no strong opinion, there is an argument to be made for preserving
> upstream commits in their entirety too (I think).
>
> So, LGTM either way. Thank you!
I commented out the changes to the test suite and pushed as
7d57a190f6896c04b5dad66bf4360bc48a4052ff.
Thanks for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-25 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:36 [bug#40227] [PATCH] gnu: icu4c: Fix CVE-2020-10531 Leo Famulari
2020-03-25 20:23 ` Marius Bakke
2020-03-25 21:54 ` Leo Famulari [this message]
2020-03-25 22:41 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325215427.GA29579@jasmine.lan \
--to=leo@famulari.name \
--cc=40227-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).