From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:51549) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHDzL-0006wh-Tj for guix-patches@gnu.org; Wed, 25 Mar 2020 17:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHDzK-0004Mg-P2 for guix-patches@gnu.org; Wed, 25 Mar 2020 17:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHDzK-0004MY-Ks for guix-patches@gnu.org; Wed, 25 Mar 2020 17:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jHDzK-0001Hv-Kb for guix-patches@gnu.org; Wed, 25 Mar 2020 17:55:02 -0400 Subject: bug#40227: [PATCH] gnu: icu4c: Fix CVE-2020-10531. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Wed, 25 Mar 2020 17:54:27 -0400 From: Leo Famulari Message-ID: <20200325215427.GA29579@jasmine.lan> References: <87v9msyyii.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <87v9msyyii.fsf@devup.no> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 40227-done@debbugs.gnu.org --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 25, 2020 at 09:23:33PM +0100, Marius Bakke wrote: > I'm not sure if the new test case as well as this git commit header is > necessary. IMO it mostly adds noise to the patch. I.e. the whole file > could be shortened to 6 lines + your comments at the top. >=20 > But no strong opinion, there is an argument to be made for preserving > upstream commits in their entirety too (I think). >=20 > So, LGTM either way. Thank you! I commented out the changes to the test suite and pushed as 7d57a190f6896c04b5dad66bf4360bc48a4052ff. Thanks for the review! --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl570xMACgkQJkb6MLrK fwjB7RAAgIPq4a6n6FB4Gu76PpFDAOvGoCsQlLviPSVeP43OkkgvpR/g2GjlLLSt HZDKLYeec1uOAZj9fuGz+aJzRIclrLTdWls8THXXXF/L5FXUhoBWQubSvj54/yiu o5R9K1/w5pvnHE1gSwGZJGRB8aFH+hcZxMqtnpk7J+XkbQik12PxlNjAh7iubbp5 d/9IDNxdnjoDCH94w3VbSEPTSY+iKSCLLh1bsD8jVL4F2/u3ocO051x+D2NGexMT 0ftnLIU5HQ/PFpWS1hcHXW0MXWn1/hU1yBvjDKksYfwVfV8fM/7a2LeB3qeva63/ K/e17QLnCv5ridxNnO9ndUzSfuHMzaIx3y9en4JrmHQVcPw56flnrbn2BPtmBZN9 AKwWJ//kkYsjcmHjyHOmnbG/LiDCVkfQGc8jt33DLvwFmQuTCiIgvKXJE3UDyyYc PQe0lmhz2/GjkC/fEdwyXSeA10RU8povQCBqeYemzTug1zi0ncveAIziYaTeBLut MMJwehgIvdQdul2ALSRUiLTin+p0bfZhqnHDMVEgyUCZzzx256cecSbzsol3NgE4 nl5dZFxrncZ4RIBOpqdoXF0fM5m+In4YVYlUHNq0D+Z1pogAGlovt2/7pxUYjh4w FvJQEVBnVEVRsobJrfilTBWQnCYHN0d8OciW1Yq2IaIZlgfJCCk= =ab6S -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--