unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Naga Malleswari <nagamalli@riseup.net>
Cc: 40040@debbugs.gnu.org
Subject: [bug#40040] Submission of Patch for Package Description for CRAN Package r-crochet
Date: Thu, 12 Mar 2020 18:06:29 +0100	[thread overview]
Message-ID: <20200312180629.6aad084e@scratchpost.org> (raw)
In-Reply-To: <6f2765ba-6120-d07f-828b-c8d1c2609d6e@riseup.net>

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

Hi,

that patch does not apply to guix master.

Could you rebase it?

You can do that using

  git pull --rebase

Then you can regenerate the patch via

  git format-patch -1

and send it to this bug report as version 2.

Thanks!

Other than that, I did a license review and that seems fine.

Please do not add trailing newlines at the end of the file.

Please also make sure to use

  ./pre-inst-env guix lint r-crochet

in order to find out obvious problems with it, if any.

In this case, guix lint warns that '[' and other code-like things should be
enclosed in the texinfo tag @code instead, for example:

@code{[}

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-03-12 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 11:46 [bug#40040] Submission of Patch for Package Description for CRAN Package r-crochet Naga Malleswari
2020-03-12 17:06 ` Danny Milosavljevic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312180629.6aad084e@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=40040@debbugs.gnu.org \
    --cc=nagamalli@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).