From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39835) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCRIX-0002Hx-Bw for guix-patches@gnu.org; Thu, 12 Mar 2020 13:07:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCRIU-00081Q-DA for guix-patches@gnu.org; Thu, 12 Mar 2020 13:07:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCRIU-00081H-94 for guix-patches@gnu.org; Thu, 12 Mar 2020 13:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jCRIU-0002Xi-2l for guix-patches@gnu.org; Thu, 12 Mar 2020 13:07:02 -0400 Subject: [bug#40040] Submission of Patch for Package Description for CRAN Package r-crochet Resent-Message-ID: Date: Thu, 12 Mar 2020 18:06:29 +0100 From: Danny Milosavljevic Message-ID: <20200312180629.6aad084e@scratchpost.org> In-Reply-To: <6f2765ba-6120-d07f-828b-c8d1c2609d6e@riseup.net> References: <6f2765ba-6120-d07f-828b-c8d1c2609d6e@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+vcHglBx__e7DEmduALv1dk"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Naga Malleswari Cc: 40040@debbugs.gnu.org --Sig_/+vcHglBx__e7DEmduALv1dk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, that patch does not apply to guix master. Could you rebase it? You can do that using git pull --rebase Then you can regenerate the patch via git format-patch -1 and send it to this bug report as version 2. Thanks! Other than that, I did a license review and that seems fine. Please do not add trailing newlines at the end of the file. Please also make sure to use ./pre-inst-env guix lint r-crochet in order to find out obvious problems with it, if any. In this case, guix lint warns that '[' and other code-like things should be enclosed in the texinfo tag @code instead, for example: @code{[} --Sig_/+vcHglBx__e7DEmduALv1dk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5qbBUACgkQ5xo1VCww uqUpsQf/VLx9YwvrZk3OcA+uUuY0FoOxTZodXZCvPxcWXf1nsfAkABeG6Kgv8Slh rn04/VNfc5IldxqJZ3cYx6tz8EwWB8oz+JTNAMmrIDonBVgIbtesaELE7Wp+7sUt Ii0rFep8wXk/QPyiK9eKADS93+x3WbonGrSPqt5al79EUj+P5N+lvZHzsPtByxQp jUNVMo3pRy0QfEILurHMGpLO+yN+iO23Gua7L0mRDb3zfJK25vKTmeRG8zNOaAXM DpX6UDtjPiBEXIhR7XlDRCZ9aZT/GeUBIret0nFANGTOe0jHiovXMsg0HRL4a4ZR hPgmiIwdYzP2ZEEzTKE/B/Hg/Bv1ng== =oB6B -----END PGP SIGNATURE----- --Sig_/+vcHglBx__e7DEmduALv1dk--