unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40021@debbugs.gnu.org
Subject: [bug#40021] gnu: Add mm-common.
Date: Wed, 11 Mar 2020 16:24:32 +0100	[thread overview]
Message-ID: <20200311162432.089a7c18@scratchpost.org> (raw)
In-Reply-To: <48564a26953b8419f74f44fc5d328c14@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Hi RG,

On Tue, 10 Mar 2020 23:01:00 +0000
"Raghav Gururajan" <raghavgururajan@disroot.org> wrote:

> Please find the attached patch to add 'mm-common' package to guix.

I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
the result using diffoscope there's no functional difference.

Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
doesn't do anything.

This package contains unpatched references to perl, git, ln and other
programs, which means that those programs are looked up in $PATH and
most probably will not be found.

It also contains patched references to python.

That's not consistent.

Please research what the package is supposed to do.  If perl, git and
ln are internally required modules, let's patch them.

If they are external "composing" modules, let's leave them as-is.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-03-11 15:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 23:01 [bug#40021] gnu: Add mm-common Raghav Gururajan
2020-03-11 15:24 ` Danny Milosavljevic [this message]
2020-03-19  6:34 ` Raghav Gururajan
2020-03-19  9:27   ` Marius Bakke
2020-03-21 19:21   ` Danny Milosavljevic
2020-03-22  1:16   ` Raghav Gururajan
2020-03-22 11:42     ` Danny Milosavljevic
2020-04-05  4:05 ` Raghav Gururajan
2020-04-05 18:59   ` bug#40021: " Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311162432.089a7c18@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=40021@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).