From: "Raghav Gururajan" <raghavgururajan@disroot.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 40021@debbugs.gnu.org
Subject: [bug#40021] gnu: Add mm-common.
Date: Sun, 05 Apr 2020 04:05:50 +0000 [thread overview]
Message-ID: <0b5576a3730af6600ad0d7b19368d6e2@disroot.org> (raw)
In-Reply-To: <20200311162432.089a7c18@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Hi Danny!
> I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
> the result using diffoscope there's no functional difference.
>
> Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
> doesn't do anything.
You are right, it is not required for this package.
> This package contains unpatched references to perl, git, ln and other
> programs, which means that those programs are looked up in $PATH and
> most probably will not be found.
>
> It also contains patched references to python.
>
> That's not consistent.
>
> Please research what the package is supposed to do. If perl, git and
> ln are internally required modules, let's patch them.
>
> If they are external "composing" modules, let's leave them as-is.
I have checked and they are not internally required. Only python is required which is already patched. :-)
Please find the revised patch, attached with this email.
Regards,
RG.
[-- Attachment #2: 0018-gnu-Add-mm-common.patch --]
[-- Type: application/octet-stream, Size: 1799 bytes --]
From 88c9917dff5c5d5a589c0c0daedaed8c6a478103 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 5 Apr 2020 00:01:52 -0400
Subject: [PATCH 18/18] gnu: Add mm-common
* gnu/packages/gnome.scm (mm-common): New variable.
---
gnu/packages/gnome.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6178ee1010..a14502f940 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -249,6 +249,32 @@ Desktop. It is designed to be as simple as possible and has some unique
features to enable users to create their discs easily and quickly.")
(license license:gpl2+)))
+(define-public mm-common
+ (package
+ (name "mm-common")
+ (version "1.0.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1m4w33da9f4rx2d6kdj3ix3kl0gn16ml82v2mdn4hljr3q29nzdr"))))
+ (build-system meson-build-system)
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("python" ,python)))
+ (synopsis "Module of GNOME C++ bindings")
+ (description "The mm-common module provides the build infrastructure
+and utilities shared among the GNOME C++ binding libraries. Release
+archives of mm-common include the Doxygen tag file for the GNU C++
+Library reference documentation.")
+ (home-page "https://gitlab.gnome.org/GNOME/mm-common")
+ (license license:gpl2+)))
+
(define-public phodav
(package
(name "phodav")
--
2.26.0
next prev parent reply other threads:[~2020-04-05 4:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 23:01 [bug#40021] gnu: Add mm-common Raghav Gururajan
2020-03-11 15:24 ` Danny Milosavljevic
2020-03-19 6:34 ` Raghav Gururajan
2020-03-19 9:27 ` Marius Bakke
2020-03-21 19:21 ` Danny Milosavljevic
2020-03-22 1:16 ` Raghav Gururajan
2020-03-22 11:42 ` Danny Milosavljevic
2020-04-05 4:05 ` Raghav Gururajan [this message]
2020-04-05 18:59 ` bug#40021: " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b5576a3730af6600ad0d7b19368d6e2@disroot.org \
--to=raghavgururajan@disroot.org \
--cc=40021@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).