unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch monospace font.
@ 2020-02-25 14:59 Leo Prikler
  2020-03-15 13:41 ` Leo Prikler
  2020-03-20 18:02 ` bug#39783: " Marius Bakke
  0 siblings, 2 replies; 3+ messages in thread
From: Leo Prikler @ 2020-02-25 14:59 UTC (permalink / raw)
  To: 39783

* gnu/packages/gnome.scm (gsettings-desktop-schemas)[arguments]<phases>:
Rename `set-adwaita-theme-file-name' to the more generic `patch-schemas'.
Add patch for the monospace font (Source Code Pro 10 -> Monospace 11).
Adjust comments.
---
 gnu/packages/gnome.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index af45ceb505..e066b4c93c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1575,15 +1575,17 @@ on the GNOME Desktop with a single simple application.")
     (build-system meson-build-system)
     (arguments
      '(#:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'set-adwaita-theme-file-name
+                  (add-after 'unpack 'patch-schemas
                     (lambda* (#:key inputs #:allow-other-keys)
-                      ;; Provide the correct file name of the default GNOME
-                      ;; background, 'adwaita-timed.xml'.
                       (let ((theme (assoc-ref inputs "gnome-backgrounds")))
                         (substitute* (find-files "schemas"
                                                  "\\.gschema\\.xml\\.in$")
+                          ;; Provide the correct file name of the default GNOME
+                          ;; background, 'adwaita-timed.xml'.
                           (("@datadir@/backgrounds/gnome")
-                           (string-append theme "/share/backgrounds/gnome")))
+                           (string-append theme "/share/backgrounds/gnome"))
+                          ;; Do not reference fonts, that may not exist.
+                          (("'Source Code Pro 10'") "'Monospace 11'"))
                         #t))))))
     (inputs
      `(("glib" ,glib)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch monospace font.
  2020-02-25 14:59 [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch monospace font Leo Prikler
@ 2020-03-15 13:41 ` Leo Prikler
  2020-03-20 18:02 ` bug#39783: " Marius Bakke
  1 sibling, 0 replies; 3+ messages in thread
From: Leo Prikler @ 2020-03-15 13:41 UTC (permalink / raw)
  To: 39783

It appears this has fallen under the radar.
To perhaps clarify the intent of this patch, it fixes the bug, where
GNOME Terminal and other stuff that relies on the Monospace font being
defined appears quite ugly with the default settings.

Regards,
Leo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#39783: [PATCH] gnu: gsettings-desktop-schemas: patch monospace font.
  2020-02-25 14:59 [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch monospace font Leo Prikler
  2020-03-15 13:41 ` Leo Prikler
@ 2020-03-20 18:02 ` Marius Bakke
  1 sibling, 0 replies; 3+ messages in thread
From: Marius Bakke @ 2020-03-20 18:02 UTC (permalink / raw)
  To: Leo Prikler, 39783-done

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/packages/gnome.scm (gsettings-desktop-schemas)[arguments]<phases>:
> Rename `set-adwaita-theme-file-name' to the more generic `patch-schemas'.
> Add patch for the monospace font (Source Code Pro 10 -> Monospace 11).
> Adjust comments.

Thanks for finding the root cause of the broken default gnome-terminal
font.  Since there has been no feedback in a couple of weeks, I went
ahead and applied it.

I also updated your copyright header.  Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-20 18:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25 14:59 [bug#39783] [PATCH] gnu: gsettings-desktop-schemas: patch monospace font Leo Prikler
2020-03-15 13:41 ` Leo Prikler
2020-03-20 18:02 ` bug#39783: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).