From: Leo Famulari <leo@famulari.name>
To: Simon Nielsen <tauoverpi@yandex.com>
Cc: 39480@debbugs.gnu.org
Subject: [bug#39480] [PATCH] gnu: Add zig compiler
Date: Fri, 21 Feb 2020 13:07:50 -0500 [thread overview]
Message-ID: <20200221180750.GA4850@jasmine.lan> (raw)
In-Reply-To: <11943681581079241@vla1-d97dbca235a9.qloud-c.yandex.net>
On Fri, Feb 07, 2020 at 01:40:41PM +0100, Simon Nielsen wrote:
> Hi,
>
> Adds the zig compiler as a new file in `gnu/packages/`
Thanks! Please add it to 'gnu/local.mk'.
> +(define-public zig-0.5.0
We can name it 'zig' until there are multiple versions in Guix.
> + `(#:tests? #f
Why are the tests disabled? Is it because there is no test suite? Or
something else? Please add a brief code comment explaining it.
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'build 'fix-build
> + (lambda _ (setenv "HOME" "/tmp") #t)))))
I guess that the build tries to access $HOME?
> + (description
> + "Programming languaged designed for robustness, optimality, and clarity")
Can you try to make a more detailed description here? At least it should
be a complete sentence.
> + (synopsis
> + "Programming languaged designed for robustness, optimality, and clarity")
Typo: languaged
next prev parent reply other threads:[~2020-02-21 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 12:40 [bug#39480] [PATCH] gnu: Add zig compiler Simon Nielsen
2020-02-21 18:07 ` Leo Famulari [this message]
2020-11-20 20:38 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221180750.GA4850@jasmine.lan \
--to=leo@famulari.name \
--cc=39480@debbugs.gnu.org \
--cc=tauoverpi@yandex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).