From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:46196)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5CiZ-0005RH-LL
 for guix-patches@gnu.org; Fri, 21 Feb 2020 13:08:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5CiY-0001Cm-Jr
 for guix-patches@gnu.org; Fri, 21 Feb 2020 13:08:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:42110)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j5CiY-0001Cc-Dk
 for guix-patches@gnu.org; Fri, 21 Feb 2020 13:08:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j5CiY-0007Hd-82
 for guix-patches@gnu.org; Fri, 21 Feb 2020 13:08:02 -0500
Subject: [bug#39480] [PATCH] gnu: Add zig compiler
Resent-Message-ID: <handler.39480.B39480.158230847927988@debbugs.gnu.org>
Date: Fri, 21 Feb 2020 13:07:50 -0500
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200221180750.GA4850@jasmine.lan>
References: <11943681581079241@vla1-d97dbca235a9.qloud-c.yandex.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <11943681581079241@vla1-d97dbca235a9.qloud-c.yandex.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Simon Nielsen <tauoverpi@yandex.com>
Cc: 39480@debbugs.gnu.org

On Fri, Feb 07, 2020 at 01:40:41PM +0100, Simon Nielsen wrote:
> Hi,
> 
> Adds the zig compiler as a new file in `gnu/packages/`

Thanks! Please add it to 'gnu/local.mk'.

> +(define-public zig-0.5.0

We can name it 'zig' until there are multiple versions in Guix.

> +     `(#:tests? #f

Why are the tests disabled? Is it because there is no test suite? Or
something else? Please add a brief code comment explaining it.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'fix-build
> +           (lambda _ (setenv "HOME" "/tmp") #t)))))

I guess that the build tries to access $HOME?

> +    (description
> +      "Programming languaged designed for robustness, optimality, and clarity")

Can you try to make a more detailed description here? At least it should
be a complete sentence.

> +    (synopsis
> +      "Programming languaged designed for robustness, optimality, and clarity")

Typo: languaged