From: Efraim Flashner <efraim@flashner.co.il>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: 39445-done@debbugs.gnu.org
Subject: bug#39445: [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature
Date: Tue, 11 Feb 2020 20:25:42 +0200 [thread overview]
Message-ID: <20200211182542.GD26092@E5400> (raw)
In-Reply-To: <20200210112813.cgs4hbra2konsz5j@gravity>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Mon, Feb 10, 2020 at 12:28:13PM +0100, Jakub Kądziołka wrote:
> On Mon, Feb 10, 2020 at 10:43:51AM +0200, Efraim Flashner wrote:
> > Should the install phase also get the '--release' flag?
>
> It's a reasonable question to ask, but no. `cargo install' will always
> use a release build. Moreover, passing the --release flag to cargo
> install will lead to an unexpected argument error.
That's unfortunate. I was hoping to re-use the cargo-build-flags option.
Might still be worth it, after adding logic to strip out the '--release'
flag.
Patches pushed.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-02-11 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 21:36 [bug#39445] [PATCH] gnu: ripgrep: Install the manpage Jakub Kądziołka
2020-02-09 21:51 ` [bug#39445] [PATCH v2 1/2] " Jakub Kądziołka
2020-02-09 21:51 ` [bug#39445] [PATCH v2 2/2] gnu: ripgrep: enable the 'pcre2' feature Jakub Kądziołka
2020-02-10 8:43 ` Efraim Flashner
2020-02-10 11:28 ` Jakub Kądziołka
2020-02-11 18:25 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211182542.GD26092@E5400 \
--to=efraim@flashner.co.il \
--cc=39445-done@debbugs.gnu.org \
--cc=kuba@kadziolka.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).